Support systemd named hierarchy and emulate cgroup namespaces for v1 control cgroups #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 74.90% 74.76% -0.14%
==========================================
Files 51 52 +1
Lines 7781 8121 +340
==========================================
+ Hits 5828 6072 +244
- Misses 1953 2049 +96 |
|
@Furisto I am sorry, but I have conflated this PR. |
Furisto
force-pushed
the
cg-ns-em-redo
branch
2 times, most recently
from
620ef5f to
04909e7
Compare
|
@utam0k Now it's mergeable again |
utam0k
reviewed
Oct 9, 2021
| .with_context(|| format!("failed to mount {:?}", subsystem_mount)) | ||
| } | ||
|
|
||
| fn setup_emulated_subsystem( |
There was a problem hiding this comment.
Can I ask you to add comments and unit tests for this function?
|
@utam0k PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two features: