Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part of PR 340 adding test_make_parent_mount_private #374

Conversation

tommady
Copy link
Collaborator

@tommady tommady commented Oct 8, 2021

as requested by separating #340 into small PRs

this part is adding:

  • test_make_parent_mount_private
  • test_setup_namespaced_hierarchy ( removed
  • test_setup_comount_symlinks ( removed

please help review 🙇🏻

@tommady tommady changed the title [WIP] part of PR 340 adding test_make_parent_mount_private [WIP] part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy Oct 8, 2021
@tommady tommady force-pushed the 279-increate-the-code-coverage-of-src-rootfs-part-7 branch from 736c5ca to b36b9db Compare October 8, 2021 15:48
@tommady tommady changed the title [WIP] part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy [WIP] part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy, test_setup_comount_symlinks Oct 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2021

Codecov Report

Merging #374 (4c90cfd) into main (c86c6bb) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   74.73%   74.91%   +0.17%     
==========================================
  Files          51       51              
  Lines        7763     7781      +18     
==========================================
+ Hits         5802     5829      +27     
+ Misses       1961     1952       -9     

@tommady tommady marked this pull request as ready for review October 9, 2021 06:19
@tommady tommady changed the title [WIP] part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy, test_setup_comount_symlinks part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy, test_setup_comount_symlinks Oct 9, 2021
@tommady
Copy link
Collaborator Author

tommady commented Oct 9, 2021

I noticed there has a PR
#373

did the same things for this PR's

  1. test_setup_namespaced_hierarchy ---> this one's name has changed
  2. test_setup_comount_symlinks ---> this one tested in that PR

so I'll remove those two tests in this PR to avoid conflicting

@tommady tommady changed the title part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy, test_setup_comount_symlinks part of PR 340 adding test_make_parent_mount_private Oct 9, 2021
src/rootfs/mount.rs Outdated Show resolved Hide resolved
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utam0k utam0k merged commit b23cfc8 into youki-dev:main Oct 9, 2021
@tommady tommady deleted the 279-increate-the-code-coverage-of-src-rootfs-part-7 branch October 11, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants