-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
part of PR 340 adding test_make_parent_mount_private #374
Merged
utam0k
merged 5 commits into
youki-dev:main
from
tommady:279-increate-the-code-coverage-of-src-rootfs-part-7
Oct 9, 2021
Merged
part of PR 340 adding test_make_parent_mount_private #374
utam0k
merged 5 commits into
youki-dev:main
from
tommady:279-increate-the-code-coverage-of-src-rootfs-part-7
Oct 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommady
changed the title
[WIP] part of PR 340 adding test_make_parent_mount_private
[WIP] part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy
Oct 8, 2021
tommady
force-pushed
the
279-increate-the-code-coverage-of-src-rootfs-part-7
branch
from
October 8, 2021 15:48
736c5ca
to
b36b9db
Compare
tommady
changed the title
[WIP] part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy
[WIP] part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy, test_setup_comount_symlinks
Oct 9, 2021
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 74.73% 74.91% +0.17%
==========================================
Files 51 51
Lines 7763 7781 +18
==========================================
+ Hits 5802 5829 +27
+ Misses 1961 1952 -9 |
tommady
changed the title
[WIP] part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy, test_setup_comount_symlinks
part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy, test_setup_comount_symlinks
Oct 9, 2021
I noticed there has a PR did the same things for this PR's
so I'll remove those two tests in this PR to avoid conflicting |
tommady
changed the title
part of PR 340 adding test_make_parent_mount_private, test_setup_namespaced_hierarchy, test_setup_comount_symlinks
part of PR 340 adding test_make_parent_mount_private
Oct 9, 2021
Furisto
reviewed
Oct 9, 2021
utam0k
approved these changes
Oct 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tommady
deleted the
279-increate-the-code-coverage-of-src-rootfs-part-7
branch
October 11, 2021 12:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested by separating #340 into small PRs
this part is adding:
please help review 🙇🏻