-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsrc sync -r support #362
tsrc sync -r support #362
Conversation
I forgot to mention. I didn't update the change log file, since it is not included in |
I resolved the conflicts and did a small refactor that I felt was necessary: after the cli arg rename from I think that to merge this PR we just need to resolve that single review comment. Can you do that please, @vonpupp? It would be great if you could also add a test for the new cli arg for |
Hello,
Following up on #359, I took the liberty of submit this PR to add
-r
support to the sync command.I had to take decisions because of the
-r
arg collision, so I decided to change the regex inclusive arg to-i
and the exclusive arg to-e
, which made sense to me.I ran lint and tests. Everything seems to be okay. I also fixed some typos in the doc regarding multiple remotes.
I hope this makes sense and gets accepted. Best regards.