[YSQL] Display PG catalog cache misses for each catalog cache #22843
Assignees
Labels
area/ysql
Yugabyte SQL (YSQL)
kind/enhancement
This is an enhancement of an existing feature
priority/medium
Medium priority issue
Comments
yugabyte-ci
added
kind/enhancement
myang2021
added a commit
that referenced
this issue
Jul 12, 2024
…che misses Summary: YSQL provides a gflag `--ysql_catalog_preload_additional_table_list` that customers can use to preload a list of catalog tables to build a set of catalog caches. This can help to speed up the first query as it will see fewer cache misses. However it requires some manual work in order to figure out what to put in the list of catalog tables to preload. One way is to make a connection and execute `SET yb_debug_log_docdb_requests = true` then parse the postgres logs to see what catalog tables are being read in the read requests. We already have a counter `NumCatalogCacheMisses` that is exported to the PG webserver 13000 port. It is the number of accumulated cache misses that is recorded in the PG shared memory. Each time `SearchCatCacheMiss` is invoked, `NumCatalogCacheMisses` is incremented. At the end of the top-most query boundary, we compute the delta since last time and add it to the counter stored in shared memory. This counter can be accessed via the 13000 port. This diff expands the counter `NumCatalogCacheMisses` with `YbNumCatalogCacheIdMisses` which is an array of counters, one for each catalog cache, indexed by its id. In this way from the 13000 port we can see how many cache misses have happened for each catalog cache. If a catalog cache shows a large number of cache misses, it is an indication that its corresponding catalog table should be added to the list of catalog tables to preload. I also did some variable/function renames according to YB naming convention. Jira: DB-11741 Test Plan: (1) ./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.CatalogCacheIdMissMetricsTest (2) manual test ``` ./bin/yb-ctl create --rf 1 ./bin/ysqlsh ysqlsh (11.2-YB-2.23.0.0-b0) Type "help" for help. yugabyte=# create table foo(id int); CREATE TABLE yugabyte=# insert into foo values (10); INSERT 0 1 yugabyte=# \q wget 'http://127.0.0.1:13000/prometheus-metrics?reset_histograms=false&show_help=false' -O - 2>/dev/null | grep CatalogCacheMisses | grep count handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 12 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_0_pg_aggregate_fnoid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_1_pg_am_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_2_pg_am_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_3_pg_amop_opr_fam_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_4_pg_amop_fam_strat_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_5_pg_amproc_fam_proc_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_6_pg_attribute_relid_attnam_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_7_pg_attribute_relid_attnum_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_8_pg_auth_members_member_role_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_9_pg_auth_members_role_member_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_10_pg_authid_rolname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_11_pg_authid_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_12_pg_cast_source_target_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_13_pg_opclass_am_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_14_pg_opclass_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_15_pg_collation_name_enc_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_16_pg_collation_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_17_pg_conversion_default_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_18_pg_conversion_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_19_pg_constraint_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_20_pg_conversion_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_21_pg_database_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_22_pg_default_acl_role_nsp_obj_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 2 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_23_pg_enum_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_24_pg_enum_typid_label_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_25_pg_event_trigger_evtname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_26_pg_event_trigger_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_27_pg_foreign_data_wrapper_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_28_pg_foreign_data_wrapper_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_29_pg_foreign_server_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_30_pg_foreign_server_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_31_pg_foreign_table_relid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_32_pg_index_indexrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_33_pg_language_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_34_pg_language_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_35_pg_namespace_nspname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_36_pg_namespace_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_37_pg_operator_oprname_l_r_n_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_38_pg_operator_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_39_pg_opfamily_am_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_40_pg_opfamily_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_41_pg_partitioned_table_partrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_42_pg_proc_proname_args_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_43_pg_proc_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_44_pg_publication_pubname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_45_pg_publication_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_46_pg_publication_rel_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_47_pg_publication_rel_prrelid_prpubid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_48_pg_range_rngtypid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_49_pg_class_relname_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 4 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_50_pg_class_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_51_pg_replication_origin_roiident_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_52_pg_replication_origin_roname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_53_pg_rewrite_rel_rulename_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_54_pg_sequence_seqrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_55_pg_statistic_ext_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_56_pg_statistic_ext_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_57_pg_statistic_relid_att_inh_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_58_pg_subscription_subname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_59_pg_subscription_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_60_pg_subscription_rel_srrelid_srsubid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_61_pg_tablespace_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_62_pg_transform_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_63_pg_transform_type_lang_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_64_pg_ts_config_map_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_65_pg_ts_config_cfgname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_66_pg_ts_config_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_67_pg_ts_dict_dictname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_68_pg_ts_dict_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_69_pg_ts_parser_prsname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_70_pg_ts_parser_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_71_pg_ts_template_tmplname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_72_pg_ts_template_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_73_pg_type_typname_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 2 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_74_pg_type_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_75_pg_user_mapping_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_76_pg_user_mapping_user_server_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_77_pg_yb_tablegroup_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 ``` Reviewers: kfranz, smishra, mihnea Reviewed By: kfranz Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D35792
jasonyb
pushed a commit
that referenced
this issue
Jul 12, 2024
Summary: 9ca3158 [YNP] set the instanceName & nodeName during node registration with provider 1d2c37d [PLAT-14517] Add local provider test for create + delete db scoped DR replication. 2ff4f94 Fixes for 404 (#23180) 1f04b53 Early Access track (#23160) Excluded: 58b746e [#21516] YSQL: Destroy the control connection while reloading the postgres config file on it 55da508 [#23184] docdb: Add gflag to disable bootstrap intent filtering fae28ed YBM change log (#23186) b913931 [PLAT-12736] cleanup _index and universe.yaml Excluded: 968e831 [#22843] YSQL: Add YbNumCatalogCacheIdMisses to display PG catalog cache misses Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D36546
myang2021
added a commit
that referenced
this issue
Jul 13, 2024
…es to display PG catalog cache misses Summary: Original commit: 968e831 / D35792 ``` - Conflicts: - src/postgres/src/backend/utils/cache/syscache.c - at the initial part of the include section: pg15 commit 55782d5 removed two includes (moved to /* Yugabyte includes */) #include "access/genam.h" #include "access/heapam.h" master commit 968e831 added a new include #include <assert.h> - yb_cache_index_name_table: pg15 commit bea1ffb removed YbPinnedObjectKey, YbPinnedObjectsCacheData, YbPinnedObjectsCache pg15 inroduced 6 additional catcache entries, they need to be added into the yb_cache_index_name_table array in the right place that is maintained for Yugabyte: "pg_parameter_acl_parname_index", "pg_parameter_acl_oid_index", "pg_publication_namespace_oid_index", "pg_publication_namespace_pnnspid_pnpubid_index", "pg_range_rngmultitypid_index", "pg_statistic_ext_data_stxoid_inh_index", - src/postgres/src/include/utils/catcache.h - SetCatCacheTuple pg15 commit 55782d5 removed SetCatCacheTuple, SetCatCacheList, RelationHasCachedLists master commit 968e831 renamed GetCatCacheMisses to YbGetCatCacheMisses, added YbGetCatCacheIdMisses(); - src/postgres/src/include/utils/syscache.h - YbInitPinnedCacheIfNeeded pg15 commit bea1ffb removed YbInitPinnedCacheIfNeeded, YbIsObjectPinned, YbResetPinnedCache, YbPinObjectIfNeeded master commit 968e831 added YbCheckCatalogCacheIndexNameTable and YbGetCatalogCacheIndexName - src/postgres/yb-extensions/yb_pg_metrics/yb_pg_metrics.c Not a merge conflict, but pg15 inroduced 6 additional catcache entries (see above in src/postgres/src/backend/utils/cache/syscache.c), the following entries need to be added CatCacheMisses_79, CatCacheMisses_80, CatCacheMisses_81, CatCacheMisses_82, CatCacheMisses_83, CatCacheMisses_84, ``` YSQL provides a gflag `--ysql_catalog_preload_additional_table_list` that customers can use to preload a list of catalog tables to build a set of catalog caches. This can help to speed up the first query as it will see fewer cache misses. However it requires some manual work in order to figure out what to put in the list of catalog tables to preload. One way is to make a connection and execute `SET yb_debug_log_docdb_requests = true` then parse the postgres logs to see what catalog tables are being read in the read requests. We already have a counter `NumCatalogCacheMisses` that is exported to the PG webserver 13000 port. It is the number of accumulated cache misses that is recorded in the PG shared memory. Each time `SearchCatCacheMiss` is invoked, `NumCatalogCacheMisses` is incremented. At the end of the top-most query boundary, we compute the delta since last time and add it to the counter stored in shared memory. This counter can be accessed via the 13000 port. This diff expands the counter `NumCatalogCacheMisses` with `YbNumCatalogCacheIdMisses` which is an array of counters, one for each catalog cache, indexed by its id. In this way from the 13000 port we can see how many cache misses have happened for each catalog cache. If a catalog cache shows a large number of cache misses, it is an indication that its corresponding catalog table should be added to the list of catalog tables to preload. I also did some variable/function renames according to YB naming convention. Jira: DB-11741 Test Plan: (1) ./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.CatalogCacheIdMissMetricsTest (2) manual test ``` ./bin/yb-ctl create --rf 1 ./bin/ysqlsh ysqlsh (11.2-YB-2.23.0.0-b0) Type "help" for help. yugabyte=# create table foo(id int); CREATE TABLE yugabyte=# insert into foo values (10); INSERT 0 1 yugabyte=# \q wget 'http://127.0.0.1:13000/prometheus-metrics?reset_histograms=false&show_help=false' -O - 2>/dev/null | grep CatalogCacheMisses | grep count handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 12 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_0_pg_aggregate_fnoid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_1_pg_am_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_2_pg_am_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_3_pg_amop_opr_fam_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_4_pg_amop_fam_strat_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_5_pg_amproc_fam_proc_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_6_pg_attribute_relid_attnam_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_7_pg_attribute_relid_attnum_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_8_pg_auth_members_member_role_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_9_pg_auth_members_role_member_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_10_pg_authid_rolname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_11_pg_authid_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_12_pg_cast_source_target_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_13_pg_opclass_am_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_14_pg_opclass_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_15_pg_collation_name_enc_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_16_pg_collation_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_17_pg_conversion_default_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_18_pg_conversion_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_19_pg_constraint_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_20_pg_conversion_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_21_pg_database_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_22_pg_default_acl_role_nsp_obj_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 2 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_23_pg_enum_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_24_pg_enum_typid_label_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_25_pg_event_trigger_evtname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_26_pg_event_trigger_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_27_pg_foreign_data_wrapper_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_28_pg_foreign_data_wrapper_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_29_pg_foreign_server_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_30_pg_foreign_server_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_31_pg_foreign_table_relid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_32_pg_index_indexrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_33_pg_language_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_34_pg_language_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_35_pg_namespace_nspname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_36_pg_namespace_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_37_pg_operator_oprname_l_r_n_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_38_pg_operator_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_39_pg_opfamily_am_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_40_pg_opfamily_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_41_pg_partitioned_table_partrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_42_pg_proc_proname_args_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_43_pg_proc_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_44_pg_publication_pubname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_45_pg_publication_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_46_pg_publication_rel_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_47_pg_publication_rel_prrelid_prpubid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_48_pg_range_rngtypid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_49_pg_class_relname_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 4 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_50_pg_class_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_51_pg_replication_origin_roiident_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_52_pg_replication_origin_roname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_53_pg_rewrite_rel_rulename_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_54_pg_sequence_seqrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_55_pg_statistic_ext_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_56_pg_statistic_ext_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_57_pg_statistic_relid_att_inh_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_58_pg_subscription_subname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_59_pg_subscription_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_60_pg_subscription_rel_srrelid_srsubid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_61_pg_tablespace_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_62_pg_transform_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_63_pg_transform_type_lang_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_64_pg_ts_config_map_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_65_pg_ts_config_cfgname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_66_pg_ts_config_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_67_pg_ts_dict_dictname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_68_pg_ts_dict_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_69_pg_ts_parser_prsname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_70_pg_ts_parser_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_71_pg_ts_template_tmplname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_72_pg_ts_template_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_73_pg_type_typname_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 2 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_74_pg_type_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_75_pg_user_mapping_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_76_pg_user_mapping_user_server_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_77_pg_yb_tablegroup_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 ``` Reviewers: jason, tfoucher Reviewed By: jason Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D36548
myang2021
added a commit
that referenced
this issue
Jul 17, 2024
…lay PG catalog cache misses Summary: YSQL provides a gflag `--ysql_catalog_preload_additional_table_list` that customers can use to preload a list of catalog tables to build a set of catalog caches. This can help to speed up the first query as it will see fewer cache misses. However it requires some manual work in order to figure out what to put in the list of catalog tables to preload. One way is to make a connection and execute `SET yb_debug_log_docdb_requests = true` then parse the postgres logs to see what catalog tables are being read in the read requests. We already have a counter `NumCatalogCacheMisses` that is exported to the PG webserver 13000 port. It is the number of accumulated cache misses that is recorded in the PG shared memory. Each time `SearchCatCacheMiss` is invoked, `NumCatalogCacheMisses` is incremented. At the end of the top-most query boundary, we compute the delta since last time and add it to the counter stored in shared memory. This counter can be accessed via the 13000 port. This diff expands the counter `NumCatalogCacheMisses` with `YbNumCatalogCacheIdMisses` which is an array of counters, one for each catalog cache, indexed by its id. In this way from the 13000 port we can see how many cache misses have happened for each catalog cache. If a catalog cache shows a large number of cache misses, it is an indication that its corresponding catalog table should be added to the list of catalog tables to preload. I also did some variable/function renames according to YB naming convention. Jira: DB-11741 Original commit: 968e831 / D35792 Test Plan: (1) ./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.CatalogCacheIdMissMetricsTest (2) manual test ``` ./bin/yb-ctl create --rf 1 ./bin/ysqlsh ysqlsh (11.2-YB-2.23.0.0-b0) Type "help" for help. yugabyte=# create table foo(id int); CREATE TABLE yugabyte=# insert into foo values (10); INSERT 0 1 yugabyte=# \q wget 'http://127.0.0.1:13000/prometheus-metrics?reset_histograms=false&show_help=false' -O - 2>/dev/null | grep CatalogCacheMisses | grep count handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 12 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_0_pg_aggregate_fnoid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_1_pg_am_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_2_pg_am_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_3_pg_amop_opr_fam_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_4_pg_amop_fam_strat_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_5_pg_amproc_fam_proc_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_6_pg_attribute_relid_attnam_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_7_pg_attribute_relid_attnum_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_8_pg_auth_members_member_role_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_9_pg_auth_members_role_member_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_10_pg_authid_rolname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_11_pg_authid_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_12_pg_cast_source_target_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_13_pg_opclass_am_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_14_pg_opclass_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_15_pg_collation_name_enc_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_16_pg_collation_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_17_pg_conversion_default_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_18_pg_conversion_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_19_pg_constraint_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_20_pg_conversion_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_21_pg_database_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_22_pg_default_acl_role_nsp_obj_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 2 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_23_pg_enum_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_24_pg_enum_typid_label_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_25_pg_event_trigger_evtname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_26_pg_event_trigger_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_27_pg_foreign_data_wrapper_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_28_pg_foreign_data_wrapper_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_29_pg_foreign_server_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_30_pg_foreign_server_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_31_pg_foreign_table_relid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_32_pg_index_indexrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_33_pg_language_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_34_pg_language_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_35_pg_namespace_nspname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_36_pg_namespace_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_37_pg_operator_oprname_l_r_n_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_38_pg_operator_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_39_pg_opfamily_am_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_40_pg_opfamily_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_41_pg_partitioned_table_partrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_42_pg_proc_proname_args_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_43_pg_proc_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_44_pg_publication_pubname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_45_pg_publication_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_46_pg_publication_rel_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_47_pg_publication_rel_prrelid_prpubid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_48_pg_range_rngtypid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_49_pg_class_relname_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 4 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_50_pg_class_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_51_pg_replication_origin_roiident_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_52_pg_replication_origin_roname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_53_pg_rewrite_rel_rulename_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_54_pg_sequence_seqrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_55_pg_statistic_ext_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_56_pg_statistic_ext_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_57_pg_statistic_relid_att_inh_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_58_pg_subscription_subname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_59_pg_subscription_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_60_pg_subscription_rel_srrelid_srsubid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_61_pg_tablespace_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_62_pg_transform_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_63_pg_transform_type_lang_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_64_pg_ts_config_map_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_65_pg_ts_config_cfgname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_66_pg_ts_config_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_67_pg_ts_dict_dictname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_68_pg_ts_dict_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_69_pg_ts_parser_prsname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_70_pg_ts_parser_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_71_pg_ts_template_tmplname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_72_pg_ts_template_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_73_pg_type_typname_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 2 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_74_pg_type_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_75_pg_user_mapping_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_76_pg_user_mapping_user_server_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_77_pg_yb_tablegroup_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 ``` Reviewers: kfranz, smishra, mihnea Reviewed By: kfranz Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D36662
myang2021
added a commit
that referenced
this issue
Jul 19, 2024
…y PG catalog cache misses Summary: YSQL provides a gflag `--ysql_catalog_preload_additional_table_list` that customers can use to preload a list of catalog tables to build a set of catalog caches. This can help to speed up the first query as it will see fewer cache misses. However it requires some manual work in order to figure out what to put in the list of catalog tables to preload. One way is to make a connection and execute `SET yb_debug_log_docdb_requests = true` then parse the postgres logs to see what catalog tables are being read in the read requests. We already have a counter `NumCatalogCacheMisses` that is exported to the PG webserver 13000 port. It is the number of accumulated cache misses that is recorded in the PG shared memory. Each time `SearchCatCacheMiss` is invoked, `NumCatalogCacheMisses` is incremented. At the end of the top-most query boundary, we compute the delta since last time and add it to the counter stored in shared memory. This counter can be accessed via the 13000 port. This diff expands the counter `NumCatalogCacheMisses` with `YbNumCatalogCacheIdMisses` which is an array of counters, one for each catalog cache, indexed by its id. In this way from the 13000 port we can see how many cache misses have happened for each catalog cache. If a catalog cache shows a large number of cache misses, it is an indication that its corresponding catalog table should be added to the list of catalog tables to preload. I also did some variable/function renames according to YB naming convention. Jira: DB-11741 Original commit: 968e831 / D35792 NOTE: In 2.20, `pg_inherits_parent_index` was added as a catalog cache. This was removed by commit 25f5fb1. Because of this, CatCacheMisses_79 was added into enum statementType, and "pg_inherits_parent_index" was added into yb_cache_index_name_table. Test Plan: (1) ./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.CatalogCacheIdMissMetricsTest (2) manual test ``` ./bin/yb-ctl create --rf 1 ./bin/ysqlsh ysqlsh (11.2-YB-2.23.0.0-b0) Type "help" for help. yugabyte=# create table foo(id int); CREATE TABLE yugabyte=# insert into foo values (10); INSERT 0 1 yugabyte=# \q wget 'http://127.0.0.1:13000/prometheus-metrics?reset_histograms=false&show_help=false' -O - 2>/dev/null | grep CatalogCacheMisses | grep count handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 12 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_0_pg_aggregate_fnoid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_1_pg_am_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_2_pg_am_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_3_pg_amop_opr_fam_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_4_pg_amop_fam_strat_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_5_pg_amproc_fam_proc_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_6_pg_attribute_relid_attnam_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_7_pg_attribute_relid_attnum_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_8_pg_auth_members_member_role_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_9_pg_auth_members_role_member_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_10_pg_authid_rolname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_11_pg_authid_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_12_pg_cast_source_target_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_13_pg_opclass_am_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_14_pg_opclass_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_15_pg_collation_name_enc_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_16_pg_collation_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_17_pg_conversion_default_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_18_pg_conversion_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_19_pg_constraint_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_20_pg_conversion_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_21_pg_database_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_22_pg_default_acl_role_nsp_obj_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 2 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_23_pg_enum_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_24_pg_enum_typid_label_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_25_pg_event_trigger_evtname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_26_pg_event_trigger_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_27_pg_foreign_data_wrapper_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_28_pg_foreign_data_wrapper_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_29_pg_foreign_server_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_30_pg_foreign_server_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_31_pg_foreign_table_relid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_32_pg_index_indexrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_33_pg_language_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_34_pg_language_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_35_pg_namespace_nspname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_36_pg_namespace_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_37_pg_operator_oprname_l_r_n_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_38_pg_operator_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_39_pg_opfamily_am_name_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_40_pg_opfamily_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_41_pg_partitioned_table_partrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_42_pg_proc_proname_args_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_43_pg_proc_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_44_pg_publication_pubname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_45_pg_publication_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_46_pg_publication_rel_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_47_pg_publication_rel_prrelid_prpubid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_48_pg_range_rngtypid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_49_pg_class_relname_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 4 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_50_pg_class_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 1 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_51_pg_replication_origin_roiident_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_52_pg_replication_origin_roname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_53_pg_rewrite_rel_rulename_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_54_pg_sequence_seqrelid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_55_pg_statistic_ext_name_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_56_pg_statistic_ext_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_57_pg_statistic_relid_att_inh_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_58_pg_subscription_subname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_59_pg_subscription_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_60_pg_subscription_rel_srrelid_srsubid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_61_pg_tablespace_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_62_pg_transform_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_63_pg_transform_type_lang_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_64_pg_ts_config_map_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_65_pg_ts_config_cfgname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_66_pg_ts_config_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_67_pg_ts_dict_dictname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_68_pg_ts_dict_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_69_pg_ts_parser_prsname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_70_pg_ts_parser_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_71_pg_ts_template_tmplname_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_72_pg_ts_template_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_73_pg_type_typname_nsp_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 2 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_74_pg_type_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_75_pg_user_mapping_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_76_pg_user_mapping_user_server_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_77_pg_yb_tablegroup_oid_index_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 0 1719605588722 ``` Reviewers: kfranz, smishra, mihnea Reviewed By: kfranz Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D36674
myang2021
added a commit
that referenced
this issue
Aug 13, 2024
…a label
Summary:
Currently, we have a metric name for catalog cache miss such as:
```
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_24_pg_enum_typid_label_index_sum
```
To make it easier and more performant for YBA/YBM, this diff changes the name to
```
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses{table_name="pg_enum_typid_label_index_sum"}
```
Jira: DB-11741
Test Plan:
(1) ./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.CatalogCacheIdMissMetricsTest
(2) manual test
```
$ ./bin/yb-ctl create --rf 1
$ ./bin/ysqlsh
ysqlsh (11.2-YB-2.23.0.0-b0)
Type "help" for help.
yugabyte=# create table foo(id int);
CREATE TABLE
yugabyte=# insert into foo values (10);
INSERT 0 1
yugabyte=# \q
$ wget 'http://127.0.0.1:13000/prometheus-metrics?reset_histograms=false&show_help=false' -O - 2>/dev/null | grep CatalogCacheMisses | grep count
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 12 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_aggregate_fnoid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_am_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_am_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_amop_opr_fam_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_amop_fam_strat_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_amproc_fam_proc_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_attribute_relid_attnam_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_attribute_relid_attnum_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_auth_members_member_role_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_auth_members_role_member_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_authid_rolname_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_authid_oid_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_cast_source_target_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opclass_am_name_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opclass_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_collation_name_enc_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_collation_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_conversion_default_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_conversion_name_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_constraint_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_conversion_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_database_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_default_acl_role_nsp_obj_index",exported_instance="dev-server-myang:9000"} 2 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_enum_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_enum_typid_label_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_event_trigger_evtname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_event_trigger_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_data_wrapper_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_data_wrapper_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_server_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_server_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_table_relid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_index_indexrelid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_language_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_language_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_namespace_nspname_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_namespace_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_operator_oprname_l_r_n_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_operator_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opfamily_am_name_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opfamily_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_partitioned_table_partrelid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_proc_proname_args_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_proc_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_pubname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_rel_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_rel_prrelid_prpubid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_range_rngtypid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_class_relname_nsp_index",exported_instance="dev-server-myang:9000"} 4 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_class_oid_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_replication_origin_roiident_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_replication_origin_roname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_rewrite_rel_rulename_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_sequence_seqrelid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_statistic_ext_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_statistic_ext_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_statistic_relid_att_inh_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_subscription_subname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_subscription_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_subscription_rel_srrelid_srsubid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_tablespace_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_transform_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_transform_type_lang_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_config_map_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_config_cfgname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_config_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_dict_dictname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_dict_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_parser_prsname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_parser_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_template_tmplname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_template_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_type_typname_nsp_index",exported_instance="dev-server-myang:9000"} 2 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_type_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_user_mapping_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_user_mapping_user_server_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_yb_tablegroup_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_constraint_conrelid_contypid_conname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
Reviewers: kfranz, sanketh
Reviewed By: kfranz
Subscribers: yql
Differential Revision: https://phorge.dev.yugabyte.com/D37136
myang2021
added a commit
that referenced
this issue
Aug 13, 2024
…eus name to have a label
Summary:
Currently, we have a metric name for catalog cache miss such as:
```
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_24_pg_enum_typid_label_index_sum
```
To make it easier and more performant for YBA/YBM, this diff changes the name to
```
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses{table_name="pg_enum_typid_label_index_sum"}
```
Jira: DB-11741
Original commit: dc871f9 / D37136
Test Plan:
(1) ./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.CatalogCacheIdMissMetricsTest
(2) manual test
```
$ ./bin/yb-ctl create --rf 1
$ ./bin/ysqlsh
ysqlsh (11.2-YB-2.23.0.0-b0)
Type "help" for help.
yugabyte=# create table foo(id int);
CREATE TABLE
yugabyte=# insert into foo values (10);
INSERT 0 1
yugabyte=# \q
$ wget 'http://127.0.0.1:13000/prometheus-metrics?reset_histograms=false&show_help=false' -O - 2>/dev/null | grep CatalogCacheMisses | grep count
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 12 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_aggregate_fnoid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_am_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_am_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_amop_opr_fam_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_amop_fam_strat_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_amproc_fam_proc_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_attribute_relid_attnam_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_attribute_relid_attnum_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_auth_members_member_role_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_auth_members_role_member_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_authid_rolname_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_authid_oid_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_cast_source_target_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opclass_am_name_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opclass_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_collation_name_enc_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_collation_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_conversion_default_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_conversion_name_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_constraint_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_conversion_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_database_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_default_acl_role_nsp_obj_index",exported_instance="dev-server-myang:9000"} 2 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_enum_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_enum_typid_label_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_event_trigger_evtname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_event_trigger_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_data_wrapper_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_data_wrapper_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_server_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_server_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_table_relid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_index_indexrelid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_language_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_language_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_namespace_nspname_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_namespace_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_operator_oprname_l_r_n_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_operator_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opfamily_am_name_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opfamily_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_partitioned_table_partrelid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_proc_proname_args_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_proc_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_pubname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_rel_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_rel_prrelid_prpubid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_range_rngtypid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_class_relname_nsp_index",exported_instance="dev-server-myang:9000"} 4 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_class_oid_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_replication_origin_roiident_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_replication_origin_roname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_rewrite_rel_rulename_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_sequence_seqrelid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_statistic_ext_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_statistic_ext_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_statistic_relid_att_inh_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_subscription_subname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_subscription_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_subscription_rel_srrelid_srsubid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_tablespace_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_transform_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_transform_type_lang_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_config_map_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_config_cfgname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_config_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_dict_dictname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_dict_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_parser_prsname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_parser_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_template_tmplname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_template_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_type_typname_nsp_index",exported_instance="dev-server-myang:9000"} 2 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_type_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_user_mapping_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_user_mapping_user_server_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_yb_tablegroup_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_constraint_conrelid_contypid_conname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
Reviewers: kfranz, sanketh
Reviewed By: kfranz
Subscribers: yql
Tags: #jenkins-ready
Differential Revision: https://phorge.dev.yugabyte.com/D37277
myang2021
added a commit
that referenced
this issue
Aug 14, 2024
…es prometheus name to have a label
Summary:
```
- Conflicts:
- src/postgres/yb-extensions/yb_pg_metrics/yb_pg_metrics.c
pg15 commit 602cb2d had 6 additional catcache entries which are reflected as:
CatCacheMisses_79,
CatCacheMisses_80,
CatCacheMisses_81,
CatCacheMisses_82,
CatCacheMisses_83,
CatCacheMisses_84,
master commit dc871f9 renamed CatCacheMisses_xx to CatCacheIdMisses_xx
```
Currently, we have a metric name for catalog cache miss such as:
```
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_24_pg_enum_typid_label_index_sum
```
To make it easier and more performant for YBA/YBM, this diff changes the name to
```
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses{table_name="pg_enum_typid_label_index_sum"}
```
Jira: DB-11741
Original commit: dc871f9 / D37136
Test Plan:
(1) ./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.CatalogCacheIdMissMetricsTest
(2) manual test
```
$ ./bin/yb-ctl create --rf 1
$ ./bin/ysqlsh
ysqlsh (11.2-YB-2.23.0.0-b0)
Type "help" for help.
yugabyte=# create table foo(id int);
CREATE TABLE
yugabyte=# insert into foo values (10);
INSERT 0 1
yugabyte=# \q
$ wget 'http://127.0.0.1:13000/prometheus-metrics?reset_histograms=false&show_help=false' -O - 2>/dev/null | grep CatalogCacheMisses | grep count
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="dev-server-myang:9000"} 12 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_aggregate_fnoid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_am_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_am_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_amop_opr_fam_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_amop_fam_strat_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_amproc_fam_proc_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_attribute_relid_attnam_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_attribute_relid_attnum_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_auth_members_member_role_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_auth_members_role_member_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_authid_rolname_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_authid_oid_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_cast_source_target_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opclass_am_name_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opclass_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_collation_name_enc_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_collation_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_conversion_default_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_conversion_name_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_constraint_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_conversion_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_database_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_default_acl_role_nsp_obj_index",exported_instance="dev-server-myang:9000"} 2 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_enum_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_enum_typid_label_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_event_trigger_evtname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_event_trigger_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_data_wrapper_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_data_wrapper_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_server_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_server_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_foreign_table_relid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_index_indexrelid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_language_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_language_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_namespace_nspname_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_namespace_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_operator_oprname_l_r_n_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_operator_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opfamily_am_name_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_opfamily_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_partitioned_table_partrelid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_proc_proname_args_nsp_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_proc_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_pubname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_rel_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_publication_rel_prrelid_prpubid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_range_rngtypid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_class_relname_nsp_index",exported_instance="dev-server-myang:9000"} 4 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_class_oid_index",exported_instance="dev-server-myang:9000"} 1 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_replication_origin_roiident_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_replication_origin_roname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_rewrite_rel_rulename_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_sequence_seqrelid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_statistic_ext_name_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_statistic_ext_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_statistic_relid_att_inh_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_subscription_subname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_subscription_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_subscription_rel_srrelid_srsubid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_tablespace_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_transform_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_transform_type_lang_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_config_map_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_config_cfgname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_config_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_dict_dictname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_dict_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_parser_prsname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_parser_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_template_tmplname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_ts_template_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_type_typname_nsp_index",exported_instance="dev-server-myang:9000"} 2 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_type_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_user_mapping_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_user_mapping_user_server_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_yb_tablegroup_oid_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
handler_latency_yb_ysqlserver_SQLProcessor_CatalogCacheMisses_count{metric_id="yb.ysqlserver",metric_type="server",table_name="pg_constraint_conrelid_contypid_conname_index",exported_instance="dev-server-myang:9000"} 0 1723511498635
Reviewers: jason, tfoucher
Reviewed By: jason
Subscribers: yql
Tags: #jenkins-ready
Differential Revision: https://phorge.dev.yugabyte.com/D37321
jasonyb
pushed a commit
that referenced
this issue
Aug 15, 2024
Summary: adca727 [PLAT-14226][PLAT-14227] update login flow and RBAC logic to include group memberships 631592d [PLAT-14144]add retry policy for GcpProjectApiClient d1ac140 [#23418] docdb: Fix clone seq_no not being persisted Excluded: ade3a0e [#23461] YSQL: Fix memory corruption in UPDATE pushdown fd0c1e0 [PLAT-5874]: Expose state of db master "load balancing" process in Platform UI e6c2ee0 [#23459] YSQL: Fix asan YbAdminSnapshotScheduleTest.SysCatalogRetention failure 43261b7 [#23421] YSQL: Reset catalog read time after table prefetching dd123d4 [doc] CLI name tidyups (#23477) Excluded: dc871f9 [#22843] YSQL: Change the CatalogCacheMisses prometheus name to have a label 9d2b83a [doc][ybm] Slow query latency histogram (#23486) d50171b [PLAT-14900] Exclude empty string from regex validation for AZUoptional fields adf992d [#23237 ] DocDB: Master side DDL locking - Part 1/happy path 49039ec [PLAT-14620][YBA CLI] CLI gives invalid JSON output db993c6 [#23140] docdb: Clear table txn verifier state after drop 0b93c5d [PLAT-14925] Should not allow turning off DB audit logging runtime config if enabled on a universe d0500a0 [#22989] YSQL: Fix regular expression pushdown 6a4f23b [#23353] CDCSDK: Send null old tuples for updates without before image Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D37309
iSignal
added a commit
that referenced
this issue
Sep 6, 2024
Summary: This metric was added as part of #22843. It will now be shown in the YSQL section, both regular and outlier table view. The exact query looks like ``` sum(rate(rpc_latency_count{export_type="ysql_export", service_type="SQLProcessor", node_prefix="yb-admin-sanketh-aws-test-1", table_name=~"..*", server_type="yb_ysqlserver", service_method="CatalogCacheMisses"}[36s])) ``` Non-empty table name filter is needed because the metric is exported both at per-server & per-table level. Test Plan: Load metrics dashboard, sanity check.{F282343} {F282344} Reviewers: amalyshev, kfranz, myang, rmadhavan Reviewed By: amalyshev, rmadhavan Subscribers: yugaware Differential Revision: https://phorge.dev.yugabyte.com/D37791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-11741
Description
YSQL provides a gflag
--ysql_catalog_preload_additional_table_listthat customercan use to preload a list of catalog tables to build a set of catalog caches.
This can help to speed up the first query as it will see fewer cache misses.
However it requires some manual work in order to figure out what to put in the
list of catalog tables to preload. One way is to make a connection and execute
SET yb_debug_log_docdb_requests = truethen parse the postgres logs to seewhat catalog tables are being read in the read requests.
We already have a counter
NumCatalogCacheMissesthat is exported to the PGwebserver 13000 port. It is the number of accumulated cache misses that is
recorded in the PG shared memory. Each time
SearchCatCacheMissis invoked,NumCatalogCacheMissesis incremented. At the end of the top-most queryboundary, we compute the delta since last time and add it to the counter stored
in shared memory. This counter can be accessed via the 13000 port.
We can have an array of counters, one for each catalog cache in order to show catalog
cache misses for each catalog cache. In this way we can find out which catalog cache
has many cache misses and include its catalog table in the list to preload.
Issue Type
kind/enhancement
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: