Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Add gflag to toggle use of intent hybrid time filter during bootstrap #23184

Closed
1 task done
es1024 opened this issue Jul 11, 2024 · 0 comments
Closed
1 task done
Assignees
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@es1024
Copy link
Contributor

es1024 commented Jul 11, 2024

Jira Link: DB-12127

Description

The intent hybrid time file filter added to the bootstrap code path in 8b23a4e currently has no gflag to disable it, and also may cause data corruption on restart. It should be gated behind a gflag.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@es1024 es1024 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Jul 11, 2024
@es1024 es1024 self-assigned this Jul 11, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jul 11, 2024
es1024 added a commit that referenced this issue Jul 11, 2024
Summary:
Add a gflag (use_bootstrap_intent_ht_filter, default off) to disable filtering intents during bootstrap by min running hybrid time
which was added in D35639 / 8b23a4e.

This gflag is default off to disable the feature for now, as it leads to data corruption in some cases on restart due to the
loaded min running hybrid time being too recent.
Jira: DB-12127

Test Plan: Jenkins

Reviewers: yyan, qhu

Reviewed By: yyan

Subscribers: ybase, rthallam

Differential Revision: https://phorge.dev.yugabyte.com/D36515
jasonyb pushed a commit that referenced this issue Jul 12, 2024
Summary:
 9ca3158 [YNP] set the instanceName & nodeName during node registration with provider
 1d2c37d [PLAT-14517] Add local provider test for create + delete db scoped DR replication.
 2ff4f94 Fixes for 404 (#23180)
 1f04b53 Early Access track (#23160)
 Excluded: 58b746e [#21516] YSQL: Destroy the control connection while reloading the postgres config file on it
 55da508 [#23184] docdb: Add gflag to disable bootstrap intent filtering
 fae28ed YBM change log (#23186)
 b913931 [PLAT-12736] cleanup _index and universe.yaml
 Excluded: 968e831 [#22843] YSQL: Add YbNumCatalogCacheIdMisses to display PG catalog cache misses

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36546
@rthallamko3 rthallamko3 removed the status/awaiting-triage Issue awaiting triage label Sep 11, 2024
@es1024 es1024 closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants