-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add extraManifest #121
Conversation
Signed-off-by: Simon LEONARD <[email protected]>
Thanks for this contribution! I will test it! |
Hi @sinux-l5d! Thanks for your contribution. I will review your PR. Hi @fibbs! The goal of this PR is to add a new "feature" to the chart, it is not a hotfix. I agree with 6.1.0. But the publishing of the helm chart is associated with the manually created tag. Using this approach, I can accumulate many PRs and publish all the changes together. That is why I did not add helm docs to the pipeline to avoid conflicts. I had a lot of problems with this last year. So, during the process of publishing a new release, I evaluate all the changes from the PRs that I will publish, choose the appropriate version number and then publish them in one package... The explanation for this is that last year I was very busy at work, so several PRs accumulated throughout the year and I published them all in one batch release. Another reason is that some people who opened the PR were not responding quickly when I had free time (which is normal because everyone's schedule is asynchronous even depending on their interest and free time). |
04c7be7
to
de95e67
Compare
It should be okay now @aeciopires :) EDIT: let me know if you need me to squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sinux-l5d!
It`s ok to me!
@fibbs I will let merge with you to solved possible conflict in code with other PRs
What this PR does / why we need it:
This PR adds a extraManifest key. It allows arbitrary deployment of a Kubernetes manifest within the same Helm release.
In our case, we deploy an extra Secret that uses helm-secrets.
Which issue this PR fixes
Special notes for your reviewer:
We've discussed in the issue above about "add[ing] and test[ing] all occurrences of extra parameters like extraEnv". However I don't see the connection between extraEnv and extraManifest: the latter should be added as-is in the release, without modification from other extra parameters.
Checklist