Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resources to dbCreateUpgradeJob #125

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

angelnu
Copy link
Contributor

@angelnu angelnu commented Nov 24, 2024

What this PR does / why we need it:

Allows deploying helm chart in namespaces with quotas where all containers need to have resource limits.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes NA

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@angelnu angelnu requested a review from aeciopires as a code owner November 24, 2024 21:54
Copy link
Member

@aeciopires aeciopires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributition @angelnu!

Hi @fibbs!

Can you review this PR, merge and run local tests and solve possible conflicts with your PR #123 and #121 because changes in values.yaml file?

@aeciopires aeciopires requested a review from fibbs November 25, 2024 10:19
@fibbs fibbs merged commit 1a7227e into zabbix-community:master Nov 26, 2024
1 check passed
@aeciopires aeciopires added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants