feature: limit concurrency #2675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandor Szücs <[email protected]>
Comment on lines
+1487
to
+1491
| if sbf, ok := ctx.StateBag()[filters.LimitConcurrency]; ok { | ||
| if f, ok := sbf.(func()); ok { | ||
| defer f() | ||
| } | ||
| } |
There was a problem hiding this comment.
Why do we need to defer it here instead of just decrementing on Response (or in HandleErrorResponse)?
There was a problem hiding this comment.
Because if the backend is fully asynchronous we need to decrement after copystream (after the full body was sent to client )
| type ( | ||
| limitConcurrencySpec struct{} | ||
| limitConcurrencyFilter struct { | ||
| concurrentRequests *atomic.Int64 |
There was a problem hiding this comment.
There is no need to use pointer here
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if cc < 1 { |
There was a problem hiding this comment.
I think we can allow zero for completeness here.
| // | ||
| // - 503 if full | ||
| func (f *limitConcurrencyFilter) Request(ctx filters.FilterContext) { | ||
| if f.maxConcurrency > f.concurrentRequests.Load() { |
There was a problem hiding this comment.
This condition looks wrong
There was a problem hiding this comment.
I think this https://pkg.go.dev/golang.org/x/sync/semaphore#Weighted.TryAcquire might be more suitable here.
|
close this in favor of #2685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.