feature: filter fifoWithBody #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuecs
force-pushed
the
feature/fifo-with-body
branch
2 times, most recently
from
a3c852e to
6601175
Compare
szuecs
force-pushed
the
feature/fifo-with-body
branch
from
6601175 to
4028656
Compare
…e defered until body streaming to client was finished Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
Both filters did not check for canceled context from request before semaphore.Acquire, see golang/go#63615 Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
szuecs
force-pushed
the
feature/fifo-with-body
branch
from
f895baa to
c7bedd1
Compare
|
👍 |
1 similar comment
|
👍 |
szuecs
added a commit
that referenced
this pull request
Nov 7, 2023
* feature: filter fifoWithBody that works similar to fifo(), but release deferred until body streaming to client was finished * fix: fifo() and fifoWithBody() with canceled requests Both filters did not check for canceled context from request before semaphore.Acquire, see golang/go#63615 Signed-off-by: Sandor Szücs <[email protected]>
RomanZavodskikh
pushed a commit
that referenced
this pull request
Nov 27, 2023
* feature: filter fifoWithBody that works similar to fifo(), but release deferred until body streaming to client was finished * fix: fifo() and fifoWithBody() with canceled requests Both filters did not check for canceled context from request before semaphore.Acquire, see golang/go#63615 Signed-off-by: Sandor Szücs <[email protected]>
AlexanderYastrebov
pushed a commit
that referenced
this pull request
Nov 27, 2023
* feature: filter fifoWithBody that works similar to fifo(), but release deferred until body streaming to client was finished * fix: fifo() and fifoWithBody() with canceled requests Both filters did not check for canceled context from request before semaphore.Acquire, see golang/go#63615 Signed-off-by: Sandor Szücs <[email protected]>
AlexanderYastrebov
pushed a commit
that referenced
this pull request
Nov 27, 2023
* feature: filter fifoWithBody that works similar to fifo(), but release deferred until body streaming to client was finished * fix: fifo() and fifoWithBody() with canceled requests Both filters did not check for canceled context from request before semaphore.Acquire, see golang/go#63615 Signed-off-by: Sandor Szücs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: filter fifoWithBody that works similar to fifo(), but release deferred until body streaming to client was finished
fix: #2579
fix: we did not check context canceled before, see also golang/go#63615