-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding additional details for debugging about registry pushes #1558
Adding additional details for debugging about registry pushes #1558
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, and thanks for the PR! Requesting this line be added as well since it won't destroy the messages when the spinner completes (if it completes).
Also do you have any log snippets from when you saw the infinite spin with this in place? (was testing locally over this past weekend and while I could significantly slow the Zarf install I never saw it actually infinite spin myself yet).
I don't have any logs that I can share, but I can work toward that once this feature is released. Essentially it's not necessarily an infinite spin, but images seem to not push consistently. Sometimes the entire deployment will hang on pushing a small image like |
d9c925d
to
a8df5be
Compare
Thanks, that is good to know - I was able to see the retry behavior happen in my tests by intentionally killing the connection to trigger them manually (by deleting or otherwise manipulating the registry pod) - what is odd is that is the opposite of what was reported by @corang (and others) #1218 (comment) - more logs will definitely help since this is likely shaping up to be a multi-faceted issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I started a new ticket to track my findings #1568. |
Description
This enables some additional logging information for pushes to registries.
Related Issue
Relates to #1218
Type of change
Checklist before merging