Linux/x11 input handling #7811
Merged
Linux/x11 input handling #7811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
I can confirm this PR works under XWayland on kde 6.0-rc2. Forcing it to use x11 (with the Just wanted to note the results of my testing it's behavior. Great work! |
Comment on lines
+160
to
+164
| | x::EventMask::BUTTON1_MOTION | ||
| | x::EventMask::BUTTON2_MOTION | ||
| | x::EventMask::BUTTON3_MOTION | ||
| | x::EventMask::BUTTON4_MOTION | ||
| | x::EventMask::BUTTON5_MOTION |
There was a problem hiding this comment.
I may be uneducated, but what are these button1-5? If this is not commonplace knowledge maybe comments should be added to describe what each maps to
There was a problem hiding this comment.
Mouse pointer motion while mouse button 1-5 is down.
mikayla-maki
force-pushed
the
x11-input
branch
from
835e65d to
9a82cf3
Compare
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the basics of keyboard and mouse handling.
Some keys will need special treatment, like Backspace/Delete. In this PR, all keys are treated as append-only. Leaving this for a follow-up.
I used @gabydd 's branch as a reference (thank you!) as well as https://github.com/xkbcommon/libxkbcommon/blob/master/doc/quick-guide.md
For future work, I'll also use https://github.com/xkbcommon/libxkbcommon/blob/master/tools/interactive-x11.c
All commits are separately compileable and reviewable.
Release Notes: