This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
PSR-15 support (http-interop/http-server-middleware) #39
Closed
michalbundyra
wants to merge
12
commits into
zendframework:release-1.0.0
from
michalbundyra:feature/psr-15
Closed
PSR-15 support (http-interop/http-server-middleware) #39
michalbundyra
wants to merge
12
commits into
zendframework:release-1.0.0
from
michalbundyra:feature/psr-15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dropped PHP 5.6 and 7.0 - updated Travis CI config
14 tasks
The tool updates interop middlewares and delegators to be compatible with http-interop/http-server-middleware It updates namespaces and name of interfaces (keeps aliases), change method name from "delegate" to "handle" on handlers and adds return type on methods "process" and "handle".
Compare output from the converter with expected files contents
- zend-stratiglity ^3.0.0-dev - zend-expressive-router ^3.0.0-dev - phpunit <6.5 because 6.5+ it's not working with php-mock
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2017
Thanks, @webimpress! |
Rebased and pushed against release-1.0.0 branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Added new tool:
migrate:interop-middleware
which will look for old http-interop/http-middleware style middlewares and delegators and update them to http-interop/http-server-middleware:Interop\Http\ServerMiddleware\MiddlewareInterface
->Interop\Http\Server\MiddlewareInterface
Interop\Http\ServerMiddleware\DelegateInterface
->Interop\Http\Server\RequestHandlerInterface
process
->handle
,process
calls on delegator tohandle
(in middlewares),process
(in middleware) andhandle
(in request handler):\Psr\Http\Message\ResponseInterface
.Fixed
migrate:original-messages
tests - asserting expected files contents with output from converter