PSR-15 support (http-interop/http-server-middleware) + PHP 7.1 #529

michalbundyra · 2017-11-20T08:23:28Z

dropped PHP 5.6 and 7.0
updated Travis CI configuration

Requires:

We need update the docs, and remove probably some functionality like double-pass middlewares.

- dropped PHP 5.6 and 7.0 - updated Travis CI configuration

asgrim · 2017-11-21T11:40:33Z

Probably worth linking to the discussion on this for anyone researching: https://discourse.zendframework.com/t/psr-15-compatibility-issues-and-proposal/378

"responsePrototype" has been removed in MiddlewarePipe so it has been added here to Application as provate property and Application has one more not mandatory parameter in costructor Default, as before, response prototype is initialized with Zend\Diactoros\Response New wrappers (decorators) are used.

Added return type declaration on "pipe" method of Application. We return $this, but parrent method has "self" return type declared. Here we have to use "parent" and in PHPDocs we can point that it is "self".

weierophinney · 2017-12-05T17:02:16Z

composer.json

        "zendframework/zend-diactoros": "^1.3.10",
-        "zendframework/zend-expressive-router": "^2.2",
+        "zendframework/zend-expressive-router": "dev-feature/psr-15 as 2.2",


You can now pin this to 3.0.x-dev or dev-release-3.0.0.

Unfortunately for now we need to have 3.0.x-dev as 2.3 as expressive-*router libraries does not support v3 yet. I'm going to work on it soon.

weierophinney · 2017-12-05T17:02:26Z

composer.json

+            "type": "git",
+            "url": "https://github.com/webimpress/zend-expressive-router.git"
+        }
+    ],


You can remove this now.

weierophinney · 2017-12-05T17:04:38Z

composer.json

        "zendframework/zend-expressive-template": "^1.0.4",
-        "zendframework/zend-stratigility": "^2.1"
+        "zendframework/zend-stratigility": "dev-release-3.0.0"


Maybe try one of the following constraints:

^3.0.0@dev

^3.0.0@dev as 3.0.0alpha1

^3.0.0-dev

^3.0.0-dev as 3.0.0alpha1

My understanding is that we should use semver constraints instead of the branch name if an alias exists; I just can't recall off the top of my head what that should look like. Experiment! 😁

Looks like ^3.0.0@dev and ^3.0.0-dev are the same, when I try with alias I got error:

Problem 1
- The requested package zendframework/zend-stratigility ^3.0.0@dev as 3.0.0alpha1 exists as zendframework/zend-stratigility[1.0.0, 1.0.1, 1.0.2, 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.2.0, 1.2.1, 1.3.0, 1.3.1, 1.3.2, 1.3.3, 2.0.0, 2.0.1, 2.1.0, 2.1.1, 2.1.2, dev-develop, 2.2.x-dev, dev-master, 2.1.x-dev, dev-release-3.0.0, 3.0.x-dev] but these are rejected by your constraint.

We don't need to have Exception and Throwable as we support only PHP 7.1+ Added typehint for Throwable

michalbundyra · 2017-12-07T13:12:07Z

@weierophinney because we decided to typehint on MiddlewareInterface in Route we have to load all middlewares (also routed) on application start. Before routed middlewares were loaded only when the path was hit, and it was right, IMO. Do you have any suggestion what we can do or we should just revert change in zend-expressive-router?

Other that than we have some issues in test caused by bug in prophecy, please see:
phpspec/prophecy#368
I've already provided fix there (phpspec/prophecy#377) but not sure when we have it released.

weierophinney · 2017-12-07T14:46:48Z

@weierophinney because we decided to typehint on MiddlewareInterface in Route we have to load all middlewares (also routed) on application start. Before routed middlewares were loaded only when the path was hit, and it was right, IMO. Do you have any suggestion what we can do or we should just revert change in zend-expressive-router?

This is not true. In the v2 series, route() will create a LazyLoadingMiddleware instance when a middleware service name is provided, and inject that into the Route instance created.

Currently, the only way the middleware passed to a Route instance will NOT be a MiddlewareInterface is if the Route is created manually by the user.

We are waiting for release, this is to have less tests failing...

Now zend-expressive-router RouteResult::fromRouteFailure() requires parameter. It resolves prophecy issue and it's more clear because we have to provide parameter explicitly

- Removed default value from $middleware - added type hint on $name to string - fixed doc-block

Because we have typehints we are expecting now TypeError. We have it got in all these cases because we declare strict_types.

$middleware can't be now omitted, in case we pas null we got InvalidMiddlewareException

…ce instances

weierophinney · 2017-12-11T22:00:56Z

@webimpress Do not worry about rebasing; I've almost completed the merge locally, and will push to release-3.0.0 shortly.

PSR-15 support (http-interop/http-server-middleware) + PHP 7.1 Conflicts: .travis.yml composer.json composer.lock docs/book/cookbook/passing-data-between-middleware.md docs/book/cookbook/setting-locale-without-routing-parameter.md docs/book/cookbook/using-routed-middleware-class-as-controller.md docs/book/features/middleware-types.md docs/book/getting-started/skeleton.md src/Application.php src/Delegate/NotFoundDelegate.php src/MarshalMiddlewareTrait.php src/Middleware/DispatchMiddleware.php src/Middleware/ImplicitHeadMiddleware.php src/Middleware/ImplicitOptionsMiddleware.php src/Middleware/LazyLoadingMiddleware.php src/Middleware/NotFoundHandler.php src/Middleware/RouteMiddleware.php test/Application/MarshalMiddlewareTraitTest.php test/Application/TestAsset/CallableInteropMiddleware.php test/Application/TestAsset/InteropMiddleware.php test/ApplicationTest.php test/Container/ApplicationFactoryTest.php test/IntegrationTest.php test/Middleware/DispatchMiddlewareTest.php test/Middleware/ImplicitHeadMiddlewareTest.php test/Middleware/ImplicitOptionsMiddlewareTest.php test/Middleware/LazyLoadingMiddlewareTest.php test/Middleware/NotFoundHandlerTest.php test/Middleware/RouteMiddlewareTest.php test/Router/IntegrationTest.php test/TestAsset/CallableInteropMiddleware.php test/TestAsset/InteropMiddleware.php

Close #529

weierophinney · 2017-12-11T22:16:17Z

Thanks, @webimpress!

PSR-15 support (http-interop/http-server-middleware)

1bf07dd

- dropped PHP 5.6 and 7.0 - updated Travis CI configuration

This was referenced Nov 20, 2017

PSR-15 progress tracker in Expressive modules #528

Closed

PSR-15 support (http-interop/http-server-middleware) zendframework/zend-expressive-tooling#39

Closed

Updated Expressive documentation (PSR-15, Expressive 3.0)

2451301

michalbundyra mentioned this pull request Nov 28, 2017

Updated webimpress/http-middleware-compatibility to 0.1.4 #523

Closed

michalbundyra changed the base branch from develop to release-3.0.0 November 28, 2017 22:53

michalbundyra mentioned this pull request Nov 30, 2017

Expressive 3.0.0alpha1 - PHP 7.1 updates #530

Closed

michalbundyra added 2 commits December 5, 2017 09:56

Updated to the latest release-3.0.0 stratigility

d34af22

Added return type declaration on "pipe" method of Application. We return $this, but parrent method has "self" return type declared. Here we have to use "parent" and in PHPDocs we can point that it is "self".

weierophinney added this to the 3.0.0alpha1 milestone Dec 5, 2017

weierophinney suggested changes Dec 5, 2017

View reviewed changes

michalbundyra added 7 commits December 5, 2017 18:03

Updated composer dependencies: stratigility and expressive-router

d2fa057

Updated composer - all dependencies to ^3.0.0-dev

c94f79e

Updated header doclicense URLs to https

5140f8f

Added declare strict types

275c75d

Use Throwable only

3d35462

We don't need to have Exception and Throwable as we support only PHP 7.1+ Added typehint for Throwable

Changed to multi exception catch

31775db

Null coalescing operator

de4f873

michalbundyra added 9 commits December 7, 2017 16:48

Updated to phpspec/prophecy with hotfix

e3f1092

We are waiting for release, this is to have less tests failing...

Wrapping config-based routing middlewares if needed

6778135

Updated 3.0.0-dev dependencies

51cbf29

Now zend-expressive-router RouteResult::fromRouteFailure() requires parameter. It resolves prophecy issue and it's more clear because we have to provide parameter explicitly

Updated route method of Application

c80058d

- Removed default value from $middleware - added type hint on $name to string - fixed doc-block

Updated test: strict types and TypeError exception

352f074

Because we have typehints we are expecting now TypeError. We have it got in all these cases because we declare strict_types.

Test fix: route requires two params

e977db8

$middleware can't be now omitted, in case we pas null we got InvalidMiddlewareException

Updated integration test - failing on expressive-zendrouter

aff24e0

Updated composer dependencies - routers

eaf145e

Added one more assertion to conform behavior all route bridges

a631748

michalbundyra added 2 commits December 7, 2017 22:14

Removed no longer needed tests - Route accepts only MiddlewareInterfa…

669b76f

…ce instances

Tests fixes

16bb652

weierophinney mentioned this pull request Dec 11, 2017

Added support for http-interop/http-middleware 0.5.0 (no BC Break) #517

Merged

weierophinney merged commit 16bb652 into zendframework:release-3.0.0 Dec 11, 2017

weierophinney added a commit that referenced this pull request Dec 11, 2017

Adds CHANGELOG entries for #529

a7df5e4

weierophinney added a commit that referenced this pull request Dec 11, 2017

Merge branch 'feature/529-psr-15' into release-3.0.0

4108369

Close #529

michalbundyra deleted the feature/psr-15 branch December 11, 2017 22:50

Rockstar04 mentioned this pull request Mar 22, 2018

Add Zend Expressive 3.0 deprecated-packages/gophp71.org#27

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PSR-15 support (http-interop/http-server-middleware) + PHP 7.1 #529

PSR-15 support (http-interop/http-server-middleware) + PHP 7.1 #529

michalbundyra commented Nov 20, 2017 •

edited

Loading

asgrim commented Nov 21, 2017

weierophinney Dec 5, 2017

michalbundyra Dec 5, 2017

weierophinney Dec 5, 2017

michalbundyra Dec 5, 2017

weierophinney Dec 5, 2017

michalbundyra Dec 5, 2017

michalbundyra commented Dec 7, 2017

weierophinney commented Dec 7, 2017

weierophinney commented Dec 11, 2017

weierophinney commented Dec 11, 2017

PSR-15 support (http-interop/http-server-middleware) + PHP 7.1 #529

PSR-15 support (http-interop/http-server-middleware) + PHP 7.1 #529

Conversation

michalbundyra commented Nov 20, 2017 • edited Loading

asgrim commented Nov 21, 2017

weierophinney Dec 5, 2017

Choose a reason for hiding this comment

michalbundyra Dec 5, 2017

Choose a reason for hiding this comment

weierophinney Dec 5, 2017

Choose a reason for hiding this comment

michalbundyra Dec 5, 2017

Choose a reason for hiding this comment

weierophinney Dec 5, 2017

Choose a reason for hiding this comment

michalbundyra Dec 5, 2017

Choose a reason for hiding this comment

michalbundyra commented Dec 7, 2017

weierophinney commented Dec 7, 2017

weierophinney commented Dec 11, 2017

weierophinney commented Dec 11, 2017

michalbundyra commented Nov 20, 2017 •

edited

Loading