Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPS 292] Add labels to the resulting images #23

Merged
merged 16 commits into from
Feb 4, 2025
Merged

Conversation

alourie
Copy link
Contributor

@alourie alourie commented Dec 16, 2024

Description

Some rework of the pipeline creation:

  • Variables are renamed to make their purpose clear - especially the container tags vs container labels.
  • Unnecessary payload values used in dispatching the pipeline-java-ewb build are removed.
  • Made the dispatching of the pipeline-java-ewb container optional predicated on selecting a checkbox.

Associated tasks

Test Steps

I've built containers from this branch manually to test they actually build, and labelled correctly.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
    - [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
    - [ ] I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members if so.

Not a breaking change.

Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
@ryanjcoleman
Copy link
Member

Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
@alourie alourie requested a review from charlta January 22, 2025 06:21
@alourie
Copy link
Contributor Author

alourie commented Jan 22, 2025

I'd like to get these things merged so we can move on with our [hopefully better] lives.
This is the first step to improve the superpom-based-cache pipeline container image.

@alourie alourie marked this pull request as ready for review January 22, 2025 06:34
@alourie alourie requested a review from kgreav January 22, 2025 06:34
Copy link
Member

@charlta charlta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have no ability to check if this actually works

@alourie alourie merged commit fcc4797 into main Feb 4, 2025
5 checks passed
@alourie alourie deleted the OPS-292-add-labels branch February 4, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants