Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPS 293] multiversion maven repo #53

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

alourie
Copy link
Contributor

@alourie alourie commented Dec 16, 2024

Description

We've been building a pipeline container with superpom dependencies as a local Maven repo, which theoretically improves build times for the dependent projects. However, many projects are not up to date with the latest superpom, resulting in a dependency chain with a number of different superpom version, and hence "cache misses" for the packages.

This change will layer the dependencies from multiple superpom releases in the same local Maven repository, which should result in less cases of dependent packages missing during the following Maven builds.

Associated tasks

DO NOT MERGE UNTIL the following is merged a new pipeline-java is built:

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
    - [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members if so.

This is not a breaking change, and should automagically work with all other workflows.

@ryanjcoleman
Copy link
Member

.github/workflows/build-container.yml Show resolved Hide resolved
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
.github/workflows/build-container.yml Show resolved Hide resolved
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
for-ci-build-image/build-container.pkr.hcl Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
.github/workflows/build-container.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@alourie alourie marked this pull request as ready for review January 22, 2025 06:27
@alourie
Copy link
Contributor Author

alourie commented Jan 22, 2025

I believe this is ready for an additional review and hopefully a merge.

Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
skip-ci

Signed-off-by: Alex Lourie <[email protected]>
@alourie alourie force-pushed the OPS-293-multiversion-maven-repo branch from 6183cc3 to d07f1b4 Compare January 22, 2025 12:40
@alourie alourie requested a review from charlta January 22, 2025 22:52
Copy link
Member

@charlta charlta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With no way to manually/locally confirm this is working, it will be a matter of merge it and fix anything that goes wrong.

At time of approval the associated task was not been merged, and no new pipeline-java has been built, so make sure that happens before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants