-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPS 293] multiversion maven repo #53
base: main
Are you sure you want to change the base?
Conversation
I believe this is ready for an additional review and hopefully a merge. |
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
Signed-off-by: Alex Lourie <[email protected]>
skip-ci Signed-off-by: Alex Lourie <[email protected]>
6183cc3
to
d07f1b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With no way to manually/locally confirm this is working, it will be a matter of merge it and fix anything that goes wrong.
At time of approval the associated task was not been merged, and no new pipeline-java
has been built, so make sure that happens before merging.
Description
We've been building a pipeline container with superpom dependencies as a local Maven repo, which theoretically improves build times for the dependent projects. However, many projects are not up to date with the latest superpom, resulting in a dependency chain with a number of different superpom version, and hence "cache misses" for the packages.
This change will layer the dependencies from multiple superpom releases in the same local Maven repository, which should result in less cases of dependent packages missing during the following Maven builds.
Associated tasks
DO NOT MERGE UNTIL the following is merged a new
pipeline-java
is built:Checklist
If any of these are not applicable, strikethrough the line
~like this~
. Do not delete it!. Let the reviewer decide if you should have done it.Code
- [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.Documentation
Breaking Changes
This is not a breaking change, and should automagically work with all other workflows.