-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-1741] HCM interventions data model change #120
Conversation
Task linked: DEV-1741 Update evolve-grpc |
I updated the name of the PR and the description to be more useful than "data model change". I didn't change the branch name (which I should have) as it will close the PR |
Added ewb-core as reviewers as it shouldn't have been sent straight to me. |
Thanks for that. Also I wasn't sure who could review this so I did just straight put your name against it for review. I'll put ewb-core for the rest of the other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have barely looked at the PR and found some very sloppy mistakes.
Given this and the lazy nature of the PR name and description I feel this requires a more thorough self review before I look at it any further.
proto/zepben/protobuf/cim/extensions/iec61968/metering/PanDemandResponseFunction.proto
Outdated
Show resolved
Hide resolved
proto/zepben/protobuf/cim/extensions/iec61968/metering/PanDemandResponseFunction.proto
Outdated
Show resolved
Hide resolved
proto/zepben/protobuf/cim/extensions/iec61968/metering/PanDemandResponseFunction.proto
Outdated
Show resolved
Hide resolved
proto/zepben/protobuf/cim/extensions/iec61970/base/wires/BatteryControlMode.proto
Outdated
Show resolved
Hide resolved
proto/zepben/protobuf/cim/extensions/iec61970/base/wires/BatteryControlMode.proto
Outdated
Show resolved
Hide resolved
proto/zepben/protobuf/cim/extensions/iec61970/base/wires/BatteryControl.proto
Outdated
Show resolved
Hide resolved
proto/zepben/protobuf/cim/extensions/iec61968/metering/PanDemandResponseFunction.proto
Outdated
Show resolved
Hide resolved
spec/ewb/extensions/IEC61968/Metering/PanDemandResponseFunction.yaml
Outdated
Show resolved
Hide resolved
9ec9573
to
fba78df
Compare
ae04d07
to
a7603b8
Compare
44ba96e
to
981e0cd
Compare
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Marcus Koh <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Jimmy Tung <[email protected]>
Signed-off-by: Kurt Greaves <[email protected]>
Signed-off-by: Kurt Greaves <[email protected]>
Signed-off-by: Anthony Charlton <[email protected]>
Signed-off-by: Anthony Charlton <[email protected]>
981e0cd
to
8dac171
Compare
Signed-off-by: Anthony Charlton <[email protected]>
Description
Added the following messages/classes/types:
StaticVarCompensator
SVCControlMode
EndDeviceFunction
PanDemandResponseFunction
ControlledAppliance
EndDeviceFunctionKind
AssetFunction
BatteryControl
Added new attributes to
RegulatingControl
:ctPrimary
minTargetDeadband
Added repeated attribute of
batteryControls
toBatteryUnit
.Added repeated attribute of
endDeviceFunctions
toEndDevice
.Test Steps
Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.
Checklist
If any of these are not applicable, strikethrough the line
~like this~
. Do not delete it!. Let the reviewer decide if you should have done it.Code
Documentation
Breaking Changes
I think this shouldntt be a breaking change as we are only adding stuff.