Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-1741] HCM interventions data model change #120

Merged
merged 19 commits into from
Dec 19, 2024

Conversation

Esaotuelr
Copy link
Member

@Esaotuelr Esaotuelr commented Nov 13, 2024

Description

Added the following messages/classes/types:

  • StaticVarCompensator
  • SVCControlMode
  • EndDeviceFunction
  • PanDemandResponseFunction
  • ControlledAppliance
  • EndDeviceFunctionKind
  • AssetFunction
  • BatteryControl

Added new attributes to RegulatingControl:

  • ctPrimary
  • minTargetDeadband

Added repeated attribute of batteryControls to BatteryUnit.

Added repeated attribute of endDeviceFunctions to EndDevice.

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members if so.

I think this shouldntt be a breaking change as we are only adding stuff.

@Esaotuelr Esaotuelr requested a review from charlta November 13, 2024 00:41
@ryanjcoleman
Copy link
Member

Task linked: DEV-1741 Update evolve-grpc

@charlta charlta changed the title [Dev 1741] data model change [DEV-1741] HCM interventions data model change Nov 13, 2024
@charlta
Copy link
Member

charlta commented Nov 13, 2024

I updated the name of the PR and the description to be more useful than "data model change".

I didn't change the branch name (which I should have) as it will close the PR

@charlta charlta requested a review from a team November 13, 2024 01:09
@charlta
Copy link
Member

charlta commented Nov 13, 2024

Added ewb-core as reviewers as it shouldn't have been sent straight to me.

@charlta charlta self-assigned this Nov 13, 2024
@Esaotuelr
Copy link
Member Author

I updated the name of the PR and the description to be more useful than "data model change".

I didn't change the branch name (which I should have) as it will close the PR

Thanks for that. Also I wasn't sure who could review this so I did just straight put your name against it for review. I'll put ewb-core for the rest of the other changes.

Copy link
Member

@charlta charlta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have barely looked at the PR and found some very sloppy mistakes.

Given this and the lazy nature of the PR name and description I feel this requires a more thorough self review before I look at it any further.

@charlta charlta marked this pull request as draft November 13, 2024 01:17
@Esaotuelr Esaotuelr marked this pull request as ready for review November 13, 2024 02:04
@Esaotuelr Esaotuelr requested review from a team and charlta November 13, 2024 02:12
@charlta charlta marked this pull request as draft November 13, 2024 04:11
@Esaotuelr Esaotuelr requested a review from charlta November 14, 2024 02:26
@Esaotuelr Esaotuelr marked this pull request as ready for review November 14, 2024 03:13
@Esaotuelr Esaotuelr requested a review from a team November 19, 2024 05:13
@Esaotuelr Esaotuelr force-pushed the DEV-1741-data-model-change branch from 9ec9573 to fba78df Compare December 3, 2024 04:49
@Esaotuelr Esaotuelr force-pushed the DEV-1741-data-model-change branch from ae04d07 to a7603b8 Compare December 11, 2024 02:17
@kgreav kgreav force-pushed the DEV-1741-data-model-change branch 2 times, most recently from 44ba96e to 981e0cd Compare December 15, 2024 10:37
@charlta charlta force-pushed the DEV-1741-data-model-change branch from 981e0cd to 8dac171 Compare December 16, 2024 00:45
Signed-off-by: Anthony Charlton <[email protected]>
@charlta charlta merged commit 50e7cb6 into main Dec 19, 2024
5 checks passed
@charlta charlta deleted the DEV-1741-data-model-change branch December 19, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants