[DEV-1994] Phase/wire level impedances #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kurt Greaves <[email protected]>
|
Task linked: DEV-1744 Update JVM SDK |
Signed-off-by: Kurt Greaves <[email protected]>
Signed-off-by: Kurt Greaves <[email protected]>
Signed-off-by: Anthony Charlton <[email protected]>
…onsistency. Signed-off-by: Anthony Charlton <[email protected]>
… collection. Signed-off-by: Anthony Charlton <[email protected]>
…n comparator. Signed-off-by: Anthony Charlton <[email protected]>
charlta
approved these changes
Dec 16, 2024
|
Doesn't build due to incorrect gRPC dependency, which will be corrected in the target branch. |
charlta
merged commit da75e51
into
DEV-1744-HCM-intervention-update
2 of 3 checks passed
charlta
added a commit
that referenced
this pull request
Dec 19, 2024
* Add PerLengthPhaseImpedance and PhaseImpedanceData Signed-off-by: Kurt Greaves <[email protected]> * Fix copyrights Signed-off-by: Kurt Greaves <[email protected]> * Update super pom Signed-off-by: Kurt Greaves <[email protected]> * Simplified AcLineSegment per length helpers. Signed-off-by: Anthony Charlton <[email protected]> * Renamed `PerLengthPhaseImpedance.data` and associated accessors for consistency. Signed-off-by: Anthony Charlton <[email protected]> * Removed `PerLengthPhaseImpedance.forEachData` as this is an unordered collection. Signed-off-by: Anthony Charlton <[email protected]> * Updated `PerLengthPhaseImpedance.data` to use new unordered collection comparator. Signed-off-by: Anthony Charlton <[email protected]> --------- Signed-off-by: Kurt Greaves <[email protected]> Signed-off-by: Anthony Charlton <[email protected]> Co-authored-by: Anthony Charlton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for PerLengthPhaseImpedance - the classes to support wire-level impedances (i.e, not sequence impedances)
Associated tasks
Test Steps
Probably just run the tests
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
Documentation
Breaking Changes
Protobuf had a breaking change so this has to be used with the new version of the ewb-grpc. There's also a minor change in the Resolver for perLength[Sequence]Impedance, which nobody was using.