Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DesignWare PWM driver is broken #18607

Closed
tbursztyka opened this issue Aug 23, 2019 · 2 comments · Fixed by #31412
Closed

DesignWare PWM driver is broken #18607

tbursztyka opened this issue Aug 23, 2019 · 2 comments · Fixed by #31412
Assignees
@anangl
Labels
area: Drivers area: PWM Pulse Width Modulation bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale

Comments

@tbursztyka
Copy link
Collaborator

It misses the API function get_cycles_per_sec() which is mandatory to get pwm.h public function to work.

So currently this driver just does not work at all due to that.
@tbursztyka tbursztyka added bug The issue is a bug, or the PR is fixing a bug area: Drivers area: PWM Pulse Width Modulation labels Aug 23, 2019
@rljordan-zz rljordan-zz assigned ghost Aug 27, 2019
@rljordan-zz rljordan-zz added the priority: low Low impact/importance bug label Aug 27, 2019
@carlescufi carlescufi assigned anangl and unassigned ghost Sep 15, 2020
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Nov 15, 2020
@anangl anangl removed the Stale label Nov 19, 2020
henrikbrixandersen added a commit to henrikbrixandersen/zephyr that referenced this issue Jan 18, 2021
@henrikbrixandersen
drivers: pwm: remove dw and pca9685 drivers
ba50807 
Remove DW and PCA9685 PWM controller drivers as they are unmaintained
and broken.

Both drivers lack support for the pwm_get_cycles_per_sec_t API function
which was introduced in commit 56e0b53
in 2016.

Fixes zephyrproject-rtos#18607, zephyrproject-rtos#18608

Signed-off-by: Henrik Brix Andersen <[email protected]>
@henrikbrixandersen henrikbrixandersen mentioned this issue Jan 18, 2021
Merged
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jan 19, 2021
nashif pushed a commit that referenced this issue Jan 19, 2021
@henrikbrixandersen @nashif
drivers: pwm: remove dw and pca9685 drivers
1491fb9 
Remove DW and PCA9685 PWM controller drivers as they are unmaintained
and broken.

Both drivers lack support for the pwm_get_cycles_per_sec_t API function
which was introduced in commit 56e0b53
in 2016.

Fixes #18607, #18608

Signed-off-by: Henrik Brix Andersen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anangl anangl

Labels
area: Drivers area: PWM Pulse Width Modulation bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drivers: pwm: remove dw and pca9685 drivers henrikbrixandersen/zephyr
3 participants
@tbursztyka @rljordan-zz @anangl