Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCA9685 PWM driver is broken #18608

Closed
tbursztyka opened this issue Aug 23, 2019 · 6 comments · Fixed by #31412
Closed

PCA9685 PWM driver is broken #18608

tbursztyka opened this issue Aug 23, 2019 · 6 comments · Fixed by #31412
Assignees
Labels
area: Drivers area: PWM Pulse Width Modulation bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@tbursztyka
Copy link
Collaborator

It misses the API function get_cycles_per_sec() which is mandatory to get pwm.h public function to work.

So currently this driver just does not work at all due to that.

@tbursztyka tbursztyka added bug The issue is a bug, or the PR is fixing a bug area: Drivers area: PWM Pulse Width Modulation labels Aug 23, 2019
@galak
Copy link
Collaborator

galak commented Aug 23, 2019

@tbursztyka I think this driver was added for an x86 platform that we have since removed. Are you wanting to use this on some other board? Curious how you are hitting this.

@rljordan-zz rljordan-zz assigned ghost Aug 27, 2019
@rljordan-zz rljordan-zz added the priority: low Low impact/importance bug label Aug 27, 2019
@tbursztyka
Copy link
Collaborator Author

@galak PCA9685 is an i2c slave device. There is no board using it yet, but what about zephyr user that would wire such device on a board?
Hitting it is easy: just reading the driver code.

@jfischer-no
Copy link
Collaborator

There are expansion boards with PCA9685, for example https://www.adafruit.com/product/815

@carlescufi carlescufi assigned anangl and unassigned ghost Sep 15, 2020
@vagotec
Copy link

vagotec commented Nov 7, 2020

Hi,
is there any example code for https://www.adafruit.com/product/815?

Thanks

sarvg

@nixward
Copy link
Member

nixward commented Nov 8, 2020

is there any example code for https://www.adafruit.com/product/815?

Hi @vagotec if an overlay was written for the PCA9685 the following sample could be used:
https://github.com/zephyrproject-rtos/zephyr/tree/master/samples/drivers/led_pwm

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jan 8, 2021
henrikbrixandersen added a commit to henrikbrixandersen/zephyr that referenced this issue Jan 18, 2021
Remove DW and PCA9685 PWM controller drivers as they are unmaintained
and broken.

Both drivers lack support for the pwm_get_cycles_per_sec_t API function
which was introduced in commit 56e0b53
in 2016.

Fixes zephyrproject-rtos#18607, zephyrproject-rtos#18608

Signed-off-by: Henrik Brix Andersen <[email protected]>
@henrikbrixandersen henrikbrixandersen linked a pull request Jan 18, 2021 that will close this issue
nashif pushed a commit that referenced this issue Jan 19, 2021
Remove DW and PCA9685 PWM controller drivers as they are unmaintained
and broken.

Both drivers lack support for the pwm_get_cycles_per_sec_t API function
which was introduced in commit 56e0b53
in 2016.

Fixes #18607, #18608

Signed-off-by: Henrik Brix Andersen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Drivers area: PWM Pulse Width Modulation bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants