net: l2: Correct debug message and avoid unneeded assignment #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
In progress
tbursztyka
requested changes
Sep 13, 2017
subsys/net/ip/l2/ethernet.c
Outdated
| if (pkt != arp_pkt) { | ||
| NET_DBG("Sending arp pkt %p (orig %p) to iface %p", | ||
| arp_pkt, pkt, iface); | ||
|
|
There was a problem hiding this comment.
rebase your patch again latest master, some removed lines were re-introduced again.
besides that it's fine to me.
At the moment we print "Sending ARP packet" even if we found ARP entry and send the packet directly. Signed-off-by: Andrei Emeltchenko <[email protected]>
tbursztyka
approved these changes
Sep 18, 2017
ghost
removed
the
In progress
nagineni
pushed a commit
to nagineni/zephyr
that referenced
this pull request
Nov 20, 2017
Updated iotivity-constrained with latest 6lowpan fixes, and updated 6lowpan configs to work with latest Zephyr 1.9 Fixes zephyrproject-rtos#1586, zephyrproject-rtos#1565, zephyrproject-rtos#1481, zephyrproject-rtos#1237 Signed-off-by: Jimmy Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we print "Sending ARP packet" even if we found ARP entry
and send the packet directly.
Signed-off-by: Andrei Emeltchenko [email protected]