Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: http: HTTP client was not honoring timeout parameter #1565

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

jukkar
Copy link
Member

@jukkar jukkar commented Sep 20, 2017

If the caller of http_client_send_req() sets the timeout to
K_NO_WAIT, then the function would still wait for a while before
returning to the caller.

Fixes #4048

Signed-off-by: Jukka Rissanen [email protected]

If the caller of http_client_send_req() sets the timeout to
K_NO_WAIT, then the function would still wait for a while before
returning to the caller.

Jira: ZEP-2624

Signed-off-by: Jukka Rissanen <[email protected]>
Copy link
Collaborator

@tbursztyka tbursztyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, allocation timeout is not the same as request timeout.

Copy link
Contributor

@mike-scott mike-scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jukkar jukkar merged commit eda6403 into zephyrproject-rtos:master Sep 27, 2017
@jukkar jukkar deleted the zep-2624-http-client branch October 13, 2017 09:19
@jukkar jukkar restored the zep-2624-http-client branch October 13, 2017 09:19
@jukkar jukkar deleted the zep-2624-http-client branch October 13, 2017 09:19
nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017
Updated iotivity-constrained with latest 6lowpan fixes,
and updated 6lowpan configs to work with latest Zephyr 1.9

Fixes zephyrproject-rtos#1586, zephyrproject-rtos#1565, zephyrproject-rtos#1481, zephyrproject-rtos#1237

Signed-off-by: Jimmy Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants