Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDP SC requires CSPRNG #29137

Merged
merged 3 commits into from
Oct 13, 2020
Merged

OSDP SC requires CSPRNG #29137

merged 3 commits into from
Oct 13, 2020

Conversation

ceolin
Copy link
Member

@ceolin ceolin commented Oct 12, 2020 •
edited by erwango
Loading

  • Make OSDP SC requires CSPRNG
  • General fixes when OSDP SC is not enabled

Fixes #29113

Flavio Ceolin added 3 commits October 12, 2020 16:31
mgmt: osdp: Make osdp sc requires on CSPRING_ENABLED
86a7ec4 
OSDP secure channel require a truly random number generator
source. Make this dependency explicit.

Signed-off-by: Flavio Ceolin <[email protected]>
mgmt: osdp: Fix build when osdp sc is not enabled
73941a9 
osdp was unconditionally referencing symbols that are defined only if
osdp sc is enabled.

Signed-off-by: Flavio Ceolin <[email protected]>
mgmt: osdp: Fix a warning about an unused variable
ed5cb55 
tmp variable is only used when osdp sc is enabled.

Signed-off-by: Flavio Ceolin <[email protected]>
@ceolin ceolin requested a review from sidcha as a code owner October 12, 2020 23:50
@ceolin ceolin mentioned this pull request Oct 12, 2020
Closed
sidcha
sidcha approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@sidcha sidcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

subsys/mgmt/osdp/src/osdp_pd.c
tmp = OSDP_PD_CAP_COMMUNICATION_SECURITY;
/* Workaround for error: a label can only be part of a
* statement and a declaration is not a statement */
;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sidcha sidcha linked an issue Oct 13, 2020 that may be closed by this pull request
Build failure with OSPD #29113
Closed
@sidcha sidcha added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label Oct 13, 2020
@erwango erwango requested a review from carlescufi October 13, 2020 08:27
@carlescufi carlescufi merged commit 619dcef into zephyrproject-rtos:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidcha sidcha sidcha approved these changes

@carlescufi carlescufi carlescufi approved these changes

@erwango erwango erwango approved these changes

Assignees
No one assigned
Labels
Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure with OSPD
4 participants
@ceolin @sidcha @carlescufi @erwango