Initial support for STM32 FMC #29686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: API
gmarull
force-pushed
the
feature/stm32-fmc
branch
3 times, most recently
from
c8efe97 to
3b52f82
Compare
|
cc: @matthew-koch @k0d |
carlescufi
requested review from
nvlsianpu,
MaureenHelm,
tejlmand,
andrewboie and
ioannisg
gmarull
force-pushed
the
feature/stm32-fmc
branch
2 times, most recently
from
ba2029f to
f0f7659
Compare
|
dev-review (Nov 5 2020): @MaureenHelm to look at this from a NXP point of view. @galak to look at this from a devicetree and common linker script view point. |
gmarull
force-pushed
the
feature/stm32-fmc
branch
4 times, most recently
from
1d0ab99 to
1177076
Compare
galak
reviewed
Nov 5, 2020
gmarull
force-pushed
the
feature/stm32-fmc
branch
from
1177076 to
920f383
Compare
erwango
reviewed
Nov 6, 2020
There was a problem hiding this comment.
Thanks for this great addition!
I don't have objections on the proposal.
One observation though: FMC_SDRAM_foo functions are supposed to be internal LL API (with HAL API as the unique client). I'm not opposed to using it directly, but this raises some concerns as these internal APIs do not propose the same guarantees the public APIs (portability, stability).
Can you elaborate on the arguments that made you chose this API over HAL ?
Second point is that it would be nice to add some quick test if doable (could be added under tests/boards) so this driver could be compiled in CI (and potential users can have a simple usage example)
carlescufi
requested review from
jettr
and removed request for
andyross,
tejlmand and
nvlsianpu
gmarull
force-pushed
the
feature/stm32-fmc
branch
from
4e1c42d to
7dba81d
Compare
|
Looks ok to me. @jhqian @mmahadevan108 Do you see any issues with this for SEMC on RT1xxx? |
lochej
approved these changes
Nov 13, 2020
gmarull
force-pushed
the
feature/stm32-fmc
branch
2 times, most recently
from
eaba078 to
1366faa
Compare
gmarull
force-pushed
the
feature/stm32-fmc
branch
from
1366faa to
0bd720f
Compare
carlescufi
reviewed
Nov 23, 2020
Update hal_stm32 to have access to FMC pins. Signed-off-by: Gerard Marull-Paretas <[email protected]>
This commit adds a new driver category for memory controller peripherals. There is no API involved for now, as it has not been found necessary for first implementation. STM32 Flexible Memory Controller (FMC) is the only controller supported for now. This peripheral allows to access multiple types of external memories, e.g. SDRAM, NAND, NOR Flash... The initial implementation adds support for the SDRAM controller only. The HAL API is used, so the implementation should be portable to other STM32 series. It has only been tested on H7 series, so for now it can only be enabled when working on H7. Linker facilities have also been added in order to allow applications to easily define a variable in SDRAM. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add myself to memc (memory controller) drivers. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add integration test to check r/w operations on STM32 external SDRAM. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Enable SDRAM on M7 core. Signed-off-by: Gerard Marull-Paretas <[email protected]>
gmarull
force-pushed
the
feature/stm32-fmc
branch
from
0bd720f to
c0885a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new driver category for memory controller peripherals. There is no API involved as it has not been found
necessary for first implementation.
STM32 Flexible Memory Controller (FMC) is the only controller supported for now. This peripheral allows accessing multiple types of external memories, e.g. SDRAM, NAND, NOR Flash...
The initial implementation adds support for the SDRAM controller only. HAL API is used, so the implementation should be portable to other STM32 series. It has only been tested on H7 series, so it can only be enabled when working on H7.
Linker facilities have also been added in order to allow applications to easily define a variable in SDRAM, e.g.
Tested with STM32H747I-DISCO board (SDRAM parameters have been taken from HAL examples).
To be discussed:
Closes #15944