Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memc support for STM32F7 series #40451

Closed
wants to merge 2 commits into from
Closed

Add memc support for STM32F7 series #40451

wants to merge 2 commits into from

Conversation

papadkostas
Copy link
Contributor

As per #36204 and #29686, adding support for STM32F7 and board STM32F769I-DISC0.

@erwango
Copy link
Member

erwango commented Nov 19, 2021

@papadkostas Thanks for this change, can you check build errors reported by CI: https://buildkite.com/zephyr/zephyr/builds/47049 ?

@papadkostas
Copy link
Contributor Author

Ohh, I'll have a look on the errors. I did another commit on the same branch of this PR for the support for the touch screen. At first there were no such errors I think. I'll revert it and check again. Anyway, I'll be back in few hours!

@papadkostas
Copy link
Contributor Author

@erwango I think now it's good.

gmarull
gmarull requested changes Nov 22, 2021
View reviewed changes
boards/arm/stm32f769i_disco/stm32f769i_disco.dts Outdated Show resolved Hide resolved
boards/arm/stm32f769i_disco/stm32f769i_disco.dts Outdated Show resolved Hide resolved
erwango
erwango reviewed Nov 23, 2021
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise sounds good except the points already reported by @gmarull

boards/arm/stm32f769i_disco/stm32f769i_disco.dts Show resolved Hide resolved
@papadkostas papadkostas requested a review from gmarull November 23, 2021 10:04
erwango
erwango reviewed Nov 23, 2021
View reviewed changes
dts/arm/st/f7/stm32f7.dtsi Outdated Show resolved Hide resolved
@erwango
Copy link
Member

erwango commented Nov 29, 2021

@papadkostas Can you fix the compliance test ?

@papadkostas
dts: stm32f7: add fmc device node for f7 series devices
e9a09cf 
Add device node for the FMC controller found in stm32f7(except f756xx).

Signed-off-by: Konstantinos Papadopoulos <[email protected]>
@papadkostas
boards: stm32f769i_disc0: add sdram support
c2c6dde 
Add support for the 16MB SDRAM found in STM32F769I-DISC0 boards.

Signed-off-by: Konstantinos Papadopoulos <[email protected]>
gmarull
gmarull reviewed Nov 30, 2021
View reviewed changes
boards/arm/stm32f769i_disco/stm32f769i_disco.dts
&fmc_d16_ph8 &fmc_d17_ph9 &fmc_d18_ph10 &fmc_d19_ph11
&fmc_d20_ph12 &fmc_d21_ph13 &fmc_d22_ph14 &fmc_d23_ph15
&fmc_d24_pi0 &fmc_d25_pi1 &fmc_d26_pi2 &fmc_d27_pi3
&fmc_d28_pi6 &fmc_d29_pi7 &fmc_d30_pi9 &fmc_d31_pi10>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing: pinctrl-names = "default"

gmarull
gmarull requested changes Nov 30, 2021
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, fix author/signed-off compliance warnings, add missing pinctrl-names

@papadkostas
Copy link
Contributor Author

please, fix author/signed-off compliance warnings, add missing pinctrl-names

I fixed them, but the compliance failure that appeared now, I don't know how to fix.
58b3f6f4b9e1bb590eba4289565ad49b6c6ea0ff is probably a commit in the past but still appearing somewhere, I'm not quite sure how to deal with it. I didn't read carefully the contribution guidelines at first to avoid all these problems.
I'll make a new PR. Excuse me! :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@explora26 explora26 explora26 left review comments

@gmarull gmarull gmarull requested changes

@ABOSTM ABOSTM ABOSTM approved these changes

@erwango erwango erwango approved these changes

@FRASTM FRASTM Awaiting requested review from FRASTM

@nashif nashif Awaiting requested review from nashif

@carlescufi carlescufi Awaiting requested review from carlescufi

@mbolivar-nordic mbolivar-nordic Awaiting requested review from mbolivar-nordic

@utzig utzig Awaiting requested review from utzig

Assignees

@erwango erwango

Labels
area: Boards area: Devicetree area: Documentation platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@papadkostas @erwango @explora26 @gmarull @ABOSTM