-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
composer: add ext-iconv dependency #3
Conversation
Call to undefined function iconv_strlen() in vendor/zf1s/zend-validate/library/Zend/Validate/Hostname.php on line 1823
from a quick search through the whole framework, iconv is used in many other components without any guards - it just assumes it's installed. If you think that's the right direction to include requirements of extensions to composer.json, would you mind preparing a PR on the monorepo http://github.com/zf1s/zf1 , please - otherwise it's just a partial fix? |
and please hold that dependencies bumping as the new release out of the monorepo https://github.com/zf1s/zf1 should fix your issues. I just need a bit more time, so just please bear with me. |
yes. this only fixes for this package as the monorepo is not ready yet, so I submitted to this repo for now. i would convert my previous effort in pld linux package to monorepo once it's ready for contributions... |
it is ready :) |
it's ready meaning you are able to create releases from monorepo? i guess there should be gitlab contributing.md in each subproject indicating how to report bugs and submit merge requests: |
how does it look? |
replaced with zf1s/zf1#6 |
Call to undefined function iconv_strlen() in vendor/zf1s/zend-validate/library/Zend/Validate/Hostname.php on line 1823
this also adds
ext-ctype
andext-reflection
:i've once went over ZF1 readme and filled the ext deps in that ZendFramework package: