Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer: add ext-iconv dependency #3

Closed
wants to merge 2 commits into from
Closed

Conversation

glensc
Copy link

@glensc glensc commented May 23, 2019

Call to undefined function iconv_strlen() in vendor/zf1s/zend-validate/library/Zend/Validate/Hostname.php on line 1823

this also adds ext-ctype and ext-reflection:

i've once went over ZF1 readme and filled the ext deps in that ZendFramework package:

glensc added 2 commits May 23, 2019 17:58
Call to undefined function iconv_strlen() in vendor/zf1s/zend-validate/library/Zend/Validate/Hostname.php on line 1823
@falkenhawk
Copy link
Member

from a quick search through the whole framework, iconv is used in many other components without any guards - it just assumes it's installed. If you think that's the right direction to include requirements of extensions to composer.json, would you mind preparing a PR on the monorepo http://github.com/zf1s/zf1 , please - otherwise it's just a partial fix?
image

@falkenhawk
Copy link
Member

falkenhawk commented May 23, 2019

and please hold that dependencies bumping as the new release out of the monorepo https://github.com/zf1s/zf1 should fix your issues. I just need a bit more time, so just please bear with me.

@glensc
Copy link
Author

glensc commented May 23, 2019

yes. this only fixes for this package as the monorepo is not ready yet, so I submitted to this repo for now.

i would convert my previous effort in pld linux package to monorepo once it's ready for contributions...

@falkenhawk
Copy link
Member

it is ready :)

@glensc
Copy link
Author

glensc commented May 23, 2019

it's ready meaning you are able to create releases from monorepo?

i guess there should be gitlab contributing.md in each subproject indicating how to report bugs and submit merge requests:

@falkenhawk
Copy link
Member

how does it look?
https://github.com/zf1s/zend-acl/releases
https://packagist.org/packages/zf1s/zend-acl#1.13.0-rc.1
I spent too much time on this already, so any help would be appreciated. If you see that a contributing file would be handful, please either submit a PR or send me such file which I'd copy over to all the packages. Also, it won't mean that any serious development process on zf1 would be restored...

@glensc
Copy link
Author

glensc commented May 23, 2019

replaced with zf1s/zf1#6

@glensc glensc closed this May 23, 2019
@glensc glensc deleted the patch-1 branch February 26, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants