Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer: fill ext-* dependencies #6

Merged
merged 1 commit into from
May 24, 2019
Merged

Conversation

Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that. I am only worried this will cause composer shouting when the ext requirements are not met (in cases where existing installations was all fine without them - if luckily the parts requiring the ext functions were never executed) - but behavior should be more predictable with these specified..

@glensc
Copy link
Contributor Author

glensc commented May 23, 2019

rechecked all packages with composer validate:

$ for a in packages/*/composer.json; do (cd $(dirname "$a") && pwd && composer.phar validate); done
/Users/glen/scm/tmp/zf1/packages/zend-acl
./composer.json is valid
/Users/glen/scm/tmp/zf1/packages/zend-amf
./composer.json is valid
...

@glensc
Copy link
Contributor Author

glensc commented May 23, 2019

here's some simpler version, using $COMPOSER:

➔ for COMPOSER in packages/*/composer.json; do COMPOSER=$COMPOSER composer.phar validate; done
packages/zend-acl/composer.json is valid
packages/zend-amf/composer.json is valid
packages/zend-application/composer.json is valid
packages/zend-auth/composer.json is valid
packages/zend-barcode/composer.json is valid
packages/zend-cache/composer.json is valid
packages/zend-captcha/composer.json is valid
^C

doc: https://getcomposer.org/doc/03-cli.md#composer

@glensc
Copy link
Contributor Author

glensc commented May 23, 2019

#7

@falkenhawk falkenhawk merged commit cbedb76 into zf1s:master May 24, 2019
@glensc glensc deleted the ext-deps branch May 24, 2019 09:41
@glensc
Copy link
Contributor Author

glensc commented Jul 8, 2019

this is awesome,

[Mon Jul 08 15:42:23.108338 2019] [:error] [pid 11] [client a.b.c.d:0] PHP Fatal error:  Call to undefined function ctype_alnum() in /app/vendor/zf1s/zend-uri/library/Zend/Uri.php on line 109

I was using 1.12.21, update to 1.13.0 will fix this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants