-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: validate each package.json #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
.travis.yml
Outdated
- ./vendor/bin/phpunit | ||
|
||
# vim:ts=2:sw=2:et |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop this out in favor of editorconfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you know, the vim implementation is the poorest of editorconfig. it requires you to have specific build of vim with python enabled, and bunch of other random bundle/vundle/blurb.
and while i mostly edit yaml files on servers where is just plain vim, i find the modeline just do the thing. especially the default in vim is tab which is invalid for yaml.
the situation is better with neovim: it has better python support, no need to recompile, just install addon package. but the editor config integration still needs to be loaded external.
however, i'll remove from this project after this rant :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other reason I leave some comment at the end of file, is that insert_final_newline
setting which each editor handles differently. and i use those conflicting editors daily. luckily with last line being something irrelevant I can decide not to change that chunk with git add -p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I see but I cannot help you with VIM approach too much ...
I would adjust .editorconfig
file that is a well-known standard to adjust the editor's configuration
regarding the VIM config, I would avoid putting too many users dependant stuff to the main repository ... maybe there is another way that solves the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
validates each package
composer.json
:https://getcomposer.org/doc/03-cli.md#composer