Fix compose box obscured by keyboard on long message, in stream view. #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jainkuniya ! Merged. |
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
Oct 4, 2019
At present, when loading content into the WebView, we inject all non-image assets as part of the generated HTML. This is more than a bit wasteful, considering that large swaths of the supporting CSS and JavaScript is entirely static from invocation to invocation; additionally, it makes KaTeX support somewhere between "nontrivial" and "impossible". This commit creates a build subsystem which can inject static webview-supporting assets into the application bundle, into a `webview` directory. We also create a stub directory for the subsystem copy assets from; at present this contains only a README.md file (which will *not* be copied), but this will be expanded in the following series of commits. Inspired by zulip#2690. Assists with zulip#2660, zulip#3595, and potentially many other issues.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
Oct 4, 2019
At present, when loading content into the WebView, we inject all non-image assets as part of the generated HTML. This is more than a bit wasteful, considering that large swaths of the supporting CSS and JavaScript is entirely static from invocation to invocation; additionally, it makes KaTeX support somewhere between "nontrivial" and "impossible". This commit creates a build subsystem which can inject static webview-supporting assets into the application bundle, into a `webview` directory. We also create a stub directory for the subsystem to copy assets from; at present this contains only a README.md file (which will *not* be copied), but this will be expanded in the following series of commits. Inspired by zulip#2690. Assists with zulip#2660, zulip#3595, and potentially many other issues.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
Oct 9, 2019
At present, when loading content into the WebView, we inject all non-image assets as part of the generated HTML. This is more than a bit wasteful, considering that large swaths of the supporting CSS and JavaScript is entirely static from invocation to invocation; additionally, it makes KaTeX support somewhere between "nontrivial" and "impossible". This commit creates a build subsystem which can inject static webview-supporting assets into the application bundle, into a `webview` directory. We also create a stub directory for the subsystem to copy assets from; at present this contains only a README.md file (which will *not* be copied), but this will be expanded in the following series of commits. Inspired by zulip#2690. Assists with zulip#2660, zulip#3595, and potentially many other issues.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
Oct 10, 2019
At present, when loading content into the WebView, we inject all non-image assets as part of the generated HTML. This is more than a bit wasteful, considering that large swaths of the supporting CSS and JavaScript is entirely static from invocation to invocation; additionally, it makes KaTeX support somewhere between "nontrivial" and "impossible". This commit creates a build subsystem which can inject static webview-supporting assets into the application bundle, into a `webview` directory. We also create a stub directory for the subsystem to copy assets from; at present this contains only a README.md file (which will *not* be copied), but this will be expanded in the following series of commits. Inspired by zulip#2690. Assists with zulip#2660, zulip#3595, and potentially many other issues.
gnprice
pushed a commit
that referenced
this pull request
Oct 11, 2019
At present, when loading content into the WebView, we inject all non-image assets as part of the generated HTML. This is more than a bit wasteful, considering that large swaths of the supporting CSS and JavaScript is entirely static from invocation to invocation; additionally, it makes KaTeX support somewhere between "nontrivial" and "impossible". This commit creates a build subsystem which can inject static webview-supporting assets into the application bundle, into a `webview` directory. We also create a stub directory for the subsystem to copy assets from; at present this contains only a README.md file (which will *not* be copied), but this will be expanded in the following series of commits. Inspired by #2690. Assists with #2660, #3595, and potentially many other issues.
jainkuniya
added a commit
to jainkuniya/zulip-mobile
that referenced
this pull request
Jul 19, 2020
Remove scroll view from input wrapper (which was added in zulip#3595). This fixed zulip#3614. Also just checked it works fine on Android as well. So basically zulip#3595 was not a completely right solution for zulip#3369. Now inputs are wrapped with simple view, which is self aligned as vertically center. ComposeMenu and SendButton are self aligned as vertically end. And wrapper of all this three has justifyContent as space-between, which makes them spread whole over horizontal space available. This removes alignItems: 'flex-end' from `composeBox`, which was pushing input to vertically bottom, idealy it should be at vertically center. Fixes: zulip#3614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3369