composeBox, iOS: Fix msg input is not scrolled on typing. #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eachable." This reverts commit 3574b12. This was not a right fix, it introduced zulip#3614. So reverting it. Also see futher commit for right fix.
Now max height is set to composeBox, so when msg input expands it takes all the space available in the parent and pushes topic input outside. The workaround of this is to set position of topic input absolute and adjust position of msg input accordingly with the help of marginTop. Fixes: zulip#3614
jainkuniya
commented
Dec 7, 2019
| @@ -31,6 +31,9 @@ const componentStyles = StyleSheet.create({ | |||
| flex: 1, | |||
| flexDirection: 'column-reverse', | |||
| }, | |||
| composeBox: { | |||
| maxHeight: '60%', | |||
There was a problem hiding this comment.
relative max height, so we don't have to worry about split screen.
|
Closing this. As described on #3614, the next step on this issue needs to be that we do some work to understand what's actually going wrong here. If something were really seriously wrong from a user perspective and we had a hack that made it a lot better, then we'd certainly be open to merging the hack while we investigated the underlying cause. But that's what we've already done on this issue, with #3595 fixing #3369. This new hack is rather messier than the one we have, and it introduces new user-facing problems. It's time to focus on fixing the actual issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.