Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagrams and dg feature for set weak #107

Merged
merged 3 commits into from
Mar 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,26 @@ _{Explain here how the data archiving feature will be implemented}_


--------------------------------------------------------------------------------------------------------------------
### Set Weakness Threshold Feature

This is a new command to designate students as being "weak" or not based on their grades.
By default, we have set C+ as the threshold, meaning that a student with grade lower than C+ is
displayed with a weak marker next to their name.

The command "set weak [grade]" followed by the grade allows the instructor to set a difference grade as the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean "different" instead of "difference"?

new threshold. This command resets students' weak markers immediately.


The following activity diagram:
![SetWeakSequenceDiagram](images/SetWeakActivityDiagram.png)

The State prior to set weak command
![SetWeakStateDisgram](images/SetWeak1.png)

The State after set weak command
![SetWeakStateDiagram](images/SetWeak2.png)
--------------------------------------------------------------------------------------------------------------------


## **Documentation, logging, testing, configuration, dev-ops**

Expand Down
30 changes: 30 additions & 0 deletions docs/diagrams/SetWeak1.puml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
@startuml
'https://plantuml.com/class-diagram

hide circle
hide methods

skinparam ClassFontColor #000000
skinparam ClassBorderColor #000000
skinparam ClassBackgroundColor #FFFFAA

title Before set weak Command

package addressBook <<rectangle>> {
class State0 as "<U>p0:Person</u>" {
studentId = A2345678S
grade = A+
}
class State1 as "<u>p1:Person</u>" {
studentId = A0123456X
grade = C
weak
}
class State2 as "<u>p2:Person</u>" {
studentId = A1234567H
grade = B+
}
}

State1 -[hidden]right-> State2
@enduml
31 changes: 31 additions & 0 deletions docs/diagrams/SetWeak2.puml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
@startuml
'https://plantuml.com/class-diagram

hide circle
hide methods

skinparam ClassFontColor #000000
skinparam ClassBorderColor #000000
skinparam ClassBackgroundColor #FFFFAA

title After set weak Command (set weak B+)

package addressBook <<rectangle>> {
class State0 as "<U>p0:Person</u>" {
studentId = A2345678S
grade = A+
}
class State1 as "<u>p1:Person</u>" {
studentId = A0123456X
grade = C
weak
}
class State2 as "<u>p2:Person</u>" {
studentId = A1234567H
grade = B+
weak
}
}

State1 -[hidden]right-> State2
@enduml
18 changes: 18 additions & 0 deletions docs/diagrams/SetWeakActivityDiagram.puml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
@startuml
skin rose
skinparam ActivityFontSize 15
skinparam ArrowFontSize 12
start
:User executes set weak command;

'Since the beta syntax does not support placing the condition outside the
'diamond we place it as the true branch instead.

:Parse grade from command;
if () then ([Grade is valid])
:Update thresholdGrade value;
else ([else])
:Display error message;
endif
stop
@enduml
Binary file added docs/images/SetWeak1.png
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether this is how weak should be shown. Because weak is not really an attribute of person class, rather its evaluated everytime.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/SetWeak2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/images/SetWeakActivityDiagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading