[3.2] SHiP flush logs on write #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or crash leaves valid ship logs.
linh2931
reviewed
Mar 30, 2023
| @@ -263,6 +263,9 @@ class state_history_log { | |||
| const uint32_t num_blocks_in_log = _end_block - _begin_block; | |||
| fc::raw::pack(log, num_blocks_in_log); | |||
| } | |||
|
|
|||
| log.flush(); | |||
| index.flush(); | |||
There was a problem hiding this comment.
Will this have any performance impact? But correctness is more important and this is only on ship node. It should be OK.
Do we have tests which repeatedly kill and shutdown ship?
There was a problem hiding this comment.
Yes, there is a performance impact. Likely fairly small.
We do not test kill -9 with SHiP as there is no guarantee it will work. If the kill -9 happens during or between the flushes then this will not help. However, during manual testing I was able to kill -9 and recover from snapshot. Since most of the time is outside the write/flush this does help.
linh2931
approved these changes
Mar 30, 2023
spoonincode
approved these changes
Mar 30, 2023
This was referenced Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flush the
state_history_pluginlogs to disk at the end of each write to make it more likely that akill -9or crash leaves valid logs.Resolves #596