[3.2 -> 4.0] SHiP flush logs on write #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or crash leaves valid ship logs.
[3.2] SHiP flush logs on write
linh2931
reviewed
Mar 31, 2023
| fork_db.reset( *head ); | ||
| return; | ||
| if (!blog_head) | ||
| return; |
There was a problem hiding this comment.
3.2
leap/libraries/chain/controller.cpp
Line 480 in 4359bc0
There was a problem hiding this comment.
It is likely a good change for 3.2 as well, but I hit the problem in 4.0 because 4.0 in on_accepted_block calls chain.last_irreversible_block_id(). 3.2 does not call that method and didn't hit this issue.
Happy, to pull this in via a separate PR if desired, but it has to go in otherwise ship aborts when loading from a snapshot.
There was a problem hiding this comment.
Since the PR title is [3.2 -> 4.0], it might be better to only contain 3.2 changes. A separate PR is an extra work. Either way is fine with me.
|
Replaced by #935 without the forkdb root change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flush the
state_history_pluginlogs to disk at the end of each write to make it more likely that akill -9or crash leaves valid logs.Merges #928 into
release/4.0.Includes a fix for replay where
forkdb.root()is null during the write in SHiP foron_accepted_block. 4.0 SHiP callschain.last_irreversible_block_id()inon_accepted_blockwhich expectsforkdb.root()to be valid.Resolves #596