Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2 -> 4.0] SHiP flush logs on write #935

Merged
merged 3 commits into from
Mar 31, 2023
Merged

[3.2 -> 4.0] SHiP flush logs on write #935

merged 3 commits into from
Mar 31, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Mar 31, 2023

Flush the state_history_plugin logs to disk at the end of each write to make it more likely that a kill -9 or crash leaves valid logs.

Merges #928 into release/4.0.

Resolves #596

@heifner heifner requested review from linh2931 and spoonincode March 31, 2023 14:10
@heifner heifner mentioned this pull request Mar 31, 2023
Closed
@heifner heifner added the OCI Work exclusive to OCI team label Mar 31, 2023
@heifner heifner merged commit fc8cd5b into release/4.0 Mar 31, 2023
@heifner heifner deleted the GH-596-ship-flush-4 branch March 31, 2023 16:15
@heifner heifner mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoonincode spoonincode spoonincode approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heifner @spoonincode @linh2931