Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: transaction amount with hint in summary #796

Closed
wants to merge 5 commits into from
Closed

refactor: transaction amount with hint in summary #796

wants to merge 5 commits into from

Conversation

patricio0312rev
Copy link
Contributor

[tx details] add "send to self" to tx details for multipay transactions

Summary

  • "Send to self" hint has been added in multipay transaction details.
  • Hint will only be shown if the user is not the sender
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review November 4, 2024 16:51
@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 6, 2024 10:24pm

@patricio0312rev
Copy link
Contributor Author

Marking this as draft until ArdentHQ/platform-sdk#106 gets merged

@patricio0312rev patricio0312rev added this to the 1.18.0 milestone Nov 4, 2024
@patricio0312rev patricio0312rev marked this pull request as draft November 4, 2024 17:05
@shahin-hq
Copy link
Contributor

Hey @patricio0312rev, FYI, the related PSDK changes are released 👀

@patricio0312rev
Copy link
Contributor Author

Opening a cleaner PR on: #803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@patricio0312rev @shahin-hq