-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External Media: Add bottom padding to Google Photos modal #21201
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
This fixes the bug with Google Photos, but creates a new issue where you can't scroll to the bottom of the Pexels image selection, so you can't load more results. With this patch: On production:
|
Nice catch @sixhours! Hm, not sure how to fix this then, it's an odd one. Changing CSS values in Safari seems to make the modal jump back into its usual shape—I wonder if it's a rendering issue? |
Ah yes, I caught the bug @sixhours reported as well.
725f174
to
9b5837b
Compare
…ig screens Fixes a bug where there was no breathing room at the bottom of the modal.
9b5837b
to
8ada054
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me now.
Great news! One last step: head over to your WordPress.com diff, D67479-code, and commit it. Thank you! |
* master: Releases: start 10.3-a.4 cycle (#21454) Atomic Release: prepare changelogs for today's release (#21453) Connection: fixing the bug with connect button not appearing for secondary users (#21450) CLI: Add readme to 'jetpack release' (#21418) Update handling and setting CCPA related cookies (#21337) Publicize: do not disable toggle connection control when RePublicize is enabled (#21373) External Media: Add bottom padding to Google Photos modal (#21201) Blog Subscription Widget: deprecate widget and transform to block (#21184)
# By Jeremy Herve (2) and others # Via GitHub * master: Releases: start 10.3-a.4 cycle (#21454) Atomic Release: prepare changelogs for today's release (#21453) Connection: fixing the bug with connect button not appearing for secondary users (#21450) CLI: Add readme to 'jetpack release' (#21418) Update handling and setting CCPA related cookies (#21337) Publicize: do not disable toggle connection control when RePublicize is enabled (#21373) External Media: Add bottom padding to Google Photos modal (#21201) Blog Subscription Widget: deprecate widget and transform to block (#21184) # Conflicts: # projects/plugins/boost/tests/e2e/package.json
r233557 |
Changes proposed in this Pull Request:
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Before
After