Connection: fixing the bug with connect button not appearing for secondary users #21450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeymitr
added
[Type] Bug
github-actions
bot
added
[Plugin] Jetpack
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
sergeymitr
added
the
[Status] Needs Review
jeherve
added
[Status] Ready to Merge
jeherve
approved these changes
Oct 19, 2021
jeherve
pushed a commit
that referenced
this pull request
Oct 19, 2021
…earing for secondary users (#21450)
|
Cherry-picked to |
jeherve
removed
[Status] Ready to Merge
davidlonjon
added a commit
that referenced
this pull request
Oct 19, 2021
* master: Releases: start 10.3-a.4 cycle (#21454) Atomic Release: prepare changelogs for today's release (#21453) Connection: fixing the bug with connect button not appearing for secondary users (#21450) CLI: Add readme to 'jetpack release' (#21418) Update handling and setting CCPA related cookies (#21337) Publicize: do not disable toggle connection control when RePublicize is enabled (#21373) External Media: Add bottom padding to Google Photos modal (#21201) Blog Subscription Widget: deprecate widget and transform to block (#21184)
davidlonjon
added a commit
that referenced
this pull request
Oct 19, 2021
# By Jeremy Herve (2) and others # Via GitHub * master: Releases: start 10.3-a.4 cycle (#21454) Atomic Release: prepare changelogs for today's release (#21453) Connection: fixing the bug with connect button not appearing for secondary users (#21450) CLI: Add readme to 'jetpack release' (#21418) Update handling and setting CCPA related cookies (#21337) Publicize: do not disable toggle connection control when RePublicize is enabled (#21373) External Media: Add bottom padding to Google Photos modal (#21201) Blog Subscription Widget: deprecate widget and transform to block (#21184) # Conflicts: # projects/plugins/boost/tests/e2e/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Fix the bug with connection not appearing for secondary users after disconnect.
After secondary user gets disconnected, connection status in the state doesn't get properly updated. This PR fixes it by updating the state properly.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
We'll start with reproducing the bug to make sure we're actually fixing it.
masterbranch, connect Jetpack.