Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releases: start 10.3-a.4 cycle #21454

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Releases: start 10.3-a.4 cycle #21454

merged 1 commit into from
Oct 19, 2021

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Oct 19, 2021

Changes proposed in this Pull Request:

  • Start a new alpha release cycle.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Check if CI is happy.

@jeherve jeherve added General [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Oct 19, 2021
@jeherve jeherve self-assigned this Oct 19, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D68614-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ E2E Tests labels Oct 19, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

Boost plugin:

  • Next scheduled release: November 30, 2021.
  • Scheduled code freeze: November 23, 2021.

jeherve
jeherve commented Oct 19, 2021
View reviewed changes
projects/plugins/boost/tests/e2e/package.json
Comment on lines -21 to +51
"tunnel-on": "pm2 start ./node_modules/jetpack-e2e-commons/config/ecosystem.config.js && pm2 logs --nostream --lines 4",
"tunnel-reset": "rm -rf config/tmp && pnpm run tunnel-on",
"tunnel-off": "pm2 delete ./node_modules/jetpack-e2e-commons/config/ecosystem.config.js && NODE_ENV=test tunnel off",
"tunnel-write-logs": "pm2 logs --nostream --lines 10000 > output/logs/tunnel.log",
"pretest-e2e": "pnpm run clean",
"test-e2e": ". ./node_modules/jetpack-e2e-commons/bin/app-password.sh && NODE_CONFIG_DIR='./config' jest --config jest.config.js --runInBand --verbose --detectOpenHandles --json --outputFile=output/summary.json",
"test-decrypt-config": "openssl enc -md sha1 -aes-256-cbc -d -pass env:CONFIG_KEY -in ./node_modules/jetpack-e2e-commons/config/encrypted.enc -out ./config/local-test.js",
"preinstall": "pnpm --prefix ../../../../../tools/e2e-commons install"
"tunnel-on": "pm2 start ./node_modules/jetpack-e2e-commons/config/ecosystem.config.js && pm2 logs --nostream --lines 4",
"tunnel-reset": "rm -rf config/tmp && pnpm run tunnel-on",
"tunnel-off": "pm2 delete ./node_modules/jetpack-e2e-commons/config/ecosystem.config.js && NODE_ENV=test tunnel off",
"tunnel-write-logs": "pm2 logs --nostream --lines 10000 > output/logs/tunnel.log",
"pretest-e2e": "pnpm run clean",
"test-e2e": ". ./node_modules/jetpack-e2e-commons/bin/app-password.sh && NODE_CONFIG_DIR='./config' jest --config jest.config.js --runInBand --verbose --detectOpenHandles --json --outputFile=output/summary.json",
"test-decrypt-config": "openssl enc -md sha1 -aes-256-cbc -d -pass env:CONFIG_KEY -in ./node_modules/jetpack-e2e-commons/config/encrypted.enc -out ./config/local-test.js",
"preinstall": "pnpm --prefix ../../../../../tools/e2e-commons install"
},
"devDependencies": {
"@babel/core": "^7.15.5",
"@babel/preset-env": "^7.15.6",
"@wordpress/eslint-plugin": "^9.1.2",
"babel-jest": "^27.2.4",
"config": "^3.3.6",
"eslint": "^7.32.0",
"eslint-plugin-jest": "^24.5.2",
"expect-playwright": "^0.7.2",
"jest": "^27.2.4",
"jest-junit": "^12.3.0",
"jest-runner-groups": "^2.1.0",
"jetpack-cli": "link:../../../../../tools/cli",
"jetpack-e2e-commons": "link:../../../../../tools/e2e-commons",
"pm2": "^5.1.2"
"@babel/core": "^7.15.5",
"@babel/preset-env": "^7.15.6",
"@wordpress/eslint-plugin": "^9.1.2",
"babel-jest": "^27.2.4",
"config": "^3.3.6",
"eslint": "^7.32.0",
"eslint-plugin-jest": "^24.5.2",
"expect-playwright": "^0.7.2",
"jest": "^27.2.4",
"jest-junit": "^12.3.0",
"jest-runner-groups": "^2.1.0",
"jetpack-cli": "link:../../../../../tools/cli",
"jetpack-e2e-commons": "link:../../../../../tools/e2e-commons",
"pm2": "^5.1.2"
},
"engines": {
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
},
"browserslist": []
"browserslist": []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was automated, and it seems it's really just spaces > tabs.

@jeherve jeherve added this to the jetpack/10.3 milestone Oct 19, 2021
@jeherve jeherve enabled auto-merge (squash) October 19, 2021 10:59
fgiannar
fgiannar approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@fgiannar fgiannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve jeherve merged commit 7392d65 into master Oct 19, 2021
@jeherve jeherve deleted the update/alpha-10-3-a-4 branch October 19, 2021 11:29
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D68614-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Oct 19, 2021
davidlonjon added a commit that referenced this pull request Oct 19, 2021
@davidlonjon
Merge branch 'master' into fix/boost-ui-issues
d49dcac 
* master:
  Releases: start 10.3-a.4 cycle (#21454)
  Atomic Release: prepare changelogs for today's release (#21453)
  Connection: fixing the bug with connect button not appearing for secondary users (#21450)
  CLI: Add readme to 'jetpack release' (#21418)
  Update handling and setting CCPA related cookies (#21337)
  Publicize: do not disable toggle connection control when RePublicize is enabled (#21373)
  External Media: Add bottom padding to Google Photos modal (#21201)
  Blog Subscription Widget: deprecate widget and transform to block (#21184)
davidlonjon added a commit that referenced this pull request Oct 19, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-ci-integration
4489562 
# By Jeremy Herve (2) and others
# Via GitHub
* master:
  Releases: start 10.3-a.4 cycle (#21454)
  Atomic Release: prepare changelogs for today's release (#21453)
  Connection: fixing the bug with connect button not appearing for secondary users (#21450)
  CLI: Add readme to 'jetpack release' (#21418)
  Update handling and setting CCPA related cookies (#21337)
  Publicize: do not disable toggle connection control when RePublicize is enabled (#21373)
  External Media: Add bottom padding to Google Photos modal (#21201)
  Blog Subscription Widget: deprecate widget and transform to block (#21184)

# Conflicts:
#	projects/plugins/boost/tests/e2e/package.json
@jeherve
Copy link
Member Author

jeherve commented Oct 19, 2021

r233538-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgiannar fgiannar fgiannar approved these changes

Assignees

@jeherve jeherve

Labels
E2E Tests General [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
jetpack/10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @matticbot @fgiannar