Compute migration to track 1 deprecation #21949

grizzlytheodore · 2023-05-30T13:37:15Z

Description

Following most of changes made by Dingmeng in:
https://github.com/Azure/azure-powershell/tree/share/compute

Checklist

Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT introduce breaking changes in Az minor release except preview version.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2023-05-30T13:37:18Z

️✔️Az.Accounts

️✔️Az.ApplicationInsights

⚠️Az.Compute

️✔️Az.EventHub

️✔️Az.KeyVault

️✔️Az.ManagedServiceIdentity

️✔️Az.Monitor

️✔️Az.Network

️✔️Az.OperationalInsights

️✔️Az.PrivateDns

️✔️Az.RecoveryServices

️✔️Az.Security

️✔️Az.Sql

️✔️Az.Ssh

️✔️Az.Storage

grizzlytheodore · 2023-05-30T13:39:28Z

Add "Do Not Merge" tag, as this will change the Compute PowerShell development process, and we want to thoroughly update our documentation on that first.
But meanwhile please review as this is a big PR.

src/Compute/Compute.Sdk/README.md

vidai-msft · 2023-06-21T03:13:56Z

/azp run

azure-pipelines · 2023-06-21T03:14:14Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Compute/Compute.Sdk/Compute.Sdk.csproj

src/Compute/Compute/Az.Compute.psd1

vidai-msft · 2023-06-23T06:58:30Z

@grizzlytheodore A gentle reminder. The code freeze for this sprint is PST 6PM 6/26. If you want to have the change released on July 4, please make this PR ready before that. Let me know if you have any questions. Thanks!

grizzlytheodore · 2023-06-26T15:05:37Z

@vidai-msft we will address them for the next release

grizzlytheodore · 2023-07-12T14:43:11Z

@vidai-msft addressed your comments. let's see how to CI checks come out

src/Compute/Compute.Sdk/README.md

vidai-msft · 2023-07-14T03:25:26Z

@grizzlytheodore in addition to the comment, this PR also needs following changes.

Rename the folder Compute.Sdk to Compute.Management.Sdk
Some xml comments in the files under the Customizations folder are not well formatted. You can try to build locally and then fix them.

grizzlytheodore · 2023-07-17T21:49:47Z

addressed 1. for 2, for some reason when I build from this branch, it never finishes.
the Xml formats fixes are more optional is that right?

If there is more that we need to address, I will set up some time with you so we can take a look together and also fix this build issue.

vidai-msft · 2023-07-18T01:41:20Z

@grizzlytheodore the folder Compute.Sdk is still not updated. The xml comments are optional. However, it caused build issue on CI. Per my investigation, you may need to remove the xml for the following files Disk.cs, DiskRestorePoint.cs, DiskUpdate.cs, ImageDiskReference.cs, Snapshot.cs, 'SnapshotUpdate.cs`

grizzlytheodore · 2023-07-18T17:16:17Z

thank you for your comment. i was able to address them

grizzlytheodore · 2023-07-22T18:58:42Z

@vidai-msft what are your thoughts about the currency static analysis failure?
"Az.Compute","src/Compute/Compute.Management.Sdk","1","9090","Generated code for Az.Compute is not up to date or you have updated generated Sdk."
Is it expected?

vidai-msft · 2023-07-23T04:49:18Z

@grizzlytheodore per what I ran locally, there were 4 files (DedicatedHost.cs, DedicatedHostUpdate.cs, PriorityMixPolicy.cs, RollingUpgradePolicy.cs) not exactly the same as submitted in this PR. Can you please re-run the below commands to confirm?
autorest --reset
autorest --use:@microsoft.azure/[email protected]
autorest.cmd README.md --version=v2

src/Compute/Compute.Management.Sdk/README.md

Co-authored-by: Vincent Dai <[email protected]>

…ershell into computeMigration

src/Compute/Compute.Management.Sdk/Properties/AssemblyInfo.cs

vidai-msft · 2023-08-08T08:50:13Z

@grizzlytheodore the updated SDK looks like having breaking change. Please check the details in the static analysis.

…ershell into computeMigration

vidai-msft

LGTM

grizzlytheodore · 2023-08-14T14:27:23Z

Thank you for working with me and guiding me through this complex PR. @vidai-msft

* Bump up version for KeyVault (#22511) * Merge remote-tracking branch 'upstream/main' into lnx/azurecore (#22349) Co-authored-by: Yeming Liu <[email protected]> * Exclude the api-version in typename when checking the breaking change of cmdlet output (#22495) * Exclude the api-version in typename when checking the breaking change of cmdlet output * Rename the function * fix Get-AzVmRunCommand bug (#22460) * fix bug * changelog --------- Co-authored-by: Theodore Chang <[email protected]> * Add permission for pr-label github actions (#22481) * Add permission for pr-label github actions * Add permission for pr-label github actions * Add permission for pr-label github actions * Add permission for pr-label github actions * Update Remove-AzApiManagementApiFromGateway.md (#22505) Added the example of removing an API from a managed gateway. Users are not able to achieve it by following the first example and raising questions using support tickets. * Migrate StackHCI from generation to main (#22541) * Move StackHCI to main * udpate changelog --------- Co-authored-by: YanaXu <[email protected]> * [KeyVault] Support MHSM Settings (#22525) * wip * add update-azkeyvaultsetting and help docs * add example for settings * add change log * add live test * fix * fix * Migrate ContainerInstance from generation to main (#22537) * Move ContainerInstance to main * Create containerGroups-containers.json * Create containerGroups.json --------- Co-authored-by: Beisi Zhou <[email protected]> * Updated ChangeLog.md for Az.ContainerInstance (#22550) * Updated ChangeLog.md for Az.ContainerInstance * Update src/ContainerInstance/ChangeLog.md --------- Co-authored-by: Beisi Zhou <[email protected]> * [Synapse] Update artifact to 1.0.0-preview.18 (#22452) * update artifact to 18 * fix change log error * workaround the assembly loading issue (#22551) * [Compute] update sdk package reference for Compute (#22459) * update SDK reference * resolve breaking change * update package reference * breaking change mitigation * breaking change suppression * re-record ssh test with latest compute API call --------- Co-authored-by: Theodore Chang <[email protected]> * Bump up version for StackHCI (#22543) * Compute migration to track 1 deprecation (#21949) * add compute.sdk project reference * add sdk folder * address comments * update commit version to inputs * rename Compute.Sdk folder to Compute.Management.Sdk * resolve xmls, change compute.sdk reference to compute.management.sdk * remove SDK reference. generate track 1 with latest DiskRP version * Update src/Compute/Compute.Management.Sdk/README.md Co-authored-by: Vincent Dai <[email protected]> * fix autorest cmd * update autorest gen * Update Compute.Management.Sdk.csproj * generated with latest swagger versions. 2023-04-02 diskRP 2023-07-01 CRP * update assembly version of sdk --------- Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Vincent Dai <[email protected]> * [KeyVault] Added security domain properties into PSManagedHsm (#22540) * Refresh track 1 SDK * Added security domain properties into the output of New/Update/Get-AzKeyVaultManagedHsm (PSManagedHsm) * Refresh example * hibernate parameter for Stop-AzVmss (#22560) Co-authored-by: Theodore Chang <[email protected]> * Update PrLabeled.ps1 (#22553) * Adding XenonMV3 Support (#22530) * adding PremiumMV3 to Xenon list * updating changelog --------- Co-authored-by: Nalin Gaddis <[email protected]> * Upgraded vulnerable DLLs after upgrading PowerShell SDK (#22566) * Update New-AzVirtualNetworkSubnetConfig.md (#22561) `New-AzVirtualSubnetConfig` does not exists but `New-AzVirtualNetworkSubnetConfig` does. * Generate aks sdk with autorest.powershell (#22501) * Generate aks sdk with autorest.powershell * Suppress breaking changes caused by character case change * [KeyVault] Add live tests for MHSM Settings (#22570) * Add live tests for MHSM Settings * enable all test cases * [Config] add config to disable write error to file system (#22529) * disable error records persistence * add keys * upgrade common version * polish help message for 'DisableErrorRecordsPersistence' * Update src/Accounts/Authentication/Properties/Resources.resx Co-authored-by: Yeming Liu <[email protected]> * remove debug parameters for get/clear/update config * update environment variable name to AzPSDisableErrorRecordsPersistence --------- Co-authored-by: Yeming Liu <[email protected]> * Updated email notification to support multi-recipients (#22577) * Use autorest.powershell to generate AlertsManagement SDK to replace the track 1 SDK (#22579) * [Storage] Support encryption context property when creating a datalakegen2 item (#22563) * encryption context * Add changelog * update test dependency and help file * Add an example for encryption context * Migrate StackHCI from generation to main (#22588) * Move StackHCI to main * update changelog --------- Co-authored-by: YanaXu <[email protected]> * Support deployment stack object as input parameter for Save-Az*DeploymentStack and Remove-Az*DeploymentStack cmdlets (#22519) * implemented stack object parameter sets for save and remove cmdlets * adjust tests and session records * adjusted changelog to reflect changes * adjust testing formatting * updating help docs * update cmdlets and help docs for renamed parameter * update sessions record tests * Migrate DataMigration from generation to main (#22574) * Move DataMigration to main * update ChangeLog --------- Co-authored-by: YanaXu <[email protected]> * change breaking change info (#22571) * Fixed type conversion issue when sending email in live test (#22596) * Skip Accounts when run static analysis check in generation ci (#22597) * [HDInsight] Add warning message for break changes which plan to release in Nov. (#22578) * Update Azure.Core from 1.31.0 to 1.33.0 * replace models * Revert "replace models" This reverts commit d1a1de3. * add Warning message 1 * Update Azure.Core version to 1.34 * revert added package. * Update change log * Update changelog * move changelog to Upcoming release --------- Co-authored-by: v-yuchenli <[email protected]> * Update code-oob.yml for Azure Pipelines (#22591) * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * [KeyVault] Formatted the table view of outputs (#22580) * Formatted the table view of *-AzKeyVault, *-AzKeyVaultKey and *-AzKeyVaultSecret * format cert * reorg folder constructure * Update src/KeyVault/KeyVault.Test/UnitTests/SetKeyVaultSecretTests.cs * Update src/KeyVault/KeyVault.Test/UnitTests/RemoveKeyVaultSecretTests.cs * Update src/KeyVault/KeyVault/KeyVault.csproj * Update Maintenance ChangeLog.md (#22602) * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Skip Accounts when run static analysis check in generation ci (#22603) * Skip Accounts when run static analysis check in generation ci * Skip Accounts when run static analysis check in generation ci * Skip Accounts when run static analysis check in generation ci * Add SecurityType of Standard to VM and VMSS cmdlets for Trusted Launch, includes breaking changes (#22534) * initial dev * successful test 1 * vmss test and rest of dev * vmss with config test * vm with config test * tests fixed maybe 1 fails * static analysis * remove vmss validation * null check * changelog and help doc * constant values * clean * valids and clean * Update BreakingChangeIssues.csv * remove breaking * Update BreakingChangeIssues.csv * Sign old modules (#22609) * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Migrate SqlVirtualMachine from generation to main (#22608) * Move SqlVirtualMachine to main * update Changelog --------- Co-authored-by: YanaXu <[email protected]> * Migrate EventHub from generation to main (#22610) * Move EventHub to main * update ChangeLog --------- Co-authored-by: YanaXu <[email protected]> * Refill Credentials from AzKeyStore When Save AzContext (#22440) * Refill Credentials from AzKeyStore When Save AzContext fix #22355 * Address review comments * Address review comments * CosmosDB - New Restore Parameter (#22585) * restore new param public network access * minor fixes * test change * stable changes 1 * md param def changed * reverting test changes for build * restore ts * test and test recording * Migrate KeyVault from generation to main (#22621) * Move KeyVault to main * Update ChangeLog.md --------- Co-authored-by: Beisi Zhou <[email protected]> * FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#22343) * Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement Owners of the FabricBot configuration should have received email notification. The same information contained in the email is published internally at: https://aka.ms/gim/fabricbot. Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html Please review and merge this PR to complete the process of onboarding to the new service. * Deleting fabricbot.json * Update resourceManagement.yml --------- Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Vincent Dai <[email protected]> * [KeyVault] Update TestSetting.ps1 to run on one platform and latest powershell (#22618) * Update TestSetting.ps1 * Update KeyVault.sln * first set of changes * created initial powershell for ergwscale * edited changelog * update warning message (#22619) * Fix to only include non-empty ExtendedLocation (#22630) * Fix to only include non-empty ExtendedLocation * Updated ChangeLog.md * Remove PS 7.0 from smoke test (#22569) * Alias Set-AzConfig (#22629) * updated files due to failing test * formatting changes * formatting changes * Revert "formatting changes" This reverts commit d8900c5. * Revert " fixed merge issues" This reverts commit bc4af78, reversing changes made to d8900c5. * finished changes * formatting * formatting * formatting * edited ChangeLog * added empty line * added empty line between 6.1.1 and 6.1.0 --------- Co-authored-by: Azure PowerShell <[email protected]> Co-authored-by: NanxiangLiu <[email protected]> Co-authored-by: Yeming Liu <[email protected]> Co-authored-by: Yunchi Wang <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Saurav Raghuvanshi <[email protected]> Co-authored-by: YanaXu <[email protected]> Co-authored-by: Beisi Zhou <[email protected]> Co-authored-by: Andrey Goran <[email protected]> Co-authored-by: kevinzz6 <[email protected]> Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: Nalin Gaddis <[email protected]> Co-authored-by: Nalin Gaddis <[email protected]> Co-authored-by: Preston Alvarado <[email protected]> Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Yabo Hu <[email protected]> Co-authored-by: yifanz7 <[email protected]> Co-authored-by: Dante <[email protected]> Co-authored-by: yuc-Li <[email protected]> Co-authored-by: v-yuchenli <[email protected]> Co-authored-by: Adam Sandor <[email protected]> Co-authored-by: Jin Lei <[email protected]> Co-authored-by: mayankkatwal <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: myun12580 <[email protected]>

Theodore Chang added 2 commits May 19, 2023 14:35

add compute.sdk project reference

26ce1a9

add sdk folder

3b80b0e

grizzlytheodore requested review from bilaakpan-ms, Sandido and haagha as code owners May 30, 2023 13:37

grizzlytheodore added the Do Not Merge 🚫 label May 30, 2023

grizzlytheodore removed the Do Not Merge 🚫 label Jun 21, 2023

vidai-msft requested changes Jun 21, 2023

View reviewed changes

src/Compute/Compute.Sdk/README.md Outdated Show resolved Hide resolved

vidai-msft reviewed Jun 21, 2023

View reviewed changes

src/Compute/Compute.Sdk/Compute.Sdk.csproj Outdated Show resolved Hide resolved

vidai-msft requested changes Jun 23, 2023

View reviewed changes

src/Compute/Compute/Az.Compute.psd1 Outdated Show resolved Hide resolved

vidai-msft added the needs-revision label Jun 26, 2023

address comments

4b2e8c0

vidai-msft requested changes Jul 14, 2023

View reviewed changes

src/Compute/Compute.Sdk/README.md Outdated Show resolved Hide resolved

Theodore Chang added 2 commits July 17, 2023 17:24

update commit version to inputs

fa6d725

rename Compute.Sdk folder to Compute.Management.Sdk

8a2b4c4

resolve xmls, change compute.sdk reference to compute.management.sdk

89379bf

grizzlytheodore and others added 2 commits July 19, 2023 13:00

Merge branch 'main' into computeMigration

47f0dd1

remove SDK reference. generate track 1 with latest DiskRP version

31340d7

vidai-msft requested changes Jul 23, 2023

View reviewed changes

src/Compute/Compute.Management.Sdk/README.md Show resolved Hide resolved

grizzlytheodore and others added 2 commits July 24, 2023 16:12

Update src/Compute/Compute.Management.Sdk/README.md

e101b21

Co-authored-by: Vincent Dai <[email protected]>

fix autorest cmd

53a43d5

vidai-msft self-assigned this Aug 1, 2023

grizzlytheodore and others added 4 commits August 1, 2023 11:10

Merge branch 'main' into computeMigration

d7fc993

update autorest gen

f5ce7ee

Merge branch 'computeMigration' of https://github.com/Azure/azure-pow…

096e73a

…ershell into computeMigration

Update Compute.Management.Sdk.csproj

24cb389

vidai-msft requested changes Aug 8, 2023

View reviewed changes

src/Compute/Compute.Management.Sdk/Properties/AssemblyInfo.cs Outdated Show resolved Hide resolved

src/Compute/Compute.Management.Sdk/Properties/AssemblyInfo.cs Outdated Show resolved Hide resolved

grizzlytheodore and others added 4 commits August 12, 2023 18:20

Merge branch 'main' into computeMigration

a8cbe17

generated with latest swagger versions. 2023-04-02 diskRP 2023-07-01 CRP

8c757c3

Merge branch 'computeMigration' of https://github.com/Azure/azure-pow…

575a94b

…ershell into computeMigration

update assembly version of sdk

fe71648

vidai-msft approved these changes Aug 14, 2023

View reviewed changes

vidai-msft merged commit 1acc696 into main Aug 14, 2023

grizzlytheodore deleted the computeMigration branch September 29, 2023 19:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compute migration to track 1 deprecation #21949

Compute migration to track 1 deprecation #21949

grizzlytheodore commented May 30, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented May 30, 2023 •

edited

Loading

grizzlytheodore commented May 30, 2023

vidai-msft commented Jun 21, 2023

azure-pipelines bot commented Jun 21, 2023

vidai-msft commented Jun 23, 2023

grizzlytheodore commented Jun 26, 2023

grizzlytheodore commented Jul 12, 2023

vidai-msft commented Jul 14, 2023

grizzlytheodore commented Jul 17, 2023

vidai-msft commented Jul 18, 2023

grizzlytheodore commented Jul 18, 2023

grizzlytheodore commented Jul 22, 2023

vidai-msft commented Jul 23, 2023

vidai-msft commented Aug 8, 2023

vidai-msft left a comment

grizzlytheodore commented Aug 14, 2023

Compute migration to track 1 deprecation #21949

Compute migration to track 1 deprecation #21949

Conversation

grizzlytheodore commented May 30, 2023 • edited Loading

Description

Checklist

azure-client-tools-bot-prd bot commented May 30, 2023 • edited Loading

grizzlytheodore commented May 30, 2023

vidai-msft commented Jun 21, 2023

azure-pipelines bot commented Jun 21, 2023

vidai-msft commented Jun 23, 2023

grizzlytheodore commented Jun 26, 2023

grizzlytheodore commented Jul 12, 2023

vidai-msft commented Jul 14, 2023

grizzlytheodore commented Jul 17, 2023

vidai-msft commented Jul 18, 2023

grizzlytheodore commented Jul 18, 2023

grizzlytheodore commented Jul 22, 2023

vidai-msft commented Jul 23, 2023

vidai-msft commented Aug 8, 2023

vidai-msft left a comment

Choose a reason for hiding this comment

grizzlytheodore commented Aug 14, 2023

grizzlytheodore commented May 30, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented May 30, 2023 •

edited

Loading