-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CosmosDB - New Restore Parameter #22585
Conversation
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.CosmosDB
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.Resources
️✔️Az.Sql
️✔️Az.Storage
|
/azp run |
Hi @mayankkatwal , the CI checks are not successfully triggered. Could you push a new commit (edit a line or something else)? Let's see if it fixes the CI triggers. |
I have made a minor change to the PR and have removed a failing test file. The builds are all passing it seems. Could you please review the PR as is, and i will subsequently add the test changes. |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @mayankkatwal, the PR is clear now. Should I merge it or wait for your tests? |
@YanaXu |
@YanaXu, the test is uploaded with the recording. if the PR is good to be merged, you can do so. |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
* Bump up version for KeyVault (#22511) * Merge remote-tracking branch 'upstream/main' into lnx/azurecore (#22349) Co-authored-by: Yeming Liu <[email protected]> * Exclude the api-version in typename when checking the breaking change of cmdlet output (#22495) * Exclude the api-version in typename when checking the breaking change of cmdlet output * Rename the function * fix Get-AzVmRunCommand bug (#22460) * fix bug * changelog --------- Co-authored-by: Theodore Chang <[email protected]> * Add permission for pr-label github actions (#22481) * Add permission for pr-label github actions * Add permission for pr-label github actions * Add permission for pr-label github actions * Add permission for pr-label github actions * Update Remove-AzApiManagementApiFromGateway.md (#22505) Added the example of removing an API from a managed gateway. Users are not able to achieve it by following the first example and raising questions using support tickets. * Migrate StackHCI from generation to main (#22541) * Move StackHCI to main * udpate changelog --------- Co-authored-by: YanaXu <[email protected]> * [KeyVault] Support MHSM Settings (#22525) * wip * add update-azkeyvaultsetting and help docs * add example for settings * add change log * add live test * fix * fix * Migrate ContainerInstance from generation to main (#22537) * Move ContainerInstance to main * Create containerGroups-containers.json * Create containerGroups.json --------- Co-authored-by: Beisi Zhou <[email protected]> * Updated ChangeLog.md for Az.ContainerInstance (#22550) * Updated ChangeLog.md for Az.ContainerInstance * Update src/ContainerInstance/ChangeLog.md --------- Co-authored-by: Beisi Zhou <[email protected]> * [Synapse] Update artifact to 1.0.0-preview.18 (#22452) * update artifact to 18 * fix change log error * workaround the assembly loading issue (#22551) * [Compute] update sdk package reference for Compute (#22459) * update SDK reference * resolve breaking change * update package reference * breaking change mitigation * breaking change suppression * re-record ssh test with latest compute API call --------- Co-authored-by: Theodore Chang <[email protected]> * Bump up version for StackHCI (#22543) * Compute migration to track 1 deprecation (#21949) * add compute.sdk project reference * add sdk folder * address comments * update commit version to inputs * rename Compute.Sdk folder to Compute.Management.Sdk * resolve xmls, change compute.sdk reference to compute.management.sdk * remove SDK reference. generate track 1 with latest DiskRP version * Update src/Compute/Compute.Management.Sdk/README.md Co-authored-by: Vincent Dai <[email protected]> * fix autorest cmd * update autorest gen * Update Compute.Management.Sdk.csproj * generated with latest swagger versions. 2023-04-02 diskRP 2023-07-01 CRP * update assembly version of sdk --------- Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Vincent Dai <[email protected]> * [KeyVault] Added security domain properties into PSManagedHsm (#22540) * Refresh track 1 SDK * Added security domain properties into the output of New/Update/Get-AzKeyVaultManagedHsm (PSManagedHsm) * Refresh example * hibernate parameter for Stop-AzVmss (#22560) Co-authored-by: Theodore Chang <[email protected]> * Update PrLabeled.ps1 (#22553) * Adding XenonMV3 Support (#22530) * adding PremiumMV3 to Xenon list * updating changelog --------- Co-authored-by: Nalin Gaddis <[email protected]> * Upgraded vulnerable DLLs after upgrading PowerShell SDK (#22566) * Update New-AzVirtualNetworkSubnetConfig.md (#22561) `New-AzVirtualSubnetConfig` does not exists but `New-AzVirtualNetworkSubnetConfig` does. * Generate aks sdk with autorest.powershell (#22501) * Generate aks sdk with autorest.powershell * Suppress breaking changes caused by character case change * [KeyVault] Add live tests for MHSM Settings (#22570) * Add live tests for MHSM Settings * enable all test cases * [Config] add config to disable write error to file system (#22529) * disable error records persistence * add keys * upgrade common version * polish help message for 'DisableErrorRecordsPersistence' * Update src/Accounts/Authentication/Properties/Resources.resx Co-authored-by: Yeming Liu <[email protected]> * remove debug parameters for get/clear/update config * update environment variable name to AzPSDisableErrorRecordsPersistence --------- Co-authored-by: Yeming Liu <[email protected]> * Updated email notification to support multi-recipients (#22577) * Use autorest.powershell to generate AlertsManagement SDK to replace the track 1 SDK (#22579) * [Storage] Support encryption context property when creating a datalakegen2 item (#22563) * encryption context * Add changelog * update test dependency and help file * Add an example for encryption context * Migrate StackHCI from generation to main (#22588) * Move StackHCI to main * update changelog --------- Co-authored-by: YanaXu <[email protected]> * Support deployment stack object as input parameter for Save-Az*DeploymentStack and Remove-Az*DeploymentStack cmdlets (#22519) * implemented stack object parameter sets for save and remove cmdlets * adjust tests and session records * adjusted changelog to reflect changes * adjust testing formatting * updating help docs * update cmdlets and help docs for renamed parameter * update sessions record tests * Migrate DataMigration from generation to main (#22574) * Move DataMigration to main * update ChangeLog --------- Co-authored-by: YanaXu <[email protected]> * change breaking change info (#22571) * Fixed type conversion issue when sending email in live test (#22596) * Skip Accounts when run static analysis check in generation ci (#22597) * [HDInsight] Add warning message for break changes which plan to release in Nov. (#22578) * Update Azure.Core from 1.31.0 to 1.33.0 * replace models * Revert "replace models" This reverts commit d1a1de3. * add Warning message 1 * Update Azure.Core version to 1.34 * revert added package. * Update change log * Update changelog * move changelog to Upcoming release --------- Co-authored-by: v-yuchenli <[email protected]> * Update code-oob.yml for Azure Pipelines (#22591) * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * Update code-oob.yml for Azure Pipelines * [KeyVault] Formatted the table view of outputs (#22580) * Formatted the table view of *-AzKeyVault, *-AzKeyVaultKey and *-AzKeyVaultSecret * format cert * reorg folder constructure * Update src/KeyVault/KeyVault.Test/UnitTests/SetKeyVaultSecretTests.cs * Update src/KeyVault/KeyVault.Test/UnitTests/RemoveKeyVaultSecretTests.cs * Update src/KeyVault/KeyVault/KeyVault.csproj * Update Maintenance ChangeLog.md (#22602) * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Skip Accounts when run static analysis check in generation ci (#22603) * Skip Accounts when run static analysis check in generation ci * Skip Accounts when run static analysis check in generation ci * Skip Accounts when run static analysis check in generation ci * Add SecurityType of Standard to VM and VMSS cmdlets for Trusted Launch, includes breaking changes (#22534) * initial dev * successful test 1 * vmss test and rest of dev * vmss with config test * vm with config test * tests fixed maybe 1 fails * static analysis * remove vmss validation * null check * changelog and help doc * constant values * clean * valids and clean * Update BreakingChangeIssues.csv * remove breaking * Update BreakingChangeIssues.csv * Sign old modules (#22609) * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Migrate SqlVirtualMachine from generation to main (#22608) * Move SqlVirtualMachine to main * update Changelog --------- Co-authored-by: YanaXu <[email protected]> * Migrate EventHub from generation to main (#22610) * Move EventHub to main * update ChangeLog --------- Co-authored-by: YanaXu <[email protected]> * Refill Credentials from AzKeyStore When Save AzContext (#22440) * Refill Credentials from AzKeyStore When Save AzContext fix #22355 * Address review comments * Address review comments * CosmosDB - New Restore Parameter (#22585) * restore new param public network access * minor fixes * test change * stable changes 1 * md param def changed * reverting test changes for build * restore ts * test and test recording * Migrate KeyVault from generation to main (#22621) * Move KeyVault to main * Update ChangeLog.md --------- Co-authored-by: Beisi Zhou <[email protected]> * FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#22343) * Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement Owners of the FabricBot configuration should have received email notification. The same information contained in the email is published internally at: https://aka.ms/gim/fabricbot. Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html Please review and merge this PR to complete the process of onboarding to the new service. * Deleting fabricbot.json * Update resourceManagement.yml --------- Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Vincent Dai <[email protected]> * [KeyVault] Update TestSetting.ps1 to run on one platform and latest powershell (#22618) * Update TestSetting.ps1 * Update KeyVault.sln * first set of changes * created initial powershell for ergwscale * edited changelog * update warning message (#22619) * Fix to only include non-empty ExtendedLocation (#22630) * Fix to only include non-empty ExtendedLocation * Updated ChangeLog.md * Remove PS 7.0 from smoke test (#22569) * Alias Set-AzConfig (#22629) * updated files due to failing test * formatting changes * formatting changes * Revert "formatting changes" This reverts commit d8900c5. * Revert " fixed merge issues" This reverts commit bc4af78, reversing changes made to d8900c5. * finished changes * formatting * formatting * formatting * edited ChangeLog * added empty line * added empty line between 6.1.1 and 6.1.0 --------- Co-authored-by: Azure PowerShell <[email protected]> Co-authored-by: NanxiangLiu <[email protected]> Co-authored-by: Yeming Liu <[email protected]> Co-authored-by: Yunchi Wang <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Saurav Raghuvanshi <[email protected]> Co-authored-by: YanaXu <[email protected]> Co-authored-by: Beisi Zhou <[email protected]> Co-authored-by: Andrey Goran <[email protected]> Co-authored-by: kevinzz6 <[email protected]> Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: Nalin Gaddis <[email protected]> Co-authored-by: Nalin Gaddis <[email protected]> Co-authored-by: Preston Alvarado <[email protected]> Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Yabo Hu <[email protected]> Co-authored-by: yifanz7 <[email protected]> Co-authored-by: Dante <[email protected]> Co-authored-by: yuc-Li <[email protected]> Co-authored-by: v-yuchenli <[email protected]> Co-authored-by: Adam Sandor <[email protected]> Co-authored-by: Jin Lei <[email protected]> Co-authored-by: mayankkatwal <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: myun12580 <[email protected]>
* apply Az.CosmosDB-preview branch CosmosDB folder to this branch * Use autorest.powershell to generate management SDK for cosmosDB (#22413) * remove the custom code since character case change is not treated as a breaking change (#22500) * regen sdk * specify header type as string to fix build error * update autorest file to align with main; regen sdk * fix casing * [Cosmos DB] Powershell changes for 2023-03-15 stable API (#21990) * added tests for listconnectionstrings; updated changelog * add changes for list connection strings response * re-record test * update changelog * Add location api changes * Added test recording for location api * re-record tests * re-record tests * Revert "add changes for list connection strings response" This reverts commit ff3ef0a. * update changelog, update and re-record account tests --------- Co-authored-by: Udit Singh <[email protected]> * CosmosDB - New Restore Parameter (#22585) * restore new param public network access * minor fixes * test change * stable changes 1 * md param def changed * reverting test changes for build * restore ts * test and test recording * CosmosDB 2023-09-15 release (#22726) (#22953) * genrated changes * help and changelog and test case update * Powershell model changes for burst capacity * added customer managed key status to PSDatabaseAccountGetResults.cs * added recording for MongoOperationsTests and SqlOperationsTest * added recording for remaining tests * rerecorded failed tests * added changes in tests * Minimal Tls version for create and update * fixed build errors * updated tls version in test * updated commit id * MinimalTlsVersion to changelog * Update ChangeLog.md Added CustomerManagedKeyStatus to the Changelog * mask 'primaryReadOnlyMasterKey' and 'secondaryReadOnlyMasterKey' in recorded test * mask 'primaryMasterKey' and 'secondaryMasterKey' in recorded test * rerecorded account tests * rerecorded account tests * rerecorded Cassandra tests * re-recorded all but mongo and restore tests --------- Co-authored-by: Richa Sharma <[email protected]> Co-authored-by: Adrián Sibaja Retana <[email protected]> Co-authored-by: unknown <[email protected]> Co-authored-by: AdrianSibajaRetana <[email protected]> * [CosmosDB] GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin (#23666) * changes and generated code * update tests * update session records * update help files * update changelog * update session records * update TestUpdateCosmosDBAccountBackupPolicyToContinuous30Days session record * update session records * add notimestamp tests and update few old session records * regen sdk, fix build error * fix duplicate code * nit fix restore tests * re-record tests * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account (#21736) * Merge branch 'Az.CosmosDB-preview' of https://github.com/SrinikhilReddy/azure-powershell into features/users/nanarava/enablepmerge * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * Update src/CosmosDB/CosmosDB/ChangeLog.md Co-authored-by: Jin Lei <[email protected]> * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * Update ChangeLog.md Remove duplicate line * Resolve code comments. --------- Co-authored-by: Jin Lei <[email protected]> * Replace Start-Sleep with Start-TestSleep for all test cases (#23780) * re-record account test * fix typo * [Cosmos DB] Powershell changes for 2023-04-15 stable API (Continuous 7 GA) (#21685) * move to new swagger version and prereq * edit readme.md * manually generated from autorest * Continuous 7 days change * add 2 new test recordings * fix example issues * add all test recordings for RestoreTests suite * fix New-AzCosmosDBAccount.md * add almost all test recordings * add 4 more successful recordings. all working now * no examples * clean up help file * add output type to cmdlet * suppress errors for existing cmdlets * Revert "suppress errors for existing cmdlets" This reverts commit f36e275. * suppress static validation errors for existing commands --------- Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Udit Singh <[email protected]> Co-authored-by: mayankkatwal <[email protected]> Co-authored-by: Yabo Hu <[email protected]> Co-authored-by: Richa Sharma <[email protected]> Co-authored-by: Adrián Sibaja Retana <[email protected]> Co-authored-by: unknown <[email protected]> Co-authored-by: AdrianSibajaRetana <[email protected]> Co-authored-by: ddhamotharan <[email protected]> Co-authored-by: Srinikhil Naravamakula <[email protected]> Co-authored-by: Jin Lei <[email protected]> Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: vinhms <[email protected]>
Description
This is a very small change to allow users to pass in a flag (PublicNetworkAccess) to the restore powershell command. This flag will get propagated to the restore workflow and will restore the database account with either public network access as enabled or disabled. This new parameter has existed for some time as the provision database account ps command leverages the same. Therefore, no changes to any sdk is needed, thus making this a minor change.
This exact change has been a part of the cosmos db preview branch and opened to private customers for about 5 months. Since we want to open this to public, we are making changes to main.
Here is the preview change PR: #21464
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.