[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #11809

mrohera · 2020-11-25T00:27:43Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-11-25T00:27:46Z

Swagger Validation Report

️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2020-09-01-preview/iotdps.json <---> new: preview/2020-09-01-preview/iotdps.json

Rule	Message
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'identity' in response that was not found in the old version. New: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1973:7 Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1926:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'identity' in response that was not found in the old version. New: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1763:7 Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1763:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'identity' in response that was not found in the old version. New: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1763:7 Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1763:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'identity' in response that was not found in the old version. New: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1763:7 Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1763:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'identity' in response that was not found in the old version. New: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1763:7 Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1763:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'identity' in response that was not found in the old version. New: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1763:7 Old: Microsoft.Devices/preview/2020-09-01-preview/iotdps.json#L1763:7

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- deviceprovisioningservices/resource-manager/readme.md tag:package-preview-2020-09
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- deviceprovisioningservices/resource-manager/readme.md tag:package-preview-2020-09

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-11-25T00:27:46Z

Swagger Generation Artifacts

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 518a9a9. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/deviceprovisioningservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.DeviceProvisioningServices [View full logs] [Release SDK Changes]

cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/deviceprovisioningservices/Microsoft.Azure.Management.DeviceProvisioningServices/tests/ScenarioTests/DeviceProvisioningClientCertificates.cs(28,63): error CS1061: 'IotDpsClient' does not contain a definition for 'DpsCertificates' and no accessible extension method 'DpsCertificates' accepting a first argument of type 'IotDpsClient' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/deviceprovisioningservices/Microsoft.Azure.Management.DeviceProvisioningServices/tests/Microsoft.Azure.Management.DeviceProvisioningServices.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/deviceprovisioningservices/Microsoft.Azure.Management.DeviceProvisioningServices/tests/ScenarioTests/DeviceProvisioningClientCertificates.cs(49,59): error CS1061: 'IotDpsClient' does not contain a definition for 'DpsCertificates' and no accessible extension method 'DpsCertificates' accepting a first argument of type 'IotDpsClient' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/deviceprovisioningservices/Microsoft.Azure.Management.DeviceProvisioningServices/tests/Microsoft.Azure.Management.DeviceProvisioningServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/deviceprovisioningservices/Microsoft.Azure.Management.DeviceProvisioningServices/tests/ScenarioTests/DeviceProvisioningClientCertificates.cs(28,63): error CS1061: 'IotDpsClient' does not contain a definition for 'DpsCertificates' and no accessible extension method 'DpsCertificates' accepting a first argument of type 'IotDpsClient' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/deviceprovisioningservices/Microsoft.Azure.Management.DeviceProvisioningServices/tests/Microsoft.Azure.Management.DeviceProvisioningServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/deviceprovisioningservices/Microsoft.Azure.Management.DeviceProvisioningServices/tests/ScenarioTests/DeviceProvisioningClientCertificates.cs(49,59): error CS1061: 'IotDpsClient' does not contain a definition for 'DpsCertificates' and no accessible extension method 'DpsCertificates' accepting a first argument of type 'IotDpsClient' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/deviceprovisioningservices/Microsoft.Azure.Management.DeviceProvisioningServices/tests/Microsoft.Azure.Management.DeviceProvisioningServices.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 518a9a9. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/deviceprovisioningservices/resource-manager/readme.md

️✔️azure-mgmt-iothubprovisioningservices [View full logs] [Release SDK Changes]

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-iothubprovisioningservices
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-iothubprovisioningservices
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.iothubprovisioningservices
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.iothubprovisioningservices
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.iothubprovisioningservices
cmderr	[changelogReport] INFO:__main__:Report written to sdk/iothub/azure-mgmt-iothubprovisioningservices/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-iothubprovisioningservices on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.2.0 of azure-mgmt-iothubprovisioningservices in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.iothubprovisioningservices
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.iothubprovisioningservices
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.iothubprovisioningservices
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/iothub/azure-mgmt-iothubprovisioningservices/code_reports/0.2.0/report.json
cmdout	[Changelog] Size of delta 34.245% size of original (original: 26156 chars, delta: 8957 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model IotDpsPropertiesDescription has a new parameter public_network_access
cmdout	[Changelog]   - Model IotDpsPropertiesDescription has a new parameter encryption
cmdout	[Changelog]   - Model IotDpsPropertiesDescription has a new parameter private_endpoint_connections
cmdout	[Changelog]   - Model IotDpsPropertiesDescription has a new parameter ip_filter_rules
cmdout	[Changelog]   - Model ProvisioningServiceDescription has a new parameter identity
cmdout	[Changelog]   - Added operation IotDpsResourceOperations.get_private_endpoint_connection
cmdout	[Changelog]   - Added operation IotDpsResourceOperations.delete_private_endpoint_connection
cmdout	[Changelog]   - Added operation IotDpsResourceOperations.list_private_endpoint_connections
cmdout	[Changelog]   - Added operation IotDpsResourceOperations.create_or_update_private_endpoint_connection
cmdout	[Changelog]   - Added operation IotDpsResourceOperations.get_private_link_resources
cmdout	[Changelog]   - Added operation IotDpsResourceOperations.list_private_link_resources

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 518a9a9. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2020-12-12 01:26:51 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-deviceprovisioningservices"
cmderr	[generate.py] 2020-12-12 01:26:51 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2020-12-12 01:26:51 INFO autorest --version=3.0.6327 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/deviceprovisioningservices/azure-resourcemanager-deviceprovisioningservices --java.namespace=com.azure.resourcemanager.deviceprovisioningservices  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/deviceprovisioningservices/resource-manager/readme.md
cmderr	[generate.py] 2020-12-12 01:27:29 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2020-12-12 01:27:29 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2020-12-12 01:27:29 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2020-12-12 01:27:29 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2020-12-12 01:27:29 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2020-12-12 01:28:15 ERROR [GENERATE] Maven build fail

️✔️azure-resourcemanager-deviceprovisioningservices [View full logs] [Release SDK Changes]

cmderr	[Inst] 2020-12-12 01:29:09 DEBUG Got artifact_id: azure-resourcemanager-deviceprovisioningservices
cmderr	[Inst] 2020-12-12 01:29:09 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2020-12-12 01:29:09 DEBUG Got artifact: azure-resourcemanager-deviceprovisioningservices-1.0.0-beta.1.jar
cmderr	[Inst] 2020-12-12 01:29:09 DEBUG Match jar package: azure-resourcemanager-deviceprovisioningservices-1.0.0-beta.1.jar
cmderr	[Inst] 2020-12-12 01:29:09 DEBUG output: {"full": "curl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/11809/azure-sdk-for-java/azure-resourcemanager-deviceprovisioningservices/azure-resourcemanager-deviceprovisioningservices-1.0.0-beta.1.jar\" -o azure-resourcemanager-deviceprovisioningservices-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-deviceprovisioningservices -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-deviceprovisioningservices-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true\n"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 518a9a9. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️provisioningservices/mgmt/2018-01-22/iothub [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️provisioningservices/mgmt/2017-11-15/iothub [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/provisioningservices/mgmt/2017-08-21-preview/iothub [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 518a9a9. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/deviceprovisioningservices/resource-manager/readme.md

️✔️@azure/arm-deviceprovisioningservices [View full logs] [Release SDK Changes]

azure-arm-deviceprovisioningservices-2.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/iotDpsClient.js → ./dist/arm-deviceprovisioningservices.js...
cmderr	[npmPack] created ./dist/arm-deviceprovisioningservices.js in 328ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 518a9a9. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/deviceprovisioningservices/resource-manager/readme.md

️✔️deviceprovisioningservices [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  [email protected] No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  ELIFECYCLE
cmderr	[resource-manager] npm ERR! errno 31
cmderr	[resource-manager] npm ERR! [email protected] test: `mocha -r ts-node/register tests.ts`
cmderr	[resource-manager] npm ERR! Exit status 31
cmderr	[resource-manager] npm ERR!
cmderr	[resource-manager] npm ERR! Failed at the [email protected] test script.
cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
cmderr	[resource-manager] npm ERR! A complete log of this run can be found in:
cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2020-12-12T01_27_07_247Z-debug.log
cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
cmderr	[resource-manager]   status: 31,
cmderr	[resource-manager]   signal: null,
cmderr	[resource-manager]   output: [ null, null, null ],
cmderr	[resource-manager]   pid: 3163,
cmderr	[resource-manager]   stdout: null,
cmderr	[resource-manager]   stderr: null
cmderr	[resource-manager] }

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2020-11-25T00:43:58Z

Hi, @mrohera Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

mrohera · 2020-11-25T00:55:57Z

@xccc-msft this is a preview version in support of a feature that is still in development hence the "breaking change".

...ovisioningservices/resource-manager/Microsoft.Devices/preview/2020-09-01-preview/iotdps.json

openapi-workflow-bot · 2020-11-25T04:13:40Z

Hi @mrohera, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

xseeseesee · 2020-11-25T04:14:32Z

@mrohera I'm unable to merge as CI failure after breaking change detection. Just added the related label.

mrohera · 2020-11-25T10:33:01Z

@xccc-msft I have created the case per the workflow instructions. Please have a look. Thanks.

mrohera · 2020-11-26T06:31:33Z

Any update on the approval?

xseeseesee · 2020-11-26T07:20:47Z

@mrohera I'm not reviewer for breaking change. We have to wait for the approval. Thanks.

xseeseesee · 2020-12-01T05:09:10Z

...ovisioningservices/resource-manager/Microsoft.Devices/preview/2020-09-01-preview/iotdps.json

@@ -1,7 +1,7 @@
 {
  "swagger": "2.0",
  "info": {
-    "version": "2020-09-01-preview",
+    "version": "2020-09-01-preview.1",


Is it valid to change version like this?
cc: @akning-ms

I was given f/b that this is the guideline in order to make changes to an API that is still in development. I am checking with the approver and sharing the failure seen below.

I've removed this version change since I added more changes and wanted the validations to re-run. I do not have clarity on what direction to proceed since the tests fail if this requirement were to be enforced.

mrohera · 2020-12-09T13:02:27Z

Closing PR in favor of another PR with a new directory structure.

mrohera · 2020-12-09T13:16:14Z

This is the follow up PR: #12036

mrohera · 2020-12-10T18:02:46Z

Re-opening this PR since ARM does not support "preview.1" style APIs.

…review/2020-09-01-preview (Azure#11809) * Support userassigned identities for the KEK * Address PR comments * Update rev for breaking changes * Add identity information to the DPS description * Revert back version * Lint warnings

Support userassigned identities for the KEK

59d5e39

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 25, 2020

openapi-sdkautomation bot mentioned this pull request Nov 25, 2020

[AutoPR Microsoft.Azure.Management.DeviceProvisioningServices] [Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview AzureSDKAutomation/azure-sdk-for-net#2422

Closed

mrohera marked this pull request as ready for review November 25, 2020 00:41

openapi-assignment-bot bot assigned xseeseesee Nov 25, 2020

xseeseesee reviewed Nov 25, 2020

View reviewed changes

...ovisioningservices/resource-manager/Microsoft.Devices/preview/2020-09-01-preview/iotdps.json Outdated Show resolved Hide resolved

Address PR comments

913c77f

xseeseesee approved these changes Nov 25, 2020

View reviewed changes

xseeseesee added the BreakingChangeReviewRequired label Nov 25, 2020

Update rev for breaking changes

8d6108c

xseeseesee reviewed Dec 1, 2020

View reviewed changes

mrohera added 2 commits December 3, 2020 22:27

Add identity information to the DPS description

46d9c90

Revert back version

431b62f

openapi-pipeline-app bot removed the CI-BreakingChange-Go label Dec 4, 2020

Lint warnings

ecdb59a

mrohera assigned timjl Dec 4, 2020

mrohera closed this Dec 9, 2020

mrohera deleted the dev-deviceprovisioningservices-Microsoft.Devices-2020-09-01-preview-1 branch December 9, 2020 13:02

akning-ms mentioned this pull request Dec 10, 2020

[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #12036

Closed

25 tasks

mrohera restored the dev-deviceprovisioningservices-Microsoft.Devices-2020-09-01-preview-1 branch December 10, 2020 16:26

mrohera reopened this Dec 10, 2020

openapi-sdkautomation bot mentioned this pull request Dec 10, 2020

[AutoPR azure-resourcemanager-deviceprovisioningservices] [Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview AzureSDKAutomation/azure-sdk-for-java#6956

Closed

mrohera requested a review from JeffreyRichter December 10, 2020 19:42

JeffreyRichter approved these changes Dec 11, 2020

View reviewed changes

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 11, 2020

akning-ms merged commit 518a9a9 into Azure:master Dec 12, 2020

mrohera deleted the dev-deviceprovisioningservices-Microsoft.Devices-2020-09-01-preview-1 branch December 12, 2020 01:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #11809

[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #11809

mrohera commented Nov 25, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 25, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 25, 2020 •

edited

Loading

openapi-workflow-bot bot commented Nov 25, 2020

mrohera commented Nov 25, 2020

openapi-workflow-bot bot commented Nov 25, 2020

xseeseesee commented Nov 25, 2020

mrohera commented Nov 25, 2020

mrohera commented Nov 26, 2020

xseeseesee commented Nov 26, 2020

xseeseesee Dec 1, 2020

mrohera Dec 1, 2020

mrohera Dec 4, 2020

mrohera commented Dec 9, 2020

mrohera commented Dec 9, 2020

mrohera commented Dec 10, 2020

[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #11809

[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #11809

Conversation

mrohera commented Nov 25, 2020 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Nov 25, 2020 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 25, 2020 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Nov 25, 2020

mrohera commented Nov 25, 2020

openapi-workflow-bot bot commented Nov 25, 2020

xseeseesee commented Nov 25, 2020

mrohera commented Nov 25, 2020

mrohera commented Nov 26, 2020

xseeseesee commented Nov 26, 2020

xseeseesee Dec 1, 2020

Choose a reason for hiding this comment

mrohera Dec 1, 2020

Choose a reason for hiding this comment

mrohera Dec 4, 2020

Choose a reason for hiding this comment

mrohera commented Dec 9, 2020

mrohera commented Dec 9, 2020

mrohera commented Dec 10, 2020

mrohera commented Nov 25, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 25, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 25, 2020 •

edited

Loading