Adding data factory CRUD scenario test #3774

bgold09 · 2017-10-11T18:57:08Z

Description

Adding data factory CRUD scenario test

This is the first batch of scenario tests for the ADF V2 SDK.
Partially addresses Re-record test using latest resource manager #3726; more tests need to be added

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

bgold09 · 2017-10-11T18:58:11Z

@shahabhijeet can you take a look at this? This is the first cut of scenario tests for the ADF V2 SDK. I wanted to see if the approach looked correct before continuing on with adding more. Thanks!

hvermis

🕐

hvermis

hvermis · 2017-10-11T20:30:19Z

src/SDKs/DataFactory/DataFactory.Tests/ScenarioTests/DataFactoryScenarioTests.cs

+
+            Action<DataFactoryManagementClient> action = (client) =>
+            {
+                // create


// create [](start = 16, length = 9)

Minor comment - not a fan of comments in the code, it is self explanatory

removed; these were originally comments for myself as I was creating the test

* This is the first batch of scenario tests for the ADF V2 SDK. * Partially addresses #3726; more tests need to be added

shahabhijeet · 2017-10-13T16:54:18Z

src/SDKs/DataFactory/DataFactory.Tests/ScenarioTests/DataFactoryScenarioTests.cs

+    public class DataFactoryScenarioTests : ScenarioTestBase<DataFactoryScenarioTests>
+    {
+        [Fact]
+        [Trait(TraitName.TestType, TestType.Scenario)]


@bgold09 just FYI, we have not started using traits in SDK tests yet. All tests are executed as of now. But if you would like to categorize tests, go ahead do it. But please be aware the categories can be different when we introduce categories for the entire repo.

sounds good, we were using these only for organizational purposes within our own test project

bgold09 · 2017-10-13T17:02:47Z

@shahabhijeet is this enough coverage of scenario tests to unblock new code changes being merged? We plan to add more to get proper coverage in the coming weeks, but I was interested in knowing if this is acceptable for the time being. New features (like in PR #3757) should come in with new coverage and we will still need to go back and add tests for things that are already in the repo now

shahabhijeet

See FYI in comments

* Regenerate SDK for new added api key management swagger spec (#3767) * Generate .NET SDK for application insights * update assembly version * address code review feedback * address code review feedback * regenerate sdk for adding management api keys functions * remove local used LaunchSettings.json file * generate from the pulic swagger * increase version in csproj file * Update Batch changelog to have a clearer format (#3775) * Removing build tools outside of branches (#3780) * Moving old files which are not used anymore to legacy directory * Separate build tools from branch. Moving forward build tools will be downloaded from a central location, this helps in propogating build changes to any branch dynamically. After this change build process on a new machine or fresh install will be a two step process. First download the build tools by executing msbuild build.proj and once it finishes, then execute whatever target you need to do e.g. msbuild build.proj /t:RunTests /p:Scope=SDKs\Compute. After downloading all build related assets will be downloaded under <root>\tools\SdkBuildTools. Moving bunch of legacy code to legacy directory. Removing build tasks out of this branch, currently being moved to legacy directory * Update README.md Updating readme to document recent build changes that were done to extract build tools out of main branch. * Adding data factory CRUD scenario test (#3774) * This is the first batch of scenario tests for the ADF V2 SDK. * Partially addresses #3726; more tests need to be added * Update Batch supporting assemblies (#3794) * [ADLA] - Update changelog for version 3.0.2 (#3792) * Merge from private Networking (#3771) * Regenerated Networking SDK on 2017-09-01, private * Expose new operation for VpnDeviceConfiguration for Vpn Gateways * Adding AzureReachabilityReport and AvailableProvidersList APIs + tests * Updating version of Network SDK * Disabling tests for AzureReachabilityReport and AvailableProvidersList APIs * Updated version * Caa record support in Azure DNS (#3785) * upgrade .net.test.sk project to stable version * support for CAA records * changing assembly file version to reflect nuget version * update swagger from public repo * addressing code review comments * bumping up assembly verson to 2.0.0.0 * [ADLA - ADLS] - [HOTFIX] - Update changelog (#3802) * [ADLA] - Update changelog for version 3.0.2 * [ADLA] - Update changelog * [ADLS] - Update changelog * Update changelog * 3.0.1 for ADLA was never published to nuget * 2.2.1 for ADLS was never published to nuget * Adding .NET SDK changes for Server DNS Aliasing (#3803) * Auto generated files for .NET SDK for Server DNS Aliasing. Also contains removing unused declarations from bunch of files. Everything generated automatically * Adding tests for server dns aliasing and their recording * Fixing sql_resource_manager.txt * Updating new version of SDK in AssemblyInfo.cs and csproj file * Small cosmetic changes to address Jared * Revert "Small cosmetic changes to address Jared" This reverts commit 5a5e426. * Reverting version change in project and AssemblyInfo files; addressing small change requests from Jared in pull request * [ACR] Update SDK to 2017-10-01 version (#3778) * Update ACR SDK to 2017-10-01 version * Update csproj, re-record tests * Address PR review feedback Address PR review feedback * Fix issue with missing Unit enumeration values, fix documentation issues, improved tests for multi-dim metrics API (#3809) * [Monitor] Fixing doc issues, adding two values to the metric unit enumeration, generating metadata files * Increasing version number due to a bug fix and documentation updates * [Monitor] Adding multi-dimensional metrics tests * Re-generate SDKs/Resource (#3793) * Updated Network SDK version (#3814) * Added Zone Redundant Property To Database, Elastic Pool and Edition Capability (#3800) * Add zone redundant property for database, elastic pool and capability edition * Added zone redundant property release notes * Revert "Removing build tools outside of branches (#3780)" This reverts commit deceaf3. * Revert "Revert "Removing build tools outside of branches (#3780)"" This reverts commit 58265b9. * Rerun tests to fix validation errors * Remove null capability test * Cancel pipeline run (#3812) * Cancel pipeline run api * Makin cancel run to factory operation * Example and unit test for cancel pipeline run api. * Regenerating SDK accoring to latest instructions * Scenario test for cancel run api * Scenario test for pipeline run 2 * Regenerating SDK and adding text file with generation metadata * Adding version 0.2.1 * Merged ADMS changes for Oct. SDK release * Add linked service scenario test (resolves #3726) (#3798) * Adds a simple CRUD test for linked services * Also change all tests to check for proper HTTP response codes on each API call * Resolves #3726 * Updated RecoveryServices.Backup Tests (#3822) - Updated tests to address Azure/azure-sdk-for-python#1422 - Updated test settings (VM name etc) for Backup tests and re-recorded tests

* This is the first batch of scenario tests for the ADF V2 SDK. * Partially addresses Azure#3726; more tests need to be added

hvermis requested changes Oct 11, 2017

View reviewed changes

hvermis approved these changes Oct 11, 2017

View reviewed changes

hvermis reviewed Oct 11, 2017

View reviewed changes

bgold09 and others added 2 commits October 11, 2017 13:34

Adding data factory CRUD scenario test

f1e6944

* This is the first batch of scenario tests for the ADF V2 SDK. * Partially addresses #3726; more tests need to be added

Merge branch 'psSdkJson6' into scenarioTests

99fa4c7

shahabhijeet approved these changes Oct 13, 2017

View reviewed changes

shahabhijeet merged commit 2ffd522 into Azure:psSdkJson6 Oct 13, 2017

shahabhijeet reviewed Oct 13, 2017

View reviewed changes

bgold09 mentioned this pull request Oct 23, 2017

Add linked service scenario test (resolves #3726) #3798

Merged

8 tasks

bgold09 deleted the scenarioTests branch November 1, 2017 17:21

snyk-bot mentioned this pull request Nov 18, 2022

[Snyk] Upgrade @cspell/cspell-bundled-dicts from 5.21.2 to 6.13.1 akasya-alisveris-merkezleri/azure-sdk-for-net#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding data factory CRUD scenario test #3774

Adding data factory CRUD scenario test #3774

bgold09 commented Oct 11, 2017 •

edited

Loading

bgold09 commented Oct 11, 2017

hvermis left a comment

hvermis left a comment

hvermis Oct 11, 2017

bgold09 Oct 11, 2017

shahabhijeet Oct 13, 2017

bgold09 Oct 13, 2017

bgold09 commented Oct 13, 2017

shahabhijeet left a comment

Adding data factory CRUD scenario test #3774

Adding data factory CRUD scenario test #3774

Conversation

bgold09 commented Oct 11, 2017 • edited Loading

Description

General Guidelines

Testing Guidelines

SDK Generation Guidelines

bgold09 commented Oct 11, 2017

hvermis left a comment

Choose a reason for hiding this comment

hvermis left a comment

Choose a reason for hiding this comment

hvermis Oct 11, 2017

Choose a reason for hiding this comment

bgold09 Oct 11, 2017

Choose a reason for hiding this comment

shahabhijeet Oct 13, 2017

Choose a reason for hiding this comment

bgold09 Oct 13, 2017

Choose a reason for hiding this comment

bgold09 commented Oct 13, 2017

shahabhijeet left a comment

Choose a reason for hiding this comment

bgold09 commented Oct 11, 2017 •

edited

Loading