Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linked service scenario test (resolves #3726) #3798

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Add linked service scenario test (resolves #3726) #3798

merged 1 commit into from
Oct 31, 2017

Conversation

bgold09
Copy link
Member

@bgold09 bgold09 commented Oct 18, 2017 •
edited
Loading

Description

Add linked service scenario test (resolves #3726)

  • Adds a simple CRUD test for linked services
  • Also change all tests to check for proper HTTP response codes on
    each API call

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@bgold09
Copy link
Member Author

bgold09 commented Oct 20, 2017

@shahabhijeet can you take a look at this when you can? thanks!

shahabhijeet
shahabhijeet suggested changes Oct 23, 2017
View reviewed changes
Copy link
Member

@shahabhijeet shahabhijeet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgold09 use the latest Resource Manager nuget 1.6.0 (at least) in your test csproj to record all your tests.

@bgold09
Copy link
Member Author

bgold09 commented Oct 23, 2017 •
edited
Loading

@shahabhijeet this was done with version 1.7.2, what do you mean? Are you talking about the version of the test framework?

This was done the same way as PR #3774 which you approved before

@bgold09
Add linked service scenario test (resolves #3726)
3c964a3 
  * Adds a simple CRUD test for linked services
  * Also change all tests to check for proper HTTP response codes on
    each API call
  * Resolves #3726
@bgold09
Copy link
Member Author

bgold09 commented Oct 30, 2017

@cormacpayne since @shahabhijeet is still out, can you take a look at this?

@shahabhijeet
Copy link
Member

shahabhijeet commented Oct 31, 2017 •
edited
Loading

@bgold09 if you look at PR #3774 I don't have your test.csproj as part of the PR, so I am not sure how can I flag this inconsistency?
The point is, you are using a really old version of resource manager and I think you should make a call if you want to test your resources using 1.1.0 (which was simply a repackaging of 1.0.0 version) which was published in April 2016
Also something that was approved earlier, does not mean it cannot be flagged later on, it simply means I need to be better at flagging these things in a PR, so this is on me and not your fault and as I said, as the csproj was not part of #3774 I did not see this for your test project.

@shahabhijeet shahabhijeet merged commit d216040 into Azure:psSdkJson6 Oct 31, 2017
@bgold09
Copy link
Member Author

bgold09 commented Oct 31, 2017

discussed offline, we're going to bump the version of Microsoft.Azure.ResourceManager being used in the tests

@bgold09 bgold09 deleted the linkedServiceTests branch October 31, 2017 23:04
shahabhijeet added a commit that referenced this pull request Nov 2, 2017
@shahabhijeet
Merge psSdkJson6 to SdkBuildTools (#3831)
d361cc4 
* Regenerate SDK for new added api key management swagger spec (#3767)

* Generate .NET SDK for application insights

* update assembly version

* address code review feedback

* address code review feedback

* regenerate sdk for adding management api keys functions

* remove local used LaunchSettings.json file

* generate from the pulic swagger

* increase version in csproj file

* Update Batch changelog to have a clearer format (#3775)

* Removing build tools outside of branches (#3780)

* Moving old files which are not used anymore to legacy directory

* Separate build tools from branch. Moving forward build tools will be downloaded from a central location, this helps in propogating build changes to any branch dynamically. After this change build process on a new machine or fresh install will be a two step process. First download the build tools by executing msbuild build.proj and once it finishes, then execute whatever target you need to do e.g. msbuild build.proj /t:RunTests /p:Scope=SDKs\Compute. After downloading all build related assets will be downloaded under <root>\tools\SdkBuildTools. Moving bunch of legacy code to legacy directory. Removing build tasks out of this branch, currently being moved to legacy directory

* Update README.md

Updating readme to document recent build changes that were done to extract build tools out of main branch.

* Adding data factory CRUD scenario test (#3774)

* This is the first batch of scenario tests for the ADF V2 SDK.
  * Partially addresses #3726; more tests need to be added

* Update Batch supporting assemblies (#3794)

* [ADLA] - Update changelog for version 3.0.2 (#3792)

* Merge from private Networking (#3771)

* Regenerated Networking SDK on 2017-09-01, private

* Expose new operation for VpnDeviceConfiguration for Vpn Gateways

* Adding AzureReachabilityReport and AvailableProvidersList APIs + tests

* Updating version of Network SDK

* Disabling tests for AzureReachabilityReport and AvailableProvidersList APIs

* Updated version

* Caa record support in Azure DNS (#3785)

* upgrade .net.test.sk project to stable version

* support for CAA records

* changing assembly file version to reflect nuget version

* update swagger from public repo

* addressing code review comments

* bumping up assembly verson to 2.0.0.0

* [ADLA - ADLS] - [HOTFIX] - Update changelog (#3802)

* [ADLA] - Update changelog for version 3.0.2

* [ADLA] - Update changelog

* [ADLS] - Update changelog

* Update changelog

* 3.0.1 for ADLA was never published to nuget

* 2.2.1 for ADLS was never published to nuget

* Adding .NET SDK changes for Server DNS Aliasing (#3803)

* Auto generated files for .NET SDK for Server DNS Aliasing. Also contains removing unused declarations from bunch of files. Everything generated automatically

* Adding tests for server dns aliasing and their recording

* Fixing sql_resource_manager.txt

* Updating new version of SDK in AssemblyInfo.cs and csproj file

* Small cosmetic changes to address Jared

* Revert "Small cosmetic changes to address Jared"

This reverts commit 5a5e426.

* Reverting version change in project and AssemblyInfo files; addressing small change requests from Jared in pull request

* [ACR] Update SDK to 2017-10-01 version (#3778)

* Update ACR SDK to 2017-10-01 version

* Update csproj, re-record tests

* Address PR review feedback

Address PR review feedback

* Fix issue with missing Unit enumeration values, fix documentation issues, improved tests for multi-dim metrics API (#3809)

* [Monitor] Fixing doc issues, adding two values to the metric unit enumeration, generating metadata files

* Increasing version number due to a bug fix and documentation updates

* [Monitor] Adding multi-dimensional metrics tests

* Re-generate SDKs/Resource (#3793)

* Updated Network SDK version (#3814)

* Added Zone Redundant Property To Database, Elastic Pool and Edition Capability (#3800)

* Add zone redundant property for database, elastic pool and capability edition

* Added zone redundant property release notes

* Revert "Removing build tools outside of branches (#3780)"

This reverts commit deceaf3.

* Revert "Revert "Removing build tools outside of branches (#3780)""

This reverts commit 58265b9.

* Rerun tests to fix validation errors

* Remove null capability test

* Cancel pipeline run (#3812)

* Cancel pipeline run api

* Makin cancel run to factory operation

* Example and unit test for cancel pipeline run api.

* Regenerating SDK accoring to latest instructions

* Scenario test for cancel run api

* Scenario test for pipeline run 2

* Regenerating SDK and adding text file with generation metadata

* Adding version 0.2.1

* Merged ADMS changes for Oct. SDK release

* Add linked service scenario test (resolves #3726) (#3798)

* Adds a simple CRUD test for linked services
  * Also change all tests to check for proper HTTP response codes on
    each API call
  * Resolves #3726

* Updated RecoveryServices.Backup Tests (#3822)

- Updated tests to address Azure/azure-sdk-for-python#1422
- Updated test settings (VM name etc) for Backup tests and re-recorded
tests
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
@bgold09 @JasonYang-MSFT
Add linked service scenario test (resolves Azure#3726) (Azure#3798)
e871dc7 
* Adds a simple CRUD test for linked services
  * Also change all tests to check for proper HTTP response codes on
    each API call
  * Resolves Azure#3726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgold09 @shahabhijeet