[ACR] Update SDK to 2017-10-01 version #3778

djyou · 2017-10-12T21:07:19Z

Generated from swagger spec https://github.com/Azure/azure-rest-api-specs/blob/current/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/2017-10-01/containerregistry.json

Added support for managed registries that can be created with Basic, Standard, Premium SKU.
Bring your own storage registries can still be created with Classic SKU.
Added support for webhooks and replications.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

djyou · 2017-10-12T22:03:31Z

/cc @sajayantony

shahabhijeet · 2017-10-13T06:39:37Z

@azuresdkci test this please

shahabhijeet · 2017-10-13T17:05:41Z

src/SDKs/ContainerRegistry/ContainerRegistry.Tests/ContainerRegistry.Tests.csproj

@@ -12,9 +12,9 @@
  </PropertyGroup>

  <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.Storage" Version="[5.0.2-preview,6.0)" />
+    <PackageReference Include="Microsoft.Azure.Management.Storage" Version="[6.0.0-preview,7.0)" />


@djyou please add reference to the latest version of resource manager nuget package and re-record all your test using the latest version of resource manager.

shahabhijeet · 2017-10-13T17:06:27Z

src/SDKs/ContainerRegistry/ContainerRegistry.Tests/Helpers/ContainerRegistryTestUtilities.cs

-using System;
-using System.Linq;
-using System.Collections.Generic;
+using Microsoft.Azure.Management.ContainerRegistry;


@djyou sort and remove unused usings

This is already sorted and cleaned as per VS2017, or is there a different schema SDK uses?

shahabhijeet · 2017-10-13T17:08:05Z

...nerRegistry/Management.ContainerRegistry/Microsoft.Azure.Management.ContainerRegistry.csproj

@@ -2,7 +2,7 @@
  <Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.reference.props'))" />
  <PropertyGroup>
    <Description>Microsoft Azure Container Registry Management Library</Description>
-    <VersionPrefix>1.1.0-preview</VersionPrefix>
+    <VersionPrefix>2.0.2</VersionPrefix>
    <AssemblyName>Microsoft.Azure.Management.ContainerRegistry</AssemblyName>
    <!--<Authors>Microsoft</Authors>


@djyou remove commented code
Model your csproj file using SDKs\BatchAI csproj
Also add PackageReleaseNotes

shahabhijeet · 2017-10-16T18:38:10Z

src/SDKs/ContainerRegistry/ContainerRegistry.Tests/ContainerRegistry.Tests.csproj

-    <PackageReference Include="Microsoft.Azure.Management.Storage" Version="[5.0.2-preview,6.0)" />
-
-    <!--<PackageReference Include="Microsoft.Azure.Management.ContainerRegistry" Version="1.2.0-preview" />-->
+    <PackageReference Include="Microsoft.Azure.Management.Storage" Version="[7.0.0-preview,7.0)" />


@djyou you should be using latest version of Resource Manager 1.6.0 at least or the latests version to record all your tests.
So sorry to remind you in my earlier iteration of code review.
You are still using 1.1.0 version which is very old and should not be used to create your resources.

I was confused with the comment actually. Did you mean we should add reference to Resource Manager 1.6.0 because currently it's not in csproj file?

shahabhijeet · 2017-10-16T18:39:39Z

src/SDKs/ContainerRegistry/Management.ContainerRegistry/Properties/AssemblyInfo.cs

-[assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.2.0.0")]
+[assembly: AssemblyVersion("2.0.0.0")]
+[assembly: AssemblyFileVersion("2.0.2.0")]


@djyou any reason you are going from 1.2 to 2.0.2?
Why 2.0.2 and not 2.0.0?

We had generated private release packages with 2.0.0 and 2.0.1 so this one will jump to 2.0.2.

@djyou if you create private release package for 2.0.0 and 2.0.1 where is the code for it?
Don't you have to merge the code for it?

It was from the previous closed PR.

My understanding from the SDK team is that the private SDK package can be generated from any fork or branch and used internally or testing. Versions 2.0.0 and 2.0.1 were already used so a version increment is natural here.

djyou · 2017-10-16T23:03:07Z

@shahabhijeet Can you please clarify the above issues so we can get them fixed and have this SDK merged and released? Thanks.

Address PR review feedback

* Regenerate SDK for new added api key management swagger spec (#3767) * Generate .NET SDK for application insights * update assembly version * address code review feedback * address code review feedback * regenerate sdk for adding management api keys functions * remove local used LaunchSettings.json file * generate from the pulic swagger * increase version in csproj file * Update Batch changelog to have a clearer format (#3775) * Removing build tools outside of branches (#3780) * Moving old files which are not used anymore to legacy directory * Separate build tools from branch. Moving forward build tools will be downloaded from a central location, this helps in propogating build changes to any branch dynamically. After this change build process on a new machine or fresh install will be a two step process. First download the build tools by executing msbuild build.proj and once it finishes, then execute whatever target you need to do e.g. msbuild build.proj /t:RunTests /p:Scope=SDKs\Compute. After downloading all build related assets will be downloaded under <root>\tools\SdkBuildTools. Moving bunch of legacy code to legacy directory. Removing build tasks out of this branch, currently being moved to legacy directory * Update README.md Updating readme to document recent build changes that were done to extract build tools out of main branch. * Adding data factory CRUD scenario test (#3774) * This is the first batch of scenario tests for the ADF V2 SDK. * Partially addresses #3726; more tests need to be added * Update Batch supporting assemblies (#3794) * [ADLA] - Update changelog for version 3.0.2 (#3792) * Merge from private Networking (#3771) * Regenerated Networking SDK on 2017-09-01, private * Expose new operation for VpnDeviceConfiguration for Vpn Gateways * Adding AzureReachabilityReport and AvailableProvidersList APIs + tests * Updating version of Network SDK * Disabling tests for AzureReachabilityReport and AvailableProvidersList APIs * Updated version * Caa record support in Azure DNS (#3785) * upgrade .net.test.sk project to stable version * support for CAA records * changing assembly file version to reflect nuget version * update swagger from public repo * addressing code review comments * bumping up assembly verson to 2.0.0.0 * [ADLA - ADLS] - [HOTFIX] - Update changelog (#3802) * [ADLA] - Update changelog for version 3.0.2 * [ADLA] - Update changelog * [ADLS] - Update changelog * Update changelog * 3.0.1 for ADLA was never published to nuget * 2.2.1 for ADLS was never published to nuget * Adding .NET SDK changes for Server DNS Aliasing (#3803) * Auto generated files for .NET SDK for Server DNS Aliasing. Also contains removing unused declarations from bunch of files. Everything generated automatically * Adding tests for server dns aliasing and their recording * Fixing sql_resource_manager.txt * Updating new version of SDK in AssemblyInfo.cs and csproj file * Small cosmetic changes to address Jared * Revert "Small cosmetic changes to address Jared" This reverts commit 5a5e426. * Reverting version change in project and AssemblyInfo files; addressing small change requests from Jared in pull request * [ACR] Update SDK to 2017-10-01 version (#3778) * Update ACR SDK to 2017-10-01 version * Update csproj, re-record tests * Address PR review feedback Address PR review feedback * Fix issue with missing Unit enumeration values, fix documentation issues, improved tests for multi-dim metrics API (#3809) * [Monitor] Fixing doc issues, adding two values to the metric unit enumeration, generating metadata files * Increasing version number due to a bug fix and documentation updates * [Monitor] Adding multi-dimensional metrics tests * Re-generate SDKs/Resource (#3793) * Updated Network SDK version (#3814) * Added Zone Redundant Property To Database, Elastic Pool and Edition Capability (#3800) * Add zone redundant property for database, elastic pool and capability edition * Added zone redundant property release notes * Revert "Removing build tools outside of branches (#3780)" This reverts commit deceaf3. * Revert "Revert "Removing build tools outside of branches (#3780)"" This reverts commit 58265b9. * Rerun tests to fix validation errors * Remove null capability test * Cancel pipeline run (#3812) * Cancel pipeline run api * Makin cancel run to factory operation * Example and unit test for cancel pipeline run api. * Regenerating SDK accoring to latest instructions * Scenario test for cancel run api * Scenario test for pipeline run 2 * Regenerating SDK and adding text file with generation metadata * Adding version 0.2.1 * Merged ADMS changes for Oct. SDK release * Add linked service scenario test (resolves #3726) (#3798) * Adds a simple CRUD test for linked services * Also change all tests to check for proper HTTP response codes on each API call * Resolves #3726 * Updated RecoveryServices.Backup Tests (#3822) - Updated tests to address Azure/azure-sdk-for-python#1422 - Updated test settings (VM name etc) for Backup tests and re-recorded tests

* Update ACR SDK to 2017-10-01 version * Update csproj, re-record tests * Address PR review feedback Address PR review feedback

shahabhijeet suggested changes Oct 13, 2017

View reviewed changes

shahabhijeet added the Changes Requested label Oct 13, 2017

djyou added 2 commits October 13, 2017 15:27

Update ACR SDK to 2017-10-01 version

03fd780

Update csproj, re-record tests

89b6b77

shahabhijeet suggested changes Oct 16, 2017

View reviewed changes

Address PR review feedback

7c7664c

Address PR review feedback

shahabhijeet approved these changes Oct 20, 2017

View reviewed changes

shahabhijeet merged commit bf96f51 into Azure:psSdkJson6 Oct 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ACR] Update SDK to 2017-10-01 version #3778

[ACR] Update SDK to 2017-10-01 version #3778

djyou commented Oct 12, 2017 •

edited

Loading

djyou commented Oct 12, 2017

shahabhijeet commented Oct 13, 2017

shahabhijeet Oct 13, 2017

shahabhijeet Oct 13, 2017

djyou Oct 13, 2017 •

edited

Loading

shahabhijeet Oct 13, 2017

shahabhijeet Oct 16, 2017

djyou Oct 16, 2017

shahabhijeet Oct 16, 2017

djyou Oct 16, 2017

shahabhijeet Oct 18, 2017

djyou Oct 18, 2017

djyou Oct 18, 2017

djyou commented Oct 16, 2017

[ACR] Update SDK to 2017-10-01 version #3778

[ACR] Update SDK to 2017-10-01 version #3778

Conversation

djyou commented Oct 12, 2017 • edited Loading

Description

djyou commented Oct 12, 2017

shahabhijeet commented Oct 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djyou Oct 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djyou commented Oct 16, 2017

djyou commented Oct 12, 2017 •

edited

Loading

djyou Oct 13, 2017 •

edited

Loading