refactor: replace function definitions with imports from powersimdata

[danielolsen]

Pull Request doc

Purpose

This is a companion PR to Breakthrough-Energy/PowerSimData#507. Once code is moved from PostREISE to PowerSimData, within PostREISE we import it from PowerSimData. We do this within the old modules to maintain backward compatibility, although eventually we should probably deprecate and remove these in favor of direct imports.

What the code is doing

No code, besides imports.

Testing

Unit tests fail using the current PowerSimData/develop branch, but pass when checked locally using the branch from Breakthrough-Energy/PowerSimData#507

Time estimate

5 minutes.

[rouille]

When would we actually plan to change all the import statements throughout PostREISE to import the functions now located in PowerSimData

[danielolsen]

When would we actually plan to change all the import statements throughout PostREISE to import the functions now located in PowerSimData

Good question. I don't know if we have any external workflows that depend on PostREISE right now (website maybe?), so I opted for compatibility, but I could change if we want.

[rouille]

When would we actually plan to change all the import statements throughout PostREISE to import the functions now located in PowerSimData

Good question. I don't know if we have any external workflows that depend on PostREISE right now (website maybe?), so I opted for compatibility, but I could change if we want.

Not sure. I don't think the website relies on the analysis/plotting modules. The question is more about release. I guess we need a new release in PowerSimData. Do we want to have a new release in PostREISE too?

[danielolsen]

When would we actually plan to change all the import statements throughout PostREISE to import the functions now located in PowerSimData

Good question. I don't know if we have any external workflows that depend on PostREISE right now (website maybe?), so I opted for compatibility, but I could change if we want.

Not sure. I don't think the website relies on the analysis/plotting modules. The question is more about release. I guess we need a new release in PowerSimData. Do we want to have a new release in PostREISE too?

I guess to be most correct, we should increment the PowerSimData release to 0.4.3 after Breakthrough-Energy/PowerSimData#507 is merged, then create a new release in PostREISE that requires PowerSimData >= 0.4.3? I guess we can roll that into #308.

[danielolsen]

There are also a lot of not-time-series-specific functions in postreise.analyze.helpers. Do we want to move these to powersimdata at the same time?

[rouille]

There are also a lot of not-time-series-specific functions in postreise.analyze.helpers. Do we want to move these to powersimdata at the same time?

It seems that the entire module is grid specific and could be moved in powersimdata/input

[danielolsen]

This has been updated to directly import what used to be postreise.analyze.check and postreise.analyze.helpers from their new locations. Tests pass using the PowerSimData branch from Breakthrough-Energy/PowerSimData#512.

[rouille]

This has been updated to directly import what used to be postreise.analyze.check and postreise.analyze.helpers from their new locations. Tests pass using the PowerSimData branch from Breakthrough-Energy/PowerSimData#512.

Good question. @jon-hagg?

[jenhagg]

This has been updated to directly import what used to be postreise.analyze.check and postreise.analyze.helpers from their new locations. Tests pass using the PowerSimData branch from Breakthrough-Energy/PowerSimData#512.

Good question. @jon-hagg?

What's the question?

[rouille]

This has been updated to directly import what used to be postreise.analyze.check and postreise.analyze.helpers from their new locations. Tests pass using the PowerSimData branch from Breakthrough-Energy/PowerSimData#512.

Good question. @jon-hagg?

What's the question?

I guess I posted in the wrong PR. Nevermind