Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify PowerSimData dependency #314

Merged
merged 1 commit into from
Jul 1, 2021
Merged

docs: clarify PowerSimData dependency #314

merged 1 commit into from
Jul 1, 2021

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Jul 1, 2021

Pull Request doc

Purpose

Add a sentence in the README that states that PowerSimData must be cloned next to PostREISE. It tricked me yesterday.

What the code is doing

No code

Testing

N/A

Where to look

The Depencies section

Usage Example/Visuals

N/A

Time estimate

2min

@rouille rouille added the documentation Documentation related to package label Jul 1, 2021
@rouille rouille self-assigned this Jul 1, 2021
@danielolsen
Copy link
Contributor

Between this PR and #310, maybe it's time that we put PowerSimData on PyPI.

@rouille
Copy link
Collaborator Author

rouille commented Jul 1, 2021

Between this PR and #310, maybe it's time that we put PowerSimData on PyPI.

@kasparm and @jon-hagg, what do you think of having PowerSimData on PyPI?

@jenhagg
Copy link
Collaborator

jenhagg commented Jul 1, 2021

The more we talk about versioning, the more I'm in favor of putting the package on PyPI. In the meantime, we could avoid the extra installation step by using the github url as we do in switchwrapper.

@rouille rouille merged commit 43c30dd into develop Jul 1, 2021
@rouille rouille deleted the ben/readme branch July 1, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related to package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants