Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split appsec telemetry file into rasp, waf and user #5303

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Conversation

IlyasShabi
Copy link
Contributor

@IlyasShabi IlyasShabi commented Feb 20, 2025

What does this PR do?

Only split telemetry file into multiple files no new features were introduced

Motivation

First task to prepare for new WAF and RASP telemetry metrics

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Feb 20, 2025

Overall package size

Self size: 8.81 MB
Deduped: 95.01 MB
No deduping: 95.53 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 98.97959% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (4733649) to head (364f3cb).
Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/appsec/telemetry/rasp.js 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5303      +/-   ##
==========================================
- Coverage   80.93%   80.63%   -0.31%     
==========================================
  Files         488      489       +1     
  Lines       21840    21830      -10     
==========================================
- Hits        17677    17603      -74     
- Misses       4163     4227      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 20, 2025

Datadog Report

Branch report: split-telemetry
Commit report: 0235953
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 672 Passed, 0 Skipped, 14m 31.25s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2025

Benchmarks

Benchmark execution time: 2025-02-26 16:29:19

Comparing candidate commit 364f3cb in PR branch split-telemetry with baseline commit 4733649 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 916 metrics, 17 unstable metrics.

@IlyasShabi IlyasShabi marked this pull request as ready for review February 20, 2025 11:14
@IlyasShabi IlyasShabi requested a review from a team as a code owner February 20, 2025 11:14
Copy link
Collaborator

@uurien uurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we separate also the test file DataDog/dd-trace-js/packages/dd-trace/test/appsec/telemetry.spec.js?

@IlyasShabi
Copy link
Contributor Author

I don't have a strong opinion on splitting this test file for the moment. However, since we'll be adding more tests for new metrics, it makes sense to split them

@IlyasShabi IlyasShabi requested a review from uurien February 21, 2025 13:55
@IlyasShabi IlyasShabi requested a review from uurien February 26, 2025 18:08
@simon-id
Copy link
Member

this is semver patch no ? you're not modifying any feature ?

@IlyasShabi IlyasShabi merged commit d36907b into master Feb 27, 2025
398 checks passed
@IlyasShabi IlyasShabi deleted the split-telemetry branch February 27, 2025 09:04
juan-fernandez pushed a commit that referenced this pull request Feb 28, 2025
* Split appsec telemetry file into rasp, waf and user

* split appsec telemetry test files

* remove unused success param

* fix user test file name
@juan-fernandez juan-fernandez mentioned this pull request Feb 28, 2025
juan-fernandez pushed a commit that referenced this pull request Feb 28, 2025
* Split appsec telemetry file into rasp, waf and user

* split appsec telemetry test files

* remove unused success param

* fix user test file name
@juan-fernandez juan-fernandez mentioned this pull request Feb 28, 2025
juan-fernandez pushed a commit that referenced this pull request Feb 28, 2025
* Split appsec telemetry file into rasp, waf and user

* split appsec telemetry test files

* remove unused success param

* fix user test file name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants