Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.39.1 proposal #5343

Closed
wants to merge 10 commits into from
Closed

v5.39.1 proposal #5343

wants to merge 10 commits into from

Conversation

juan-fernandez
Copy link
Collaborator

  • [522aa56c7d] - (SEMVER-PATCH) lazy load public api + profiling + crashtracking + span stats (Roch Devost) #5256
  • [5f9757c9d2] - (SEMVER-PATCH) Add missing decrement method to DogStatsDClient (Ruben Bridgewater) #5330
  • [7880319596] - (SEMVER-PATCH) Add TODO comment about appsec code in RC index (simon-id) #5339
  • [e7f7a2fcde] - (SEMVER-PATCH) [test optimization] Fix possible crash with known tests (Juan Antonio Fernández de Alba) #5328
  • [845120d8cf] - (SEMVER-PATCH) CI: Remove unused GH Actions (Thomas Watson) #5332
  • [bc1450a1b6] - (SEMVER-PATCH) CI: Run some GH action jobs on the latest Node.js version as well (Thomas Watson) #5325
  • [9571c02642] - (SEMVER-PATCH) CI: Remove redundant GH Action steps (Thomas Watson) #5331
  • [10da8f2994] - (SEMVER-PATCH) [test optimization] Lazy load failed test replay logic (Juan Antonio Fernández de Alba) #5327
  • [d36907b672] - (SEMVER-PATCH) Split appsec telemetry file into rasp, waf and user (Ilyas Shabi) #5303

IlyasShabi and others added 10 commits February 28, 2025 11:06
* Split appsec telemetry file into rasp, waf and user

* split appsec telemetry test files

* remove unused success param

* fix user test file name
)

All the jobs that are currently testing all all supported Node.js
versions has now been amended to also test on the latest Node.js version
as well.
I ported an open PR and added additional fixes to the code.

The `NoopDogStatsDClient` gets used by default in unit tests.  However, it
is missing the `decrement` method which causes tests to throw exceptions
when trying to call it.

The `DogStatsDClient` is also missing the decrement method. Instead, the increment method was used by the the custom metric implementation. This is adjusted.

Please check the commit messages for further information.

Fixes #4285
Closes #5241 The `NoopDogStatsDClient` gets used by default in unit tests.  However, it
is missing the `decrement` method which causes tests to throw exceptions
when trying to call it.

---------

Co-authored-by: Justin Johnson <[email protected]>
Copy link

Overall package size

Self size: 8.81 MB
Deduped: 95.01 MB
No deduping: 95.52 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 96.24060% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5.x@f0c5551). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...src/ci-visibility/dynamic-instrumentation/index.js 75.00% 2 Missing ⚠️
packages/dd-trace/src/proxy.js 88.88% 2 Missing ⚠️
packages/dd-trace/src/appsec/telemetry/rasp.js 93.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v5.x    #5343   +/-   ##
=======================================
  Coverage        ?   80.60%           
=======================================
  Files           ?      487           
  Lines           ?    21760           
  Branches        ?        0           
=======================================
  Hits            ?    17540           
  Misses          ?     4220           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: v5.39.1-proposal
Commit report: 58236da
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 669 Passed, 0 Skipped, 13m 28.84s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2025

Benchmarks

Benchmark execution time: 2025-02-28 10:19:21

Comparing candidate commit 30c2213 in PR branch v5.39.1-proposal with baseline commit f0c5551 in branch v5.x.

Found 26 performance improvements and 11 performance regressions! Performance is the same for 880 metrics, 16 unstable metrics.

scenario:appsec-iast-startup-time-control-22

  • 🟩 cpu_user_time [-52.894ms; -34.757ms] or [-7.723%; -5.075%]
  • 🟩 execution_time [-50.470ms; -46.144ms] or [-6.263%; -5.726%]

scenario:appsec-iast-startup-time-iast-enabled-20

  • 🟥 max_rss_usage [+14.220MB; +16.205MB] or [+9.948%; +11.337%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-22

  • 🟥 max_rss_usage [+6.459MB; +9.308MB] or [+5.256%; +7.575%]

scenario:appsec-startup-time-appsec-enabled-20

  • 🟩 cpu_user_time [-51.335ms; -40.440ms] or [-6.525%; -5.140%]

scenario:appsec-startup-time-control-22

  • 🟩 cpu_user_time [-44.922ms; -36.629ms] or [-6.769%; -5.520%]
  • 🟩 execution_time [-47.930ms; -39.910ms] or [-6.115%; -5.092%]

scenario:exporting-pipeline-0.5-18

  • 🟩 cpu_user_time [-21.182ms; -17.633ms] or [-9.803%; -8.161%]
  • 🟩 execution_time [-22.480ms; -19.486ms] or [-9.044%; -7.839%]
  • 🟩 instructions [-37.2M instructions; -34.2M instructions] or [-6.486%; -5.956%]

scenario:exporting-pipeline-0.5-20

  • 🟩 cpu_user_time [-20.108ms; -16.905ms] or [-10.014%; -8.419%]
  • 🟩 execution_time [-20.598ms; -17.746ms] or [-8.587%; -7.398%]
  • 🟩 instructions [-34.8M instructions; -31.7M instructions] or [-7.180%; -6.527%]

scenario:exporting-pipeline-0.5-22

  • 🟩 cpu_user_time [-19.375ms; -16.849ms] or [-10.608%; -9.225%]
  • 🟩 execution_time [-19.698ms; -18.095ms] or [-9.271%; -8.517%]
  • 🟩 instructions [-31.2M instructions; -28.3M instructions] or [-6.144%; -5.584%]

scenario:log-skip-log-20

  • 🟩 cpu_user_time [-25.145ms; -19.093ms] or [-7.415%; -5.630%]
  • 🟩 execution_time [-25.188ms; -21.268ms] or [-6.689%; -5.648%]

scenario:log-with-debug-20

  • 🟩 cpu_user_time [-27.517ms; -22.065ms] or [-8.097%; -6.493%]
  • 🟩 execution_time [-25.763ms; -21.989ms] or [-6.856%; -5.851%]

scenario:log-with-debug-22

  • 🟥 cpu_user_time [+13.239ms; +17.510ms] or [+5.122%; +6.775%]

scenario:log-with-error-20

  • 🟩 cpu_user_time [-25.643ms; -19.433ms] or [-7.598%; -5.758%]
  • 🟩 execution_time [-24.553ms; -20.131ms] or [-6.532%; -5.356%]

scenario:log-with-error-22

  • 🟥 cpu_user_time [+12.895ms; +17.284ms] or [+5.059%; +6.781%]

scenario:log-without-log-20

  • 🟩 cpu_user_time [-26.300ms; -21.249ms] or [-8.345%; -6.742%]
  • 🟩 execution_time [-26.582ms; -23.121ms] or [-7.495%; -6.520%]

scenario:log-without-log-22

  • 🟥 cpu_user_time [+14.980ms; +19.244ms] or [+6.423%; +8.251%]
  • 🟥 execution_time [+14.715ms; +16.454ms] or [+5.375%; +6.010%]

scenario:plugin-q-with-tracer-22

  • 🟩 cpu_user_time [-89.882ms; -69.151ms] or [-10.282%; -7.910%]
  • 🟩 execution_time [-87.884ms; -66.956ms] or [-9.048%; -6.893%]

scenario:spans-finish-later-22

  • 🟥 cpu_user_time [+60.726ms; +75.716ms] or [+6.262%; +7.808%]
  • 🟥 execution_time [+58.849ms; +74.053ms] or [+5.274%; +6.637%]
  • 🟥 instructions [+261.9M instructions; +354.2M instructions] or [+10.032%; +13.565%]

scenario:startup-with-tracer-20

  • 🟩 cpu_user_time [-25.128ms; -19.389ms] or [-11.746%; -9.063%]
  • 🟩 execution_time [-23.238ms; -21.349ms] or [-9.265%; -8.512%]

scenario:startup-with-tracer-22

  • 🟥 cpu_user_time [+10.132ms; +15.824ms] or [+6.085%; +9.504%]
  • 🟥 execution_time [+12.407ms; +13.665ms] or [+6.095%; +6.713%]

@juan-fernandez
Copy link
Collaborator Author

closing to do a minor instead to include #5198

@juan-fernandez juan-fernandez deleted the v5.39.1-proposal branch February 28, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants