v5.40.0 proposal #5344

juan-fernandez · 2025-02-28T11:03:33Z

[444ad14555] - (SEMVER-MINOR) Disable APM tracing (standalone billing) (Igor Unanua) #5198
[522aa56c7d] - (SEMVER-PATCH) lazy load public api + profiling + crashtracking + span stats (Roch Devost) #5256
[5f9757c9d2] - (SEMVER-PATCH) Add missing decrement method to DogStatsDClient (Ruben Bridgewater) #5330
[7880319596] - (SEMVER-PATCH) Add TODO comment about appsec code in RC index (simon-id) #5339
[e7f7a2fcde] - (SEMVER-PATCH) [test optimization] Fix possible crash with known tests (Juan Antonio Fernández de Alba) #5328
[845120d8cf] - (SEMVER-PATCH) CI: Remove unused GH Actions (Thomas Watson) #5332
[bc1450a1b6] - (SEMVER-PATCH) CI: Run some GH action jobs on the latest Node.js version as well (Thomas Watson) #5325
[9571c02642] - (SEMVER-PATCH) CI: Remove redundant GH Action steps (Thomas Watson) #5331
[10da8f2994] - (SEMVER-PATCH) [test optimization] Lazy load failed test replay logic (Juan Antonio Fernández de Alba) #5327
[d36907b672] - (SEMVER-PATCH) Split appsec telemetry file into rasp, waf and user (Ilyas Shabi) #5303

* Split appsec telemetry file into rasp, waf and user * split appsec telemetry test files * remove unused success param * fix user test file name

) All the jobs that are currently testing all all supported Node.js versions has now been amended to also test on the latest Node.js version as well.

I ported an open PR and added additional fixes to the code. The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. The `DogStatsDClient` is also missing the decrement method. Instead, the increment method was used by the the custom metric implementation. This is adjusted. Please check the commit messages for further information. Fixes #4285 Closes #5241 The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. --------- Co-authored-by: Justin Johnson <[email protected]>

* move standalone products, tracesource, prioritySampler, etc * fixes and tests * publish 'datadog:tracer:configure' * rename config prop as apmTracingEnabled * appsec standalone module * fix integration tests * clean up * simplify rateLimiter configuration * support 32 bit tracesource masks * clean up * remove b-3x headers and clear traceparent * delete traceparent header and tests * product getProductRateLimiter tests * increase coverage * test.ts * SpanStatsProcessor should disable stats only if apmTracingEnabled is false * calculate stats.enabled in config.js * show deprecated appsec.standalone.enabled * fix merge * fix again :S * Change property comment * keep appsec.standalone.enabled * lint * lint * lint

github-actions · 2025-02-28T11:04:18Z

Overall package size

Self size: 8.81 MB
Deduped: 95.01 MB
No deduping: 95.52 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2025-02-28T11:04:41Z

Codecov Report

Attention: Patch coverage is 97.80702% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5.x@f0c5551). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...src/ci-visibility/dynamic-instrumentation/index.js	75.00%	2 Missing ⚠️
packages/dd-trace/src/proxy.js	88.88%	2 Missing ⚠️
packages/dd-trace/src/appsec/telemetry/rasp.js	93.33%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             v5.x    #5344   +/-   ##
=======================================
  Coverage        ?   80.64%           
=======================================
  Files           ?      490           
  Lines           ?    21769           
  Branches        ?        0           
=======================================
  Hits            ?    17556           
  Misses          ?     4213           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

datadog-datadog-prod-us1 · 2025-02-28T11:09:40Z

Datadog Report

Branch report: v5.40.0-proposal
Commit report: 65db03a
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 675 Passed, 0 Skipped, 14m 23.71s Total Time

pr-commenter · 2025-02-28T11:11:43Z

Benchmarks

Benchmark execution time: 2025-02-28 11:11:40

Comparing candidate commit fc17c43 in PR branch v5.40.0-proposal with baseline commit f0c5551 in branch v5.x.

Found 24 performance improvements and 9 performance regressions! Performance is the same for 885 metrics, 15 unstable metrics.

scenario:appsec-iast-startup-time-control-22

🟩 execution_time [-51.111ms; -42.717ms] or [-6.362%; -5.318%]

scenario:appsec-iast-startup-time-iast-enabled-20

🟥 max_rss_usage [+14.591MB; +16.473MB] or [+10.220%; +11.538%]

scenario:appsec-startup-time-control-22

🟩 cpu_user_time [-45.671ms; -36.594ms] or [-6.886%; -5.518%]
🟩 execution_time [-48.756ms; -40.521ms] or [-6.243%; -5.189%]

scenario:exporting-pipeline-0.5-18

🟩 cpu_user_time [-21.386ms; -17.898ms] or [-9.871%; -8.261%]
🟩 execution_time [-22.505ms; -19.627ms] or [-9.060%; -7.901%]
🟩 instructions [-37.8M instructions; -34.3M instructions] or [-6.581%; -5.984%]

scenario:exporting-pipeline-0.5-20

🟩 cpu_user_time [-19.313ms; -16.142ms] or [-9.639%; -8.056%]
🟩 execution_time [-19.511ms; -16.829ms] or [-8.165%; -7.043%]
🟩 instructions [-35.4M instructions; -32.6M instructions] or [-7.294%; -6.703%]

scenario:exporting-pipeline-0.5-22

🟩 cpu_user_time [-17.743ms; -15.254ms] or [-9.756%; -8.388%]
🟩 execution_time [-18.820ms; -17.425ms] or [-8.883%; -8.225%]
🟩 instructions [-31.5M instructions; -28.2M instructions] or [-6.192%; -5.556%]

scenario:log-skip-log-20

🟩 cpu_user_time [-28.375ms; -22.431ms] or [-8.328%; -6.584%]
🟩 execution_time [-26.914ms; -23.242ms] or [-7.116%; -6.145%]

scenario:log-with-debug-20

🟩 cpu_user_time [-28.260ms; -23.507ms] or [-8.319%; -6.920%]
🟩 execution_time [-26.327ms; -23.594ms] or [-6.987%; -6.262%]

scenario:log-with-debug-22

🟥 cpu_user_time [+13.561ms; +17.711ms] or [+5.272%; +6.886%]

scenario:log-with-error-20

🟩 cpu_user_time [-26.776ms; -21.005ms] or [-7.922%; -6.215%]
🟩 execution_time [-24.704ms; -19.578ms] or [-6.574%; -5.210%]

scenario:log-with-error-22

🟥 cpu_user_time [+14.172ms; +18.641ms] or [+5.614%; +7.384%]

scenario:log-without-log-20

🟩 cpu_user_time [-27.671ms; -22.940ms] or [-8.765%; -7.266%]
🟩 execution_time [-26.642ms; -24.953ms] or [-7.532%; -7.055%]

scenario:log-without-log-22

🟥 cpu_user_time [+13.054ms; +17.923ms] or [+5.557%; +7.630%]

scenario:plugin-q-with-tracer-22

🟩 cpu_user_time [-92.076ms; -72.081ms] or [-10.536%; -8.248%]
🟩 execution_time [-93.067ms; -72.851ms] or [-9.557%; -7.481%]

scenario:spans-finish-later-22

🟥 cpu_user_time [+57.786ms; +74.668ms] or [+5.937%; +7.671%]
🟥 execution_time [+57.625ms; +73.689ms] or [+5.154%; +6.590%]
🟥 instructions [+288.2M instructions; +370.1M instructions] or [+11.039%; +14.176%]

scenario:startup-with-tracer-20

🟩 cpu_user_time [-22.604ms; -17.410ms] or [-10.571%; -8.142%]
🟩 execution_time [-23.231ms; -21.605ms] or [-9.255%; -8.607%]

scenario:startup-with-tracer-22

🟥 cpu_user_time [+10.707ms; +17.594ms] or [+6.502%; +10.684%]
🟥 execution_time [+12.202ms; +13.500ms] or [+6.002%; +6.640%]

IlyasShabi and others added 11 commits February 28, 2025 12:03

Split appsec telemetry file into rasp, waf and user (#5303)

cdd962c

* Split appsec telemetry file into rasp, waf and user * split appsec telemetry test files * remove unused success param * fix user test file name

[test optimization] Lazy load failed test replay logic (#5327)

e1d961c

CI: Remove redundant GH Action steps (#5331)

158adfb

CI: Run some GH action jobs on the latest Node.js version as well (#5325

e374109

) All the jobs that are currently testing all all supported Node.js versions has now been amended to also test on the latest Node.js version as well.

CI: Remove unused GH Actions (#5332)

78cf0b2

[test optimization] Fix possible crash with known tests (#5328)

1fdeacd

Add TODO comment about appsec code in RC index (#5339)

f0c8216

lazy load public api + profiling + crashtracking + span stats (#5256)

544f213

v5.40.0

fc17c43

juan-fernandez marked this pull request as ready for review February 28, 2025 12:08

juan-fernandez requested a review from a team as a code owner February 28, 2025 12:08

watson approved these changes Feb 28, 2025

View reviewed changes

juan-fernandez merged commit b90979a into v5.x Feb 28, 2025
394 checks passed

juan-fernandez deleted the v5.40.0-proposal branch February 28, 2025 12:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v5.40.0 proposal #5344

v5.40.0 proposal #5344

juan-fernandez commented Feb 28, 2025

github-actions bot commented Feb 28, 2025

codecov bot commented Feb 28, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Feb 28, 2025 •

edited

Loading

pr-commenter bot commented Feb 28, 2025

v5.40.0 proposal #5344

v5.40.0 proposal #5344

Conversation

juan-fernandez commented Feb 28, 2025

github-actions bot commented Feb 28, 2025

Overall package size

codecov bot commented Feb 28, 2025 • edited Loading

Codecov Report

datadog-datadog-prod-us1 bot commented Feb 28, 2025 • edited Loading

Datadog Report

pr-commenter bot commented Feb 28, 2025

Benchmarks

scenario:appsec-iast-startup-time-control-22

scenario:appsec-iast-startup-time-iast-enabled-20

scenario:appsec-startup-time-control-22

scenario:exporting-pipeline-0.5-18

scenario:exporting-pipeline-0.5-20

scenario:exporting-pipeline-0.5-22

scenario:log-skip-log-20

scenario:log-with-debug-20

scenario:log-with-debug-22

scenario:log-with-error-20

scenario:log-with-error-22

scenario:log-without-log-20

scenario:log-without-log-22

scenario:plugin-q-with-tracer-22

scenario:spans-finish-later-22

scenario:startup-with-tracer-20

scenario:startup-with-tracer-22

codecov bot commented Feb 28, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Feb 28, 2025 •

edited

Loading