Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog logo unreadable when in dark mode #430

Closed
charliettaylor opened this issue Apr 14, 2022 · 3 comments · Fixed by #468 or #481
Closed

Blog logo unreadable when in dark mode #430

charliettaylor opened this issue Apr 14, 2022 · 3 comments · Fixed by #468 or #481
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@charliettaylor
Copy link
Contributor

What happened?

The README logo is unreadable in dark mode, and the borders around the articles also disappears.

Light
image
Dark
image
@charliettaylor charliettaylor added the bug Something isn't working label Apr 14, 2022
@jaasonw jaasonw added the good first issue Good for newcomers label Apr 15, 2022
@jaasonw jaasonw linked a pull request Apr 15, 2022 that will close this issue
Blog page design tweaks #406
Closed
@jaasonw
Copy link
Contributor

jaasonw commented Apr 15, 2022

Fixed in #406

@jaasonw jaasonw assigned ghost Apr 23, 2022
@jaasonw
Copy link
Contributor

jaasonw commented Apr 23, 2022

@mikeploythai 😠

@ghost
Copy link

ghost commented Apr 25, 2022

@mikeploythai 😠

am busy will send out something this weekend

@karnikaavelumani karnikaavelumani mentioned this issue May 14, 2022
Merged
jaasonw added a commit to jaasonw/acmcsuf.com that referenced this issue May 24, 2022
@jaasonw
Fix blog logo on dark mode
193c77d 
Cmon guys, it can NOT seriously be this hard to fix this one
Resolves: EthanThatOneKid#430
@jaasonw jaasonw linked a pull request May 24, 2022 that will close this issue
Add author, image, and read time estimate to blog #481
Merged
jaasonw added a commit that referenced this issue Jun 4, 2022
@jaasonw @karnikaavelumani
Add author, image, and read time estimate to blog (#481)
450f255 
* Progress

* Progress 2.0

* Fixed reference to SVG image

Small edit in code

* add author, image, and minutes read estimate to blog

* lint

* Fix blog logo on dark mode

Cmon guys, it can NOT seriously be this hard to fix this one
Resolves: #430

* Update test case for new title

* [5:42 PM] EthanThatOneKid: i dont wanna nit too much on github lol but in your scss can u space out the nested scss definitions too

* Update parameter name and jsdoc

* lint

* moved stackoverflow comment

Doing this because it's a detail about the implementation that the function caller doesn't actually need to know about but is useful to someone actually reading the implementation

* util -> utils

* test cases

* [2:44 PM] EthanThatOneKid: bee-movie.txt with a hyphen and we have a deal btw

* STRING

Co-authored-by: Karnikaa Velumani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@jaasonw @charliettaylor