Add author, image, and read time estimate to blog #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Cmon guys, it can NOT seriously be this hard to fix this one Resolves: #430
oops, I forget karni fixed it, let's use her version instead
jaasonw
commented
May 24, 2022
EthanThatOneKid
requested changes
May 26, 2022
…t in your scss can u space out the nested scss definitions too
|
Could you please rename your utility file before merging this PR to match the rest of the utility files? |
Doing this because it's a detail about the implementation that the function caller doesn't actually need to know about but is useful to someone actually reading the implementation
|
The tags look kinda weird now with the author stuff, maybe add a like Tags: prefix and line it up with the text above it
|
Resolved by #492 |
…uthor, restyle tags" This reverts commit bab7088.
EthanThatOneKid
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting a pull request for once because I'm a blogger now and I now have a personal stake in this part of the website : )
Also incorporates the changes from #468 but updates the title and test cases